Weird formatting in rtl8723bs driver code?

Weird formatting in rtl8723bs driver code?

[Emily Peri]

I'm working on cleaning up the rtl8723bs driver with checkpatch, but I
noticed that some of the variable declarations have differnt amounts of
whitespace, like this:

        struct cmd_obj  *ph2c;
        struct sitesurvey_parm  *psurveyPara;
        struct cmd_priv                                 *pcmdpriv = &padapter->cmdpriv;
        struct mlme_ext_priv    *pmlmeext = &padapter->mlmeextpriv;

At first I thought this was intentional, but now I'm wondering if this
is an accident. It's normal to just use one space between the type and
the variable name, right?


--Emily

Re: Weird formatting in rtl8723bs driver code?

[Praveen Kumar]

On 20-10-2022 08:13, Emily Peri wrote:
> I'm working on cleaning up the rtl8723bs driver with checkpatch, but I
> noticed that some of the variable declarations have differnt amounts of
> whitespace, like this:
> 
>         struct cmd_obj  *ph2c;
>         struct sitesurvey_parm  *psurveyPara;

Addition to white-spaces you can also rework on making variable names to Linux standards, something like "psurveyPara" to "psurvey_para".


>         struct cmd_priv                                 *pcmdpriv = &padapter->cmdpriv;

This needs some formatting in my understanding. 

>         struct mlme_ext_priv    *pmlmeext = &padapter->mlmeextpriv;
> 
> At first I thought this was intentional, but now I'm wondering if this
> is an accident. It's normal to just use one space between the type and
> the variable name, right?
> 

In my understanding and what I've observed we use one space between the data type and variable name, but would let others to comment on this. Thanks.

> 
> --Emily


Regards,

~Praveen.

Re: Weird formatting in rtl8723bs driver code?

[Emily Peri]

On Thu, Oct 20, 2022 at 09:31:33AM +0530, Praveen Kumar wrote:
> On 20-10-2022 08:13, Emily Peri wrote:
> > I'm working on cleaning up the rtl8723bs driver with checkpatch, but I
> > noticed that some of the variable declarations have differnt amounts of
> > whitespace, like this:
> > 
> >         struct cmd_obj  *ph2c;
> >         struct sitesurvey_parm  *psurveyPara;
> 
> Addition to white-spaces you can also rework on making variable names to Linux standards, something like "psurveyPara" to "psurvey_para".

Great suggestion, thanks!

> 
> >         struct cmd_priv                                 *pcmdpriv = &padapter->cmdpriv;
> 
> This needs some formatting in my understanding. 
> 
> >         struct mlme_ext_priv    *pmlmeext = &padapter->mlmeextpriv;
> > 
> > At first I thought this was intentional, but now I'm wondering if this
> > is an accident. It's normal to just use one space between the type and
> > the variable name, right?
> > 
> 
> In my understanding and what I've observed we use one space between the data type and variable name, but would let others to comment on this. Thanks.

Okay good to know I'm not alone in this line of thinking haha. If I
continue working on this driver (probaly won't get to it until Friday)
I'll clean up the spacing.

> > 
> > --Emily
> 
> 
> Regards,
> 
> ~Praveen.

Re: Weird formatting in rtl8723bs driver code?

[Julia Lawall]

On Wed, 19 Oct 2022, Emily Peri wrote:

> I'm working on cleaning up the rtl8723bs driver with checkpatch, but I
> noticed that some of the variable declarations have differnt amounts of
> whitespace, like this:
>
>         struct cmd_obj  *ph2c;
>         struct sitesurvey_parm  *psurveyPara;
>         struct cmd_priv                                 *pcmdpriv = &padapter->cmdpriv;
>         struct mlme_ext_priv    *pmlmeext = &padapter->mlmeextpriv;
>
> At first I thought this was intentional, but now I'm wondering if this
> is an accident. It's normal to just use one space between the type and
> the variable name, right?

One space should be fine.  People may like to line up the variable names
in some cases, but this is clearly not lined up either.

julia

Re: Weird formatting in rtl8723bs driver code?

[Emily Peri]

On Thu, Oct 20, 2022 at 07:13:58AM +0200, Julia Lawall wrote:
> 
> 
> On Wed, 19 Oct 2022, Emily Peri wrote:
> 
> > I'm working on cleaning up the rtl8723bs driver with checkpatch, but I
> > noticed that some of the variable declarations have differnt amounts of
> > whitespace, like this:
> >
> >         struct cmd_obj  *ph2c;
> >         struct sitesurvey_parm  *psurveyPara;
> >         struct cmd_priv                                 *pcmdpriv = &padapter->cmdpriv;
> >         struct mlme_ext_priv    *pmlmeext = &padapter->mlmeextpriv;
> >
> > At first I thought this was intentional, but now I'm wondering if this
> > is an accident. It's normal to just use one space between the type and
> > the variable name, right?
> 
> One space should be fine.  People may like to line up the variable names
> in some cases, but this is clearly not lined up either.
> 
> julia

Oh, that makes more sense! I'll keep that in mind.