All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN
@ 2022-10-24  7:59 ` Quan Nguyen
  0 siblings, 0 replies; 4+ messages in thread
From: Quan Nguyen @ 2022-10-24  7:59 UTC (permalink / raw)
  To: Corey Minyard, Open Source Submission
  Cc: kernel test robot, Andrew Jeffery, openbmc, thang, Phong Vo,
	linux-kernel, Joel Stanley, openipmi-developer, Quan Nguyen

This fixes the following sparse warning:
sparse warnings: (new ones prefixed by >>)
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    left side has type restricted __poll_t
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    right side has type int

Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202210181103.ontD9tRT-lkp@intel.com/
Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
---
 drivers/char/ipmi/ssif_bmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index a7bb4b99000e..2d8069386398 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait)
 	spin_lock_irq(&ssif_bmc->lock);
 	/* The request is available, userspace application can get the request */
 	if (ssif_bmc->request_available)
-		mask |= POLLIN;
+		mask |= EPOLLIN;
 
 	spin_unlock_irq(&ssif_bmc->lock);
 
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN
@ 2022-10-24  7:59 ` Quan Nguyen
  0 siblings, 0 replies; 4+ messages in thread
From: Quan Nguyen @ 2022-10-24  7:59 UTC (permalink / raw)
  To: Corey Minyard, Open Source Submission
  Cc: Joel Stanley, Andrew Jeffery, openipmi-developer, linux-kernel,
	openbmc, Phong Vo, thang, Quan Nguyen, kernel test robot

This fixes the following sparse warning:
sparse warnings: (new ones prefixed by >>)
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    left side has type restricted __poll_t
>> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    right side has type int

Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202210181103.ontD9tRT-lkp@intel.com/
Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
---
 drivers/char/ipmi/ssif_bmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index a7bb4b99000e..2d8069386398 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait)
 	spin_lock_irq(&ssif_bmc->lock);
 	/* The request is available, userspace application can get the request */
 	if (ssif_bmc->request_available)
-		mask |= POLLIN;
+		mask |= EPOLLIN;
 
 	spin_unlock_irq(&ssif_bmc->lock);
 
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN
  2022-10-24  7:59 ` Quan Nguyen
@ 2022-10-24 14:20   ` Corey Minyard
  -1 siblings, 0 replies; 4+ messages in thread
From: Corey Minyard @ 2022-10-24 14:20 UTC (permalink / raw)
  To: Quan Nguyen
  Cc: kernel test robot, Andrew Jeffery, openbmc, thang, linux-kernel,
	Phong Vo, Joel Stanley, Open Source Submission,
	openipmi-developer

On Mon, Oct 24, 2022 at 02:59:56PM +0700, Quan Nguyen wrote:
> This fixes the following sparse warning:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    left side has type restricted __poll_t
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    right side has type int

Thanks, you beat me to tracing this down.  It's in my for-next queue.

-corey

> 
> Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202210181103.ontD9tRT-lkp@intel.com/
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
>  drivers/char/ipmi/ssif_bmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index a7bb4b99000e..2d8069386398 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait)
>  	spin_lock_irq(&ssif_bmc->lock);
>  	/* The request is available, userspace application can get the request */
>  	if (ssif_bmc->request_available)
> -		mask |= POLLIN;
> +		mask |= EPOLLIN;
>  
>  	spin_unlock_irq(&ssif_bmc->lock);
>  
> -- 
> 2.35.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN
@ 2022-10-24 14:20   ` Corey Minyard
  0 siblings, 0 replies; 4+ messages in thread
From: Corey Minyard @ 2022-10-24 14:20 UTC (permalink / raw)
  To: Quan Nguyen
  Cc: Open Source Submission, Joel Stanley, Andrew Jeffery,
	openipmi-developer, linux-kernel, openbmc, Phong Vo, thang,
	kernel test robot

On Mon, Oct 24, 2022 at 02:59:56PM +0700, Quan Nguyen wrote:
> This fixes the following sparse warning:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    left side has type restricted __poll_t
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:    right side has type int

Thanks, you beat me to tracing this down.  It's in my for-next queue.

-corey

> 
> Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202210181103.ontD9tRT-lkp@intel.com/
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
>  drivers/char/ipmi/ssif_bmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index a7bb4b99000e..2d8069386398 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait)
>  	spin_lock_irq(&ssif_bmc->lock);
>  	/* The request is available, userspace application can get the request */
>  	if (ssif_bmc->request_available)
> -		mask |= POLLIN;
> +		mask |= EPOLLIN;
>  
>  	spin_unlock_irq(&ssif_bmc->lock);
>  
> -- 
> 2.35.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-24 16:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24  7:59 [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN Quan Nguyen
2022-10-24  7:59 ` Quan Nguyen
2022-10-24 14:20 ` Corey Minyard
2022-10-24 14:20   ` Corey Minyard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.