From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Mark Brown <broonie@kernel.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0
Date: Tue, 1 Nov 2022 00:30:51 +0100 [thread overview]
Message-ID: <Y2Baq2gtpGVoIBJs@probook> (raw)
In-Reply-To: <Y2BURsf5xKyfMn4+@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote:
> On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> > The node name for flash memories has been standardized to "flash@...".
> > Fix the example in nuvoton,npcm-fiu.txt accordingly.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Documentation/devicetree/bindings/spi/ has a wild mix of
- spi: <some vendor>:
- spi: dt-bindings:
- dt-bindings: spi:
"spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, "Tomer Maimon" <tmaimon77@gmail.com>,
"Avi Fishman" <avifishman70@gmail.com>,
"Patrick Venture" <venture@google.com>,
openbmc@lists.ozlabs.org,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Tali Perry" <tali.perry1@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Benjamin Fair" <benjaminfair@google.com>
Subject: Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0
Date: Tue, 1 Nov 2022 00:30:51 +0100 [thread overview]
Message-ID: <Y2Baq2gtpGVoIBJs@probook> (raw)
In-Reply-To: <Y2BURsf5xKyfMn4+@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote:
> On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> > The node name for flash memories has been standardized to "flash@...".
> > Fix the example in nuvoton,npcm-fiu.txt accordingly.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Documentation/devicetree/bindings/spi/ has a wild mix of
- spi: <some vendor>:
- spi: dt-bindings:
- dt-bindings: spi:
"spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-31 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 22:25 [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0 Jonathan Neuschäfer
2022-10-31 22:25 ` Jonathan Neuschäfer
2022-10-31 23:03 ` Mark Brown
2022-10-31 23:03 ` Mark Brown
2022-10-31 23:30 ` Jonathan Neuschäfer [this message]
2022-10-31 23:30 ` Jonathan Neuschäfer
2022-11-01 0:36 ` Jonathan Neuschäfer
2022-11-01 0:36 ` Jonathan Neuschäfer
2022-11-01 14:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Baq2gtpGVoIBJs@probook \
--to=j.neuschaefer@gmx.net \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.