[PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Jonathan Neuschäfer]

The node name for flash memories has been standardized to "flash@...".
Fix the example in nuvoton,npcm-fiu.txt accordingly.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
index c63ce4cc0a80f..fb38e96d395fb 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
+++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
@@ -51,7 +51,7 @@ fiu3: spi@c00000000 {
 	clocks = <&clk NPCM7XX_CLK_AHB>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&spi3_pins>;
-	spi-nor@0 {
+	flash@0 {
 			...
 	};
 };
--
2.35.1

[PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Jonathan Neuschäfer]

The node name for flash memories has been standardized to "flash@...".
Fix the example in nuvoton,npcm-fiu.txt accordingly.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
index c63ce4cc0a80f..fb38e96d395fb 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
+++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
@@ -51,7 +51,7 @@ fiu3: spi@c00000000 {
 	clocks = <&clk NPCM7XX_CLK_AHB>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&spi3_pins>;
-	spi-nor@0 {
+	flash@0 {
 			...
 	};
 };
--
2.35.1

Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> The node name for flash memories has been standardized to "flash@...".
> Fix the example in nuvoton,npcm-fiu.txt accordingly.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> The node name for flash memories has been standardized to "flash@...".
> Fix the example in nuvoton,npcm-fiu.txt accordingly.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Jonathan Neuschäfer]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote:
> On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> > The node name for flash memories has been standardized to "flash@...".
> > Fix the example in nuvoton,npcm-fiu.txt accordingly.
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Documentation/devicetree/bindings/spi/ has a wild mix of

 - spi: <some vendor>:
 - spi: dt-bindings:
 - dt-bindings: spi:


"spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2.


Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Jonathan Neuschäfer]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote:
> On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> > The node name for flash memories has been standardized to "flash@...".
> > Fix the example in nuvoton,npcm-fiu.txt accordingly.
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Documentation/devicetree/bindings/spi/ has a wild mix of

 - spi: <some vendor>:
 - spi: dt-bindings:
 - dt-bindings: spi:


"spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2.


Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Jonathan Neuschäfer]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Tue, Nov 01, 2022 at 12:30:51AM +0100, Jonathan Neuschäfer wrote:
> On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote:
> > On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> > > The node name for flash memories has been standardized to "flash@...".
> > > Fix the example in nuvoton,npcm-fiu.txt accordingly.
> > 
> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.


Ah sorry, I missed this line:

> > There's no need to resubmit to fix this alone.



> 
> Documentation/devicetree/bindings/spi/ has a wild mix of
> 
>  - spi: <some vendor>:
>  - spi: dt-bindings:
>  - dt-bindings: spi:
> 
> 
> "spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2.

So, no v2.


Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Jonathan Neuschäfer]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Tue, Nov 01, 2022 at 12:30:51AM +0100, Jonathan Neuschäfer wrote:
> On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote:
> > On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> > > The node name for flash memories has been standardized to "flash@...".
> > > Fix the example in nuvoton,npcm-fiu.txt accordingly.
> > 
> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.


Ah sorry, I missed this line:

> > There's no need to resubmit to fix this alone.



> 
> Documentation/devicetree/bindings/spi/ has a wild mix of
> 
>  - spi: <some vendor>:
>  - spi: dt-bindings:
>  - dt-bindings: spi:
> 
> 
> "spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2.

So, no v2.


Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0

[Mark Brown]

On Mon, 31 Oct 2022 23:25:59 +0100, Jonathan Neuschäfer wrote:
> The node name for flash memories has been standardized to "flash@...".
> Fix the example in nuvoton,npcm-fiu.txt accordingly.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0
      commit: e8d6e1dd609696128e646a8c747b0f3fb1e02545

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark