From: Andrew Lunn <andrew@lunn.ch>
To: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@linux.intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Voon Weifeng <weifeng.voon@intel.com>,
Tan Tee Min <tee.min.tan@intel.com>,
Looi Hong Aun <hong.aun.looi@intel.com>,
Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
Subject: Re: [PATCH net 1/1] net: stmmac: add check for supported link mode before mode change
Date: Wed, 9 Nov 2022 17:58:57 +0100 [thread overview]
Message-ID: <Y2vcUWFTdWG0D2GI@lunn.ch> (raw)
In-Reply-To: <20221109024329.15805-1-noor.azura.ahmad.tarmizi@linux.intel.com>
On Wed, Nov 09, 2022 at 10:43:29AM +0800, Noor Azura Ahmad Tarmizi wrote:
> From: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
>
> Currently, change for unsupported speed and duplex are sent to the phy,
> rendering the link to unknown speed (link state down).
Something does not seem correct. See:
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/net/phy/phy.c#L816
/* We make sure that we don't pass unsupported values in to the PHY */
linkmode_and(advertising, advertising, phydev->supported);
Do you somehow have phydev->supported set wrong?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@linux.intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Voon Weifeng <weifeng.voon@intel.com>,
Tan Tee Min <tee.min.tan@intel.com>,
Looi Hong Aun <hong.aun.looi@intel.com>,
Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
Subject: Re: [PATCH net 1/1] net: stmmac: add check for supported link mode before mode change
Date: Wed, 9 Nov 2022 17:58:57 +0100 [thread overview]
Message-ID: <Y2vcUWFTdWG0D2GI@lunn.ch> (raw)
In-Reply-To: <20221109024329.15805-1-noor.azura.ahmad.tarmizi@linux.intel.com>
On Wed, Nov 09, 2022 at 10:43:29AM +0800, Noor Azura Ahmad Tarmizi wrote:
> From: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@intel.com>
>
> Currently, change for unsupported speed and duplex are sent to the phy,
> rendering the link to unknown speed (link state down).
Something does not seem correct. See:
https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/net/phy/phy.c#L816
/* We make sure that we don't pass unsupported values in to the PHY */
linkmode_and(advertising, advertising, phydev->supported);
Do you somehow have phydev->supported set wrong?
Andrew
next prev parent reply other threads:[~2022-11-09 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 2:43 [PATCH net 1/1] net: stmmac: add check for supported link mode before mode change Noor Azura Ahmad Tarmizi
2022-11-09 2:43 ` Noor Azura Ahmad Tarmizi
2022-11-09 16:58 ` Andrew Lunn [this message]
2022-11-09 16:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2vcUWFTdWG0D2GI@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hong.aun.looi@intel.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=noor.azura.ahmad.tarmizi@intel.com \
--cc=noor.azura.ahmad.tarmizi@linux.intel.com \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=tee.min.tan@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.