+ zram-introduce-recompress-sysfs-knob-fix-2.patch added to mm-unstable branch

+ zram-introduce-recompress-sysfs-knob-fix-2.patch added to mm-unstable branch

[Andrew Morton]

The patch titled
     Subject: zram: explicitly limit prio_max for static analyzers
has been added to the -mm mm-unstable branch.  Its filename is
     zram-introduce-recompress-sysfs-knob-fix-2.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-introduce-recompress-sysfs-knob-fix-2.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: zram: explicitly limit prio_max for static analyzers
Date: Mon, 14 Nov 2022 11:14:20 +0900

Link: https://lkml.kernel.org/r/20221114021420.4060601-1-senozhatsky@chromium.org
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Suleiman Souhlal <suleiman@google.com>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/block/zram/zram_drv.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/block/zram/zram_drv.c~zram-introduce-recompress-sysfs-knob-fix-2
+++ a/drivers/block/zram/zram_drv.c
@@ -1689,6 +1689,7 @@ static int zram_recompress(struct zram *
 	 * Iterate the secondary comp algorithms list (in order of priority)
 	 * and try to recompress the page.
 	 */
+	prio_max = min(prio_max, ZRAM_MAX_COMPS);
 	for (; prio < prio_max; prio++) {
 		if (!zram->comps[prio])
 			continue;
_

Patches currently in -mm which might be from senozhatsky@chromium.org are

zram-preparation-for-multi-zcomp-support.patch
zram-add-recompression-algorithm-sysfs-knob.patch
zram-factor-out-wb-and-non-wb-zram-read-functions.patch
zram-introduce-recompress-sysfs-knob.patch
zram-introduce-recompress-sysfs-knob-fix.patch
zram-introduce-recompress-sysfs-knob-fix-2.patch
zram-add-recompress-flag-to-read_block_state.patch
zram-clarify-writeback_store-comment.patch
zram-use-is_err_value-to-check-for-zs_malloc-errors.patch
zram-remove-redundant-checks-from-zram_recompress.patch
zram-add-algo-parameter-support-to-zram_recompress.patch
documentation-add-zram-recompression-documentation.patch
zram-add-incompressible-writeback.patch
zram-add-incompressible-flag-to-read_block_state.patch

Re: + zram-introduce-recompress-sysfs-knob-fix-2.patch added to mm-unstable branch

[Minchan Kim]

On Mon, Nov 14, 2022 at 04:42:12PM -0800, Andrew Morton wrote:
> 
> The patch titled
>      Subject: zram: explicitly limit prio_max for static analyzers
> has been added to the -mm mm-unstable branch.  Its filename is
>      zram-introduce-recompress-sysfs-knob-fix-2.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-introduce-recompress-sysfs-knob-fix-2.patch
> 
> This patch will later appear in the mm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: Sergey Senozhatsky <senozhatsky@chromium.org>
> Subject: zram: explicitly limit prio_max for static analyzers
> Date: Mon, 14 Nov 2022 11:14:20 +0900
> 
> Link: https://lkml.kernel.org/r/20221114021420.4060601-1-senozhatsky@chromium.org
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Suleiman Souhlal <suleiman@google.com>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/block/zram/zram_drv.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/block/zram/zram_drv.c~zram-introduce-recompress-sysfs-knob-fix-2
> +++ a/drivers/block/zram/zram_drv.c
> @@ -1689,6 +1689,7 @@ static int zram_recompress(struct zram *
>  	 * Iterate the secondary comp algorithms list (in order of priority)
>  	 * and try to recompress the page.
>  	 */
> +	prio_max = min(prio_max, ZRAM_MAX_COMPS);
>  	for (; prio < prio_max; prio++) {
>  		if (!zram->comps[prio])
>  			continue;
> _

Hi Andrew,

Please drop this patch. It makes reviewer think "oh, zram_recompress
pass the higher prio_max value than the one zram allowed by somehow
so we need to get the min value here", which is not true once review
read code again/again and scratch head and then post patch to remove
the unncessary line. I prefer reviewer happier.

Re: + zram-introduce-recompress-sysfs-knob-fix-2.patch added to mm-unstable branch

[Sergey Senozhatsky]

On (22/11/15 14:58), Minchan Kim wrote:
> > --- a/drivers/block/zram/zram_drv.c~zram-introduce-recompress-sysfs-knob-fix-2
> > +++ a/drivers/block/zram/zram_drv.c
> > @@ -1689,6 +1689,7 @@ static int zram_recompress(struct zram *
> >  	 * Iterate the secondary comp algorithms list (in order of priority)
> >  	 * and try to recompress the page.
> >  	 */
> > +	prio_max = min(prio_max, ZRAM_MAX_COMPS);
> >  	for (; prio < prio_max; prio++) {
> >  		if (!zram->comps[prio])
> >  			continue;
> > _
> 
> Hi Andrew,
> 
> Please drop this patch. It makes reviewer think "oh, zram_recompress
> pass the higher prio_max value than the one zram allowed by somehow
> so we need to get the min value here", which is not true once review
> read code again/again and scratch head and then post patch to remove
> the unncessary line. I prefer reviewer happier.

I don't disagree. Let's drop it.