From: Andrew Lunn <andrew@lunn.ch>
To: Tim Harvey <tharvey@gateworks.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes
Date: Fri, 18 Nov 2022 01:27:11 +0100 [thread overview]
Message-ID: <Y3bRX1N0Rp7EDJkS@lunn.ch> (raw)
In-Reply-To: <20221118001548.635752-1-tharvey@gateworks.com>
On Thu, Nov 17, 2022 at 04:15:45PM -0800, Tim Harvey wrote:
> This series adds a dt-prop ti,led-modes to configure dp83867 PHY led
> modes, adds the code to implement it, and updates some board dt files
> to use the new property.
Sorry, but NACK.
We need PHY leds to be controlled via /sys/class/leds. Everybody keeps
trying to add there own way to configure these things, rather than
have just one uniform way which all PHYs share.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Tim Harvey <tharvey@gateworks.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes
Date: Fri, 18 Nov 2022 01:27:11 +0100 [thread overview]
Message-ID: <Y3bRX1N0Rp7EDJkS@lunn.ch> (raw)
In-Reply-To: <20221118001548.635752-1-tharvey@gateworks.com>
On Thu, Nov 17, 2022 at 04:15:45PM -0800, Tim Harvey wrote:
> This series adds a dt-prop ti,led-modes to configure dp83867 PHY led
> modes, adds the code to implement it, and updates some board dt files
> to use the new property.
Sorry, but NACK.
We need PHY leds to be controlled via /sys/class/leds. Everybody keeps
trying to add there own way to configure these things, rather than
have just one uniform way which all PHYs share.
Andrew
next prev parent reply other threads:[~2022-11-18 0:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 0:15 [PATCH 0/3] add dt configuration for dp83867 led modes Tim Harvey
2022-11-18 0:15 ` Tim Harvey
2022-11-18 0:15 ` [PATCH 1/3] dt-bindings: net: phy: dp83867: add LED mode property Tim Harvey
2022-11-18 0:15 ` Tim Harvey
2022-11-18 3:56 ` Rob Herring
2022-11-18 3:56 ` Rob Herring
2022-11-18 0:15 ` [PATCH 2/3] net: phy: dp83867: add LED mode configuration via dt Tim Harvey
2022-11-18 0:15 ` Tim Harvey
2022-11-18 0:15 ` [PATCH 3/3] arm64: dts: imx8m*-venice: add dp83867 PHY LED mode configuration Tim Harvey
2022-11-18 0:15 ` Tim Harvey
2022-11-18 0:27 ` Andrew Lunn [this message]
2022-11-18 0:27 ` [PATCH 0/3] add dt configuration for dp83867 led modes Andrew Lunn
2022-11-18 0:54 ` Tim Harvey
2022-11-18 0:54 ` Tim Harvey
2022-11-18 13:11 ` Andrew Lunn
2022-11-18 13:11 ` Andrew Lunn
2022-11-18 19:57 ` Tim Harvey
2022-11-18 19:57 ` Tim Harvey
2022-11-20 23:35 ` Andrew Lunn
2022-11-20 23:35 ` Andrew Lunn
2022-12-01 18:26 ` Tim Harvey
2022-12-01 18:26 ` Tim Harvey
2022-12-01 18:31 ` Christian Marangi
2022-12-01 18:31 ` Christian Marangi
2022-12-01 18:35 ` Tim Harvey
2022-12-01 18:35 ` Tim Harvey
2022-12-01 18:38 ` Christian Marangi
2022-12-01 18:38 ` Christian Marangi
2022-12-01 19:40 ` Andrew Lunn
2022-12-01 19:40 ` Andrew Lunn
2022-12-07 10:40 ` Alexander Stein
2022-12-07 10:40 ` Alexander Stein
2022-12-07 10:48 ` Rasmus Villemoes
2022-12-07 10:48 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3bRX1N0Rp7EDJkS@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.