[PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[Alicja Michalska]

KBL platform is missing the definition of 'max98357a' audio amplifier.
This amplifier is used on many KBL Chromebooks, for instance variant
'nami' of 'Google/poppy' baseboard.

Reported-by: CoolStar <coolstarorganization@gmail.com>
Signed-off-by: Alicja Michalska <ahplka19@gmail.com>

diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
index 87f9c18be238..650faebb33ef 100644
--- a/sound/soc/intel/avs/board_selection.c
+++ b/sound/soc/intel/avs/board_selection.c
@@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
 		},
 		.tplg_filename = "max98373-tplg.bin",
 	},
+	{
+		.id = "MX98357A",
+		.drv_name = "avs_max98357a",
+		.mach_params = {
+			.i2s_link_mask = AVS_SSP(0),
+		},
+		.tplg_filename = "max98357a-tplg.bin",
+	},
 	{
 		.id = "DLGS7219",
 		.drv_name = "avs_da7219",
---
 sound/soc/intel/avs/board_selection.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
index 87f9c18be238..650faebb33ef 100644
--- a/sound/soc/intel/avs/board_selection.c
+++ b/sound/soc/intel/avs/board_selection.c
@@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
 		},
 		.tplg_filename = "max98373-tplg.bin",
 	},
+	{
+		.id = "MX98357A",
+		.drv_name = "avs_max98357a",
+		.mach_params = {
+			.i2s_link_mask = AVS_SSP(0),
+		},
+		.tplg_filename = "max98357a-tplg.bin",
+	},
 	{
 		.id = "DLGS7219",
 		.drv_name = "avs_da7219",
-- 
2.38.1

Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[Curtis Malainey]

On Mon, Nov 21, 2022 at 3:20 PM Alicja Michalska <ahplka19@gmail.com> wrote:
>
> KBL platform is missing the definition of 'max98357a' audio amplifier.
> This amplifier is used on many KBL Chromebooks, for instance variant
> 'nami' of 'Google/poppy' baseboard.

Nami isn't a production device, it was a design, I think you mean "Nautilus"

>         },
> +       {
> +               .id = "MX98357A",
> +               .drv_name = "avs_max98357a",
> +               .mach_params = {
> +                       .i2s_link_mask = AVS_SSP(0),
> +               },
> +               .tplg_filename = "max98357a-tplg.bin",
> +       },

Cezary/Lukasz did we check nautilus? From what I can see in coreboot
it should need this.

Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[Cezary Rojewski]

On 2022-11-22 1:36 AM, Curtis Malainey wrote:
> On Mon, Nov 21, 2022 at 3:20 PM Alicja Michalska <ahplka19@gmail.com> wrote:
>>
>> KBL platform is missing the definition of 'max98357a' audio amplifier.
>> This amplifier is used on many KBL Chromebooks, for instance variant
>> 'nami' of 'Google/poppy' baseboard.
> 
> Nami isn't a production device, it was a design, I think you mean "Nautilus"
> 
>>          },
>> +       {
>> +               .id = "MX98357A",
>> +               .drv_name = "avs_max98357a",
>> +               .mach_params = {
>> +                       .i2s_link_mask = AVS_SSP(0),
>> +               },
>> +               .tplg_filename = "max98357a-tplg.bin",
>> +       },
> 
> Cezary/Lukasz did we check nautilus? From what I can see in coreboot
> it should need this.

A bit surprised this entry was not there to begin with.

We have checked several dozen of configurations but I admit, don't 
remember if this concrete one was. Max98357a was first launched with APL 
with the avs-driver, then we moved on to Chell and Lars. As I'm not 
aware of any differences, this should work out of the box with the entry 
appended.


Regards,
Czarek

Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[Cezary Rojewski]

On 2022-11-22 12:20 AM, Alicja Michalska wrote:
> KBL platform is missing the definition of 'max98357a' audio amplifier.
> This amplifier is used on many KBL Chromebooks, for instance variant
> 'nami' of 'Google/poppy' baseboard.
> 
> Reported-by: CoolStar <coolstarorganization@gmail.com>
> Signed-off-by: Alicja Michalska <ahplka19@gmail.com>
> 
> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
> index 87f9c18be238..650faebb33ef 100644
> --- a/sound/soc/intel/avs/board_selection.c
> +++ b/sound/soc/intel/avs/board_selection.c
> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
>   		},
>   		.tplg_filename = "max98373-tplg.bin",
>   	},
> +	{
> +		.id = "MX98357A",
> +		.drv_name = "avs_max98357a",
> +		.mach_params = {
> +			.i2s_link_mask = AVS_SSP(0),
> +		},
> +		.tplg_filename = "max98357a-tplg.bin",
> +	},
>   	{
>   		.id = "DLGS7219",
>   		.drv_name = "avs_da7219",
> ---
>   sound/soc/intel/avs/board_selection.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
> index 87f9c18be238..650faebb33ef 100644
> --- a/sound/soc/intel/avs/board_selection.c
> +++ b/sound/soc/intel/avs/board_selection.c
> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
>   		},
>   		.tplg_filename = "max98373-tplg.bin",
>   	},
> +	{
> +		.id = "MX98357A",
> +		.drv_name = "avs_max98357a",
> +		.mach_params = {
> +			.i2s_link_mask = AVS_SSP(0),
> +		},
> +		.tplg_filename = "max98357a-tplg.bin",
> +	},
>   	{
>   		.id = "DLGS7219",
>   		.drv_name = "avs_da7219",


Any reason why diff is repeated twice? It seems that the first copy of 
diff is part of the commit message.

Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[Alicja Michalska]

Hello Czarek, trying to re-send that mail from my workstation since 
email client on my phone didn't cc properly.

No, I've got no idea why it's been duplicated. It's my first time 
contributing to mainline, so sorry about that. Will double-check my 
patches in the future.

On 22/11/2022 19:10, Cezary Rojewski wrote:
 > On 2022-11-22 12:20 AM, Alicja Michalska wrote:
 >> KBL platform is missing the definition of 'max98357a' audio amplifier.
 >> This amplifier is used on many KBL Chromebooks, for instance variant
 >> 'nami' of 'Google/poppy' baseboard.
 >>
 >> Reported-by: CoolStar <coolstarorganization@gmail.com>
 >> Signed-off-by: Alicja Michalska <ahplka19@gmail.com>
 >>
 >> diff --git a/sound/soc/intel/avs/board_selection.c 
b/sound/soc/intel/avs/board_selection.c
 >> index 87f9c18be238..650faebb33ef 100644
 >> --- a/sound/soc/intel/avs/board_selection.c
 >> +++ b/sound/soc/intel/avs/board_selection.c
 >> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach 
avs_kbl_i2s_machines[] = {
 >>           },
 >>           .tplg_filename = "max98373-tplg.bin",
 >>       },
 >> +    {
 >> +        .id = "MX98357A",
 >> +        .drv_name = "avs_max98357a",
 >> +        .mach_params = {
 >> +            .i2s_link_mask = AVS_SSP(0),
 >> +        },
 >> +        .tplg_filename = "max98357a-tplg.bin",
 >> +    },
 >>       {
 >>           .id = "DLGS7219",
 >>           .drv_name = "avs_da7219",
 >> ---
 >>   sound/soc/intel/avs/board_selection.c | 8 ++++++++
 >>   1 file changed, 8 insertions(+)
 >>
 >> diff --git a/sound/soc/intel/avs/board_selection.c 
b/sound/soc/intel/avs/board_selection.c
 >> index 87f9c18be238..650faebb33ef 100644
 >> --- a/sound/soc/intel/avs/board_selection.c
 >> +++ b/sound/soc/intel/avs/board_selection.c
 >> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach 
avs_kbl_i2s_machines[] = {
 >>           },
 >>           .tplg_filename = "max98373-tplg.bin",
 >>       },
 >> +    {
 >> +        .id = "MX98357A",
 >> +        .drv_name = "avs_max98357a",
 >> +        .mach_params = {
 >> +            .i2s_link_mask = AVS_SSP(0),
 >> +        },
 >> +        .tplg_filename = "max98357a-tplg.bin",
 >> +    },
 >>       {
 >>           .id = "DLGS7219",
 >>           .drv_name = "avs_da7219",
 >
 >
 > Any reason why diff is repeated twice? It seems that the first copy 
of diff is part of the commit message.

Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[Mark Brown]

On Tue, 22 Nov 2022 00:20:40 +0100, Alicja Michalska wrote:
> KBL platform is missing the definition of 'max98357a' audio amplifier.
> This amplifier is used on many KBL Chromebooks, for instance variant
> 'nami' of 'Google/poppy' baseboard.
> 
> Reported-by: CoolStar <coolstarorganization@gmail.com>
> Signed-off-by: Alicja Michalska <ahplka19@gmail.com>
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: avs: Add missing audio amplifier for KBL
      commit: 0848e94c3954051e1a52bb088240ed63758b309b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark