From: Al Viro <viro@zeniv.linux.org.uk>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: axboe@kernel.dk, naohiro.aota@wdc.com, gost.dev@samsung.com,
kch@nvidia.com, sagi@grimberg.me, joshi.k@samsung.com,
linux-kernel@vger.kernel.org, anuj20.g@samsung.com,
snitzer@kernel.org, james.smart@broadcom.com,
linux-nvme@lists.infradead.org, hch@lst.de,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
dm-devel@redhat.com, nitheshshetty@gmail.com, kbusch@kernel.org,
jth@kernel.org, Nitesh Shetty <nj.shetty@samsung.com>,
agk@redhat.com, p.raghav@samsung.com
Subject: Re: [dm-devel] [PATCH v5 10/10] fs: add support for copy file range in zonefs
Date: Fri, 25 Nov 2022 04:18:16 +0000 [thread overview]
Message-ID: <Y4BCCB9U10mkiehu@ZenIV> (raw)
In-Reply-To: <349a4d66-3a9f-a095-005c-1f180c5f3aac@opensource.wdc.com>
On Thu, Nov 24, 2022 at 10:47:55AM +0900, Damien Le Moal wrote:
> >> + inode_lock(src_inode);
> >> + inode_lock(dst_inode);
> >
> > So you did zonefs_copy_file_checks() outside of these locks, which mean
> > that everything about the source and destination files may have changed.
> > This does not work.
>
> I forgot to mention that locking 2 inodes blindly like this can leads to
> deadlocks if another process tries a copy range from dst to src at the
> same time (lock order is reversed and so can deadlock).
Not to mention the deadlocks with existing places where fs/namei.c locks
two inodes...
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Nitesh Shetty <nj.shetty@samsung.com>,
axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
dm-devel@redhat.com, kbusch@kernel.org, hch@lst.de,
sagi@grimberg.me, james.smart@broadcom.com, kch@nvidia.com,
naohiro.aota@wdc.com, jth@kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
anuj20.g@samsung.com, joshi.k@samsung.com, p.raghav@samsung.com,
nitheshshetty@gmail.com, gost.dev@samsung.com
Subject: Re: [PATCH v5 10/10] fs: add support for copy file range in zonefs
Date: Fri, 25 Nov 2022 04:18:16 +0000 [thread overview]
Message-ID: <Y4BCCB9U10mkiehu@ZenIV> (raw)
In-Reply-To: <349a4d66-3a9f-a095-005c-1f180c5f3aac@opensource.wdc.com>
On Thu, Nov 24, 2022 at 10:47:55AM +0900, Damien Le Moal wrote:
> >> + inode_lock(src_inode);
> >> + inode_lock(dst_inode);
> >
> > So you did zonefs_copy_file_checks() outside of these locks, which mean
> > that everything about the source and destination files may have changed.
> > This does not work.
>
> I forgot to mention that locking 2 inodes blindly like this can leads to
> deadlocks if another process tries a copy range from dst to src at the
> same time (lock order is reversed and so can deadlock).
Not to mention the deadlocks with existing places where fs/namei.c locks
two inodes...
next prev parent reply other threads:[~2022-11-25 4:37 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221123061010epcas5p21cef9d23e4362b01f2b19d1117e1cdf5@epcas5p2.samsung.com>
2022-11-23 5:58 ` [dm-devel] [PATCH v5 00/10] Implement copy offload support Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 01/10] block: Introduce queue limits for copy-offload support Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 02/10] block: Add copy offload support infrastructure Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 8:04 ` [dm-devel] " Ming Lei
2022-11-23 8:04 ` Ming Lei
2022-11-23 10:07 ` [dm-devel] " Nitesh Shetty
2022-11-23 10:07 ` Nitesh Shetty
2022-11-24 0:03 ` [dm-devel] " Ming Lei
2022-11-24 0:03 ` Ming Lei
2022-11-29 11:44 ` [dm-devel] " Nitesh Shetty
2022-11-29 11:44 ` Nitesh Shetty
2022-12-07 5:54 ` [dm-devel] " Nitesh Shetty
2022-12-07 5:54 ` Nitesh Shetty
2022-12-07 11:19 ` [dm-devel] " Ming Lei
2022-12-07 11:19 ` Ming Lei
2022-12-09 8:16 ` [dm-devel] " Nitesh Shetty
2022-12-09 8:16 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 03/10] block: add emulation for copy Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 04/10] block: Introduce a new ioctl " Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 05/10] nvme: add copy offload support Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 06/10] nvmet: add copy command support for bdev and file ns Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 8:17 ` [dm-devel] " Guixin Liu
2022-11-23 9:39 ` Nitesh Shetty
2022-11-23 9:39 ` Nitesh Shetty
2022-12-06 9:22 ` [dm-devel] " kernel test robot
2022-12-06 9:22 ` kernel test robot
2022-11-23 5:58 ` [dm-devel] [PATCH v5 07/10] dm: Add support for copy offload Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 08/10] dm: Enable copy offload for dm-linear target Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 09/10] dm kcopyd: use copy offload support Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 5:58 ` [dm-devel] [PATCH v5 10/10] fs: add support for copy file range in zonefs Nitesh Shetty
2022-11-23 5:58 ` Nitesh Shetty
2022-11-23 6:53 ` [dm-devel] " Amir Goldstein
2022-11-23 6:53 ` Amir Goldstein
2022-11-23 10:13 ` [dm-devel] " Nitesh Shetty
2022-11-23 10:13 ` Nitesh Shetty
2022-11-24 1:32 ` [dm-devel] " Damien Le Moal
2022-11-24 1:32 ` Damien Le Moal
2022-11-24 1:47 ` [dm-devel] " Damien Le Moal
2022-11-24 1:47 ` Damien Le Moal
2022-11-25 4:18 ` Al Viro [this message]
2022-11-25 4:18 ` Al Viro
2022-11-29 12:22 ` [dm-devel] " Nitesh Shetty
2022-11-29 12:22 ` Nitesh Shetty
2022-11-29 23:45 ` [dm-devel] " Damien Le Moal
2022-11-29 23:45 ` Damien Le Moal
2022-11-30 4:17 ` [dm-devel] " Nitesh Shetty
2022-11-30 4:17 ` Nitesh Shetty
2022-11-30 9:55 ` [dm-devel] " Damien Le Moal
2022-11-30 9:55 ` Damien Le Moal
2022-11-23 22:56 ` [dm-devel] [PATCH v5 00/10] Implement copy offload support Chaitanya Kulkarni
2022-11-23 22:56 ` Chaitanya Kulkarni
2022-11-29 12:16 ` [dm-devel] " Nitesh Shetty
2022-11-29 12:16 ` Nitesh Shetty
2022-11-30 0:05 ` [dm-devel] " Chaitanya Kulkarni
2022-11-30 0:05 ` Chaitanya Kulkarni
2022-11-30 4:14 ` [dm-devel] " Nitesh Shetty
2022-11-30 4:14 ` Nitesh Shetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4BCCB9U10mkiehu@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=agk@redhat.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=joshi.k@samsung.com \
--cc=jth@kernel.org \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=naohiro.aota@wdc.com \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
--cc=p.raghav@samsung.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.