From: Daniel Thompson <daniel.thompson@linaro.org>
To: ye.xingchen@zte.com.cn
Cc: lee@kernel.org, jingoohan1@gmail.com, deller@gmx.de,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()
Date: Fri, 9 Dec 2022 12:51:28 +0000 [thread overview]
Message-ID: <Y5MvULWEnqp7pzft@aspen.lan> (raw)
In-Reply-To: <202212051556478226726@zte.com.cn>
On Mon, Dec 05, 2022 at 03:56:47PM +0800, ye.xingchen@zte.com.cn wrote:
> Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of
> scnprintf()
Isn't this a v2?
(this isn't just a "nice to have"... I ended up delaying review for
several days until I had time to look up where I had seen these changes
before)
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: ye.xingchen@zte.com.cn
Cc: linux-fbdev@vger.kernel.org, jingoohan1@gmail.com, deller@gmx.de,
lee@kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()
Date: Fri, 9 Dec 2022 12:51:28 +0000 [thread overview]
Message-ID: <Y5MvULWEnqp7pzft@aspen.lan> (raw)
In-Reply-To: <202212051556478226726@zte.com.cn>
On Mon, Dec 05, 2022 at 03:56:47PM +0800, ye.xingchen@zte.com.cn wrote:
> Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of
> scnprintf()
Isn't this a v2?
(this isn't just a "nice to have"... I ended up delaying review for
several days until I had time to look up where I had seen these changes
before)
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
next prev parent reply other threads:[~2022-12-09 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 7:56 [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf() ye.xingchen
2022-12-05 7:56 ` ye.xingchen
2022-12-09 12:51 ` Daniel Thompson [this message]
2022-12-09 12:51 ` Daniel Thompson
2023-01-04 16:21 ` Lee Jones
2023-01-04 16:21 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2022-09-23 6:34 cgel.zte
2022-09-23 21:04 ` Han Jingoo
2022-09-23 21:04 ` Han Jingoo
2022-09-26 13:26 ` Daniel Thompson
2022-09-26 13:26 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5MvULWEnqp7pzft@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.