From: Daniel Thompson <daniel.thompson@linaro.org>
To: cgel.zte@gmail.com
Cc: lee@kernel.org, jingoohan1@gmail.com, deller@gmx.de,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
ye xingchen <ye.xingchen@zte.com.cn>
Subject: Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()
Date: Mon, 26 Sep 2022 14:26:07 +0100 [thread overview]
Message-ID: <YzGob83cBFfuxOXQ@maple.lan> (raw)
In-Reply-To: <20220923063448.239259-1-ye.xingchen@zte.com.cn>
On Fri, Sep 23, 2022 at 06:34:48AM +0000, cgel.zte@gmail.com wrote:
> Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of
> scnprintf()
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/video/backlight/lm3533_bl.c | 10 +++++-----
Looks like a good change but the topic tag ('backlight:') looks a bit
generic for something that only impacts the lm3533_bl.c driver.
Also it would be good if this patchset included the same fix
for *all* drivers that a grep shows contain this code pattern
(e.g. git grep 'return scnprintf.*PAGE_SIZE').
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: cgel.zte@gmail.com
Cc: linux-fbdev@vger.kernel.org, jingoohan1@gmail.com, deller@gmx.de,
lee@kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
ye xingchen <ye.xingchen@zte.com.cn>
Subject: Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf()
Date: Mon, 26 Sep 2022 14:26:07 +0100 [thread overview]
Message-ID: <YzGob83cBFfuxOXQ@maple.lan> (raw)
In-Reply-To: <20220923063448.239259-1-ye.xingchen@zte.com.cn>
On Fri, Sep 23, 2022 at 06:34:48AM +0000, cgel.zte@gmail.com wrote:
> Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of
> scnprintf()
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/video/backlight/lm3533_bl.c | 10 +++++-----
Looks like a good change but the topic tag ('backlight:') looks a bit
generic for something that only impacts the lm3533_bl.c driver.
Also it would be good if this patchset included the same fix
for *all* drivers that a grep shows contain this code pattern
(e.g. git grep 'return scnprintf.*PAGE_SIZE').
Daniel.
next prev parent reply other threads:[~2022-09-26 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 6:34 [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf() cgel.zte
2022-09-23 21:04 ` Han Jingoo
2022-09-23 21:04 ` Han Jingoo
2022-09-26 13:26 ` Daniel Thompson [this message]
2022-09-26 13:26 ` Daniel Thompson
-- strict thread matches above, loose matches on Subject: below --
2022-12-05 7:56 ye.xingchen
2022-12-05 7:56 ` ye.xingchen
2022-12-09 12:51 ` Daniel Thompson
2022-12-09 12:51 ` Daniel Thompson
2023-01-04 16:21 ` Lee Jones
2023-01-04 16:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzGob83cBFfuxOXQ@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=cgel.zte@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.