All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: Dave Hansen <dave.hansen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Kristen Carlson Accardi
	<kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Jarkko Sakkinen <jarkko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sgx-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	zhiquan1.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v2 14/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC
Date: Mon, 12 Dec 2022 18:09:39 +0000	[thread overview]
Message-ID: <Y5duYxIHtSpK1qkj@google.com> (raw)
In-Reply-To: <e5aff02b-713c-ccd8-7211-d07ff6d7adb2-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Fri, Dec 09, 2022, Dave Hansen wrote:
> On 12/9/22 08:05, Kristen Carlson Accardi wrote:
> > Aside from that though, I don't think that killing enclaves makes sense
> > outside the context of cgroup limits. 
> 
> I think it makes a lot of sense in theory.  Whatever situation we get
> into with a cgroup's EPC we can also get into with the whole system's EPC.
> 
> *But*, it's orders of magnitude harder to hit on the whole system.

...

> If someone wants to extend this OOM support to system-wide EPC later, then go
> ahead.  But, I don't think it makes a lot of sense to invert this series for
> it.

+1 from the peanut gallery.  With VMM EPC oversubscription suport, no sane VMM
will oversubscribe VEPC pages.  And for VA pages, supporting swap of VA pages is
likely a more userspace-friendly approach if system-wide EPC OOM is a concern.

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Kristen Carlson Accardi <kristen@linux.intel.com>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	dave.hansen@linux.intel.com, tj@kernel.org,
	linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org,
	cgroups@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	zhiquan1.li@intel.com
Subject: Re: [PATCH v2 14/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC
Date: Mon, 12 Dec 2022 18:09:39 +0000	[thread overview]
Message-ID: <Y5duYxIHtSpK1qkj@google.com> (raw)
In-Reply-To: <e5aff02b-713c-ccd8-7211-d07ff6d7adb2@intel.com>

On Fri, Dec 09, 2022, Dave Hansen wrote:
> On 12/9/22 08:05, Kristen Carlson Accardi wrote:
> > Aside from that though, I don't think that killing enclaves makes sense
> > outside the context of cgroup limits. 
> 
> I think it makes a lot of sense in theory.  Whatever situation we get
> into with a cgroup's EPC we can also get into with the whole system's EPC.
> 
> *But*, it's orders of magnitude harder to hit on the whole system.

...

> If someone wants to extend this OOM support to system-wide EPC later, then go
> ahead.  But, I don't think it makes a lot of sense to invert this series for
> it.

+1 from the peanut gallery.  With VMM EPC oversubscription suport, no sane VMM
will oversubscribe VEPC pages.  And for VA pages, supporting swap of VA pages is
likely a more userspace-friendly approach if system-wide EPC OOM is a concern.

  parent reply	other threads:[~2022-12-12 18:09 UTC|newest]

Thread overview: 127+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 18:36 [PATCH v2 00/18] Add Cgroup support for SGX EPC memory Kristen Carlson Accardi
2022-12-02 18:36 ` Kristen Carlson Accardi
     [not found] ` <20221202183655.3767674-1-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 18:36   ` [PATCH v2 01/18] x86/sgx: Call cond_resched() at the end of sgx_reclaim_pages() Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-2-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 21:33       ` Dave Hansen
2022-12-02 21:33         ` Dave Hansen
     [not found]         ` <37de083d-a63b-b2ff-d00a-e890a1ba5eea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-02 21:37           ` Kristen Carlson Accardi
2022-12-02 21:37             ` Kristen Carlson Accardi
     [not found]             ` <da690a45a36038399c63ddac8f0efed9872ec13e.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 21:45               ` Dave Hansen
2022-12-02 21:45                 ` Dave Hansen
     [not found]                 ` <746adf31-e70c-e32d-a35d-72d352af613b-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-02 22:17                   ` Kristen Carlson Accardi
2022-12-02 22:17                     ` Kristen Carlson Accardi
     [not found]                     ` <307b43aa5908c489913110287044e611f574db0a.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 22:37                       ` Dave Hansen
2022-12-02 22:37                         ` Dave Hansen
2022-12-02 18:36   ` [PATCH v2 02/18] x86/sgx: Store struct sgx_encl when allocating new VA pages Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-3-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 21:35       ` Dave Hansen
2022-12-02 21:35         ` Dave Hansen
     [not found]         ` <3a789b1c-4c70-158b-d764-daec141a5816-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-02 21:40           ` Kristen Carlson Accardi
2022-12-02 21:40             ` Kristen Carlson Accardi
     [not found]             ` <abfc00a2ab1d97f8081c696f78e2d0ced23902b4.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 21:48               ` Dave Hansen
2022-12-02 21:48                 ` Dave Hansen
     [not found]                 ` <2015ae96-5459-1f82-596b-f46af08ef766-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-02 22:35                   ` Sean Christopherson
2022-12-02 22:35                     ` Sean Christopherson
     [not found]                     ` <Y4p9nKV+jpLnOVwD-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-12-02 22:47                       ` Dave Hansen
2022-12-02 22:47                         ` Dave Hansen
     [not found]                         ` <8b7f6993-2135-a9f9-63c5-c9c6112ef676-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-02 22:49                           ` Sean Christopherson
2022-12-02 22:49                             ` Sean Christopherson
2022-12-02 18:36   ` [PATCH v2 03/18] x86/sgx: Add 'struct sgx_epc_lru_lists' to encapsulate lru list(s) Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-4-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 21:39       ` Dave Hansen
2022-12-02 21:39         ` Dave Hansen
2022-12-08 15:31       ` Jarkko Sakkinen
2022-12-08 15:31         ` Jarkko Sakkinen
     [not found]         ` <Y5IDXF+6GmURxbYF-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2022-12-08 18:03           ` Kristen Carlson Accardi
2022-12-08 18:03             ` Kristen Carlson Accardi
2022-12-02 18:36   ` [PATCH v2 04/18] x86/sgx: Use sgx_epc_lru_lists for existing active page list Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-5-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 21:43       ` Dave Hansen
2022-12-02 21:43         ` Dave Hansen
     [not found]         ` <ad1bcb0f-661d-a701-2175-c8750d8af8d8-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-02 21:51           ` Kristen Carlson Accardi
2022-12-02 21:51             ` Kristen Carlson Accardi
     [not found]             ` <d17c270bcbf631736d52b762dad8a6758d7dc951.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 22:10               ` Dave Hansen
2022-12-02 22:10                 ` Dave Hansen
2022-12-02 18:36   ` [PATCH v2 05/18] x86/sgx: Track epc pages on reclaimable or unreclaimable lists Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-6-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 22:13       ` Dave Hansen
2022-12-02 22:13         ` Dave Hansen
     [not found]         ` <1dccd2ec-cad8-b9d2-d66b-aebad21cdb44-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-02 22:28           ` Sean Christopherson
2022-12-02 22:28             ` Sean Christopherson
2022-12-02 18:36   ` [PATCH v2 06/18] x86/sgx: Introduce RECLAIM_IN_PROGRESS flag for EPC pages Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-7-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 22:15       ` Dave Hansen
2022-12-02 22:15         ` Dave Hansen
2022-12-08 15:46       ` Jarkko Sakkinen
2022-12-08 15:46         ` Jarkko Sakkinen
     [not found]         ` <Y5IGzbNxOBkRoaRx-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2022-12-08 18:13           ` Kristen Carlson Accardi
2022-12-08 18:13             ` Kristen Carlson Accardi
2022-12-02 18:36   ` [PATCH v2 07/18] x86/sgx: Use a list to track to-be-reclaimed pages during reclaim Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-8-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-02 22:33       ` Dave Hansen
2022-12-02 22:33         ` Dave Hansen
     [not found]         ` <0646275c-0ab9-2fad-8db1-7098656d6e1d-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-05 16:33           ` Kristen Carlson Accardi
2022-12-05 16:33             ` Kristen Carlson Accardi
     [not found]             ` <931e48dc399eddf8ad9f9dec8783f57df776daa9.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-05 17:03               ` Dave Hansen
2022-12-05 17:03                 ` Dave Hansen
     [not found]                 ` <6668e428-8e4a-0a44-d77c-a540c04d72ed-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-05 18:25                   ` Kristen Carlson Accardi
2022-12-05 18:25                     ` Kristen Carlson Accardi
2022-12-02 18:36   ` [PATCH v2 08/18] x86/sgx: Allow reclaiming up to 32 pages, but scan 16 by default Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-9-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08  9:26       ` Jarkko Sakkinen
2022-12-08  9:26         ` Jarkko Sakkinen
     [not found]         ` <Y5GtyM92jE5/UJT3-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2022-12-08  9:27           ` Jarkko Sakkinen
2022-12-08  9:27             ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 09/18] x86/sgx: Return the number of EPC pages that were successfully reclaimed Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-10-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08  9:30       ` Jarkko Sakkinen
2022-12-08  9:30         ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 10/18] x86/sgx: Add option to ignore age of page during EPC reclaim Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-11-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08  9:37       ` Jarkko Sakkinen
2022-12-08  9:37         ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 11/18] x86/sgx: Prepare for multiple LRUs Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-12-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08  9:42       ` Jarkko Sakkinen
2022-12-08  9:42         ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 12/18] x86/sgx: Expose sgx_reclaim_pages() for use by EPC cgroup Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-13-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08  9:46       ` Jarkko Sakkinen
2022-12-08  9:46         ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 13/18] x86/sgx: Add helper to grab pages from an arbitrary EPC LRU Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
2022-12-08  9:56     ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 14/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-15-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08 15:21       ` Jarkko Sakkinen
2022-12-08 15:21         ` Jarkko Sakkinen
     [not found]         ` <Y5IBCOuF8X7jEK3+-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2022-12-09 16:05           ` Kristen Carlson Accardi
2022-12-09 16:05             ` Kristen Carlson Accardi
     [not found]             ` <cb5abce531c1b14118de419ba68c2a501b016873.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-09 16:22               ` Dave Hansen
2022-12-09 16:22                 ` Dave Hansen
     [not found]                 ` <e5aff02b-713c-ccd8-7211-d07ff6d7adb2-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-12-12 18:09                   ` Sean Christopherson [this message]
2022-12-12 18:09                     ` Sean Christopherson
     [not found]                     ` <Y5duYxIHtSpK1qkj-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-12-26 20:43                       ` Jarkko Sakkinen
2022-12-26 20:43                         ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 15/18] cgroup/misc: Add per resource callbacks for css events Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-16-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08 14:53       ` Jarkko Sakkinen
2022-12-08 14:53         ` Jarkko Sakkinen
     [not found]         ` <Y5H6ZLz7HXSaTF30-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2022-12-08 15:15           ` Jarkko Sakkinen
2022-12-08 15:15             ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 16/18] cgroup/misc: Prepare for SGX usage Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-17-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08 15:23       ` Jarkko Sakkinen
2022-12-08 15:23         ` Jarkko Sakkinen
2022-12-02 18:36   ` [PATCH v2 17/18] x86/sgx: Add support for misc cgroup controller Kristen Carlson Accardi
2022-12-02 18:36     ` Kristen Carlson Accardi
     [not found]     ` <20221202183655.3767674-18-kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2022-12-08 15:30       ` Jarkko Sakkinen
2022-12-08 15:30         ` Jarkko Sakkinen
2023-04-03 21:26   ` [EXTERNAL] [PATCH v2 00/18] Add Cgroup support for SGX EPC memory Anand Krishnamoorthi
2023-04-03 21:26     ` Anand Krishnamoorthi
     [not found]     ` <DM6PR21MB11778ABA54CD33A5822D5B24C4929-3jJ4emchXQBypjffeKSS3s1VXTxX1y3OvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-04-13 18:49       ` Anand Krishnamoorthi
2023-04-13 18:49         ` Anand Krishnamoorthi
2023-04-18 16:44         ` Mikko Ylinen
2023-04-27 16:53           ` Anand Krishnamoorthi
2023-04-27 16:53             ` Anand Krishnamoorthi
2022-12-02 18:36 ` [PATCH v2 18/18] Docs/x86/sgx: Add description for cgroup support Kristen Carlson Accardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5duYxIHtSpK1qkj@google.com \
    --to=seanjc-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
    --cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=dave.hansen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=jarkko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sgx-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=zhiquan1.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.