All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-13 12:21 ` Jiasheng Jiang
  0 siblings, 0 replies; 16+ messages in thread
From: Jiasheng Jiang @ 2022-12-13 12:21 UTC (permalink / raw)
  To: linux-aspeed

Add the check for the return value of dma_alloc_coherent
in order to avoid NULL pointer dereference.

Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add "goto err;" when allocation fails.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
 					  AST_UDC_EP_DMA_SIZE *
 					  AST_UDC_NUM_ENDPOINTS,
 					  &udc->ep0_buf_dma, GFP_KERNEL);
+	if (!udc->ep0_buf) {
+		rc = -ENOMEM;
+		goto err;
+	}
 
 	udc->gadget.speed = USB_SPEED_UNKNOWN;
 	udc->gadget.max_speed = USB_SPEED_HIGH;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-13 12:21 ` Jiasheng Jiang
  0 siblings, 0 replies; 16+ messages in thread
From: Jiasheng Jiang @ 2022-12-13 12:21 UTC (permalink / raw)
  To: gregkh
  Cc: neal_liu, joel, andrew, sumit.semwal, christian.koenig,
	linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
	linux-media, dri-devel, linaro-mm-sig, Jiasheng Jiang

Add the check for the return value of dma_alloc_coherent
in order to avoid NULL pointer dereference.

Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add "goto err;" when allocation fails.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
 					  AST_UDC_EP_DMA_SIZE *
 					  AST_UDC_NUM_ENDPOINTS,
 					  &udc->ep0_buf_dma, GFP_KERNEL);
+	if (!udc->ep0_buf) {
+		rc = -ENOMEM;
+		goto err;
+	}
 
 	udc->gadget.speed = USB_SPEED_UNKNOWN;
 	udc->gadget.max_speed = USB_SPEED_HIGH;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-13 12:21 ` Jiasheng Jiang
  0 siblings, 0 replies; 16+ messages in thread
From: Jiasheng Jiang @ 2022-12-13 12:21 UTC (permalink / raw)
  To: gregkh
  Cc: neal_liu, joel, andrew, sumit.semwal, christian.koenig,
	linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
	linux-media, dri-devel, linaro-mm-sig, Jiasheng Jiang

Add the check for the return value of dma_alloc_coherent
in order to avoid NULL pointer dereference.

Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add "goto err;" when allocation fails.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
 					  AST_UDC_EP_DMA_SIZE *
 					  AST_UDC_NUM_ENDPOINTS,
 					  &udc->ep0_buf_dma, GFP_KERNEL);
+	if (!udc->ep0_buf) {
+		rc = -ENOMEM;
+		goto err;
+	}
 
 	udc->gadget.speed = USB_SPEED_UNKNOWN;
 	udc->gadget.max_speed = USB_SPEED_HIGH;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-13 12:21 ` Jiasheng Jiang
  0 siblings, 0 replies; 16+ messages in thread
From: Jiasheng Jiang @ 2022-12-13 12:21 UTC (permalink / raw)
  To: gregkh
  Cc: Jiasheng Jiang, linux-aspeed, andrew, neal_liu, linux-usb,
	linux-kernel, dri-devel, sumit.semwal, linaro-mm-sig, joel,
	christian.koenig, linux-arm-kernel, linux-media

Add the check for the return value of dma_alloc_coherent
in order to avoid NULL pointer dereference.

Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add "goto err;" when allocation fails.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
 					  AST_UDC_EP_DMA_SIZE *
 					  AST_UDC_NUM_ENDPOINTS,
 					  &udc->ep0_buf_dma, GFP_KERNEL);
+	if (!udc->ep0_buf) {
+		rc = -ENOMEM;
+		goto err;
+	}
 
 	udc->gadget.speed = USB_SPEED_UNKNOWN;
 	udc->gadget.max_speed = USB_SPEED_HIGH;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
  2022-12-13 12:21 ` Jiasheng Jiang
  (?)
  (?)
@ 2022-12-13 14:32   ` Greg KH
  -1 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2022-12-13 14:32 UTC (permalink / raw)
  To: linux-aspeed

On Tue, Dec 13, 2022 at 08:21:16PM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent
> in order to avoid NULL pointer dereference.
> 
> Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Again, please prove that you tested this and follow the requirements at:
	Documentation/process/researcher-guidelines.rst
in order for us to be able to accept your changes.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-13 14:32   ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2022-12-13 14:32 UTC (permalink / raw)
  To: Jiasheng Jiang
  Cc: neal_liu, joel, andrew, sumit.semwal, christian.koenig,
	linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
	linux-media, dri-devel, linaro-mm-sig

On Tue, Dec 13, 2022 at 08:21:16PM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent
> in order to avoid NULL pointer dereference.
> 
> Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Again, please prove that you tested this and follow the requirements at:
	Documentation/process/researcher-guidelines.rst
in order for us to be able to accept your changes.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-13 14:32   ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2022-12-13 14:32 UTC (permalink / raw)
  To: Jiasheng Jiang
  Cc: neal_liu, joel, andrew, sumit.semwal, christian.koenig,
	linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
	linux-media, dri-devel, linaro-mm-sig

On Tue, Dec 13, 2022 at 08:21:16PM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent
> in order to avoid NULL pointer dereference.
> 
> Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Again, please prove that you tested this and follow the requirements at:
	Documentation/process/researcher-guidelines.rst
in order for us to be able to accept your changes.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-13 14:32   ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2022-12-13 14:32 UTC (permalink / raw)
  To: Jiasheng Jiang
  Cc: linux-aspeed, andrew, neal_liu, linux-usb, linux-kernel,
	dri-devel, sumit.semwal, linaro-mm-sig, joel, christian.koenig,
	linux-arm-kernel, linux-media

On Tue, Dec 13, 2022 at 08:21:16PM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent
> in order to avoid NULL pointer dereference.
> 
> Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Again, please prove that you tested this and follow the requirements at:
	Documentation/process/researcher-guidelines.rst
in order for us to be able to accept your changes.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-14  2:54 ` Jiasheng Jiang
  0 siblings, 0 replies; 16+ messages in thread
From: Jiasheng Jiang @ 2022-12-14  2:54 UTC (permalink / raw)
  To: linux-aspeed

Add the check for the return value of dma_alloc_coherent in order to
avoid NULL pointer dereference.

This flaw was found using an experimental static analysis tool we are
developing, APP-Miner, which has not been disclosed.

The allyesconfig build using GCC 9.3.0 shows no new warning. As we
don't have a UDC device to test with, no runtime testing was able to
be performed.

Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add "goto err;" when allocation fails.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
 					  AST_UDC_EP_DMA_SIZE *
 					  AST_UDC_NUM_ENDPOINTS,
 					  &udc->ep0_buf_dma, GFP_KERNEL);
+	if (!udc->ep0_buf) {
+		rc = -ENOMEM;
+		goto err;
+	}
 
 	udc->gadget.speed = USB_SPEED_UNKNOWN;
 	udc->gadget.max_speed = USB_SPEED_HIGH;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-14  2:54 ` Jiasheng Jiang
  0 siblings, 0 replies; 16+ messages in thread
From: Jiasheng Jiang @ 2022-12-14  2:54 UTC (permalink / raw)
  To: gregkh
  Cc: neal_liu, joel, andrew, sumit.semwal, christian.koenig,
	linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
	linux-media, dri-devel, linaro-mm-sig, Jiasheng Jiang

Add the check for the return value of dma_alloc_coherent in order to
avoid NULL pointer dereference.

This flaw was found using an experimental static analysis tool we are
developing, APP-Miner, which has not been disclosed.

The allyesconfig build using GCC 9.3.0 shows no new warning. As we
don't have a UDC device to test with, no runtime testing was able to
be performed.

Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add "goto err;" when allocation fails.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
 					  AST_UDC_EP_DMA_SIZE *
 					  AST_UDC_NUM_ENDPOINTS,
 					  &udc->ep0_buf_dma, GFP_KERNEL);
+	if (!udc->ep0_buf) {
+		rc = -ENOMEM;
+		goto err;
+	}
 
 	udc->gadget.speed = USB_SPEED_UNKNOWN;
 	udc->gadget.max_speed = USB_SPEED_HIGH;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-14  2:54 ` Jiasheng Jiang
  0 siblings, 0 replies; 16+ messages in thread
From: Jiasheng Jiang @ 2022-12-14  2:54 UTC (permalink / raw)
  To: gregkh
  Cc: neal_liu, joel, andrew, sumit.semwal, christian.koenig,
	linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
	linux-media, dri-devel, linaro-mm-sig, Jiasheng Jiang

Add the check for the return value of dma_alloc_coherent in order to
avoid NULL pointer dereference.

This flaw was found using an experimental static analysis tool we are
developing, APP-Miner, which has not been disclosed.

The allyesconfig build using GCC 9.3.0 shows no new warning. As we
don't have a UDC device to test with, no runtime testing was able to
be performed.

Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add "goto err;" when allocation fails.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
 					  AST_UDC_EP_DMA_SIZE *
 					  AST_UDC_NUM_ENDPOINTS,
 					  &udc->ep0_buf_dma, GFP_KERNEL);
+	if (!udc->ep0_buf) {
+		rc = -ENOMEM;
+		goto err;
+	}
 
 	udc->gadget.speed = USB_SPEED_UNKNOWN;
 	udc->gadget.max_speed = USB_SPEED_HIGH;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-14  2:54 ` Jiasheng Jiang
  0 siblings, 0 replies; 16+ messages in thread
From: Jiasheng Jiang @ 2022-12-14  2:54 UTC (permalink / raw)
  To: gregkh
  Cc: Jiasheng Jiang, linux-aspeed, andrew, neal_liu, linux-usb,
	linux-kernel, dri-devel, sumit.semwal, linaro-mm-sig, joel,
	christian.koenig, linux-arm-kernel, linux-media

Add the check for the return value of dma_alloc_coherent in order to
avoid NULL pointer dereference.

This flaw was found using an experimental static analysis tool we are
developing, APP-Miner, which has not been disclosed.

The allyesconfig build using GCC 9.3.0 shows no new warning. As we
don't have a UDC device to test with, no runtime testing was able to
be performed.

Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add "goto err;" when allocation fails.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 01968e2167f9..7dc2457c7460 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1516,6 +1516,10 @@ static int ast_udc_probe(struct platform_device *pdev)
 					  AST_UDC_EP_DMA_SIZE *
 					  AST_UDC_NUM_ENDPOINTS,
 					  &udc->ep0_buf_dma, GFP_KERNEL);
+	if (!udc->ep0_buf) {
+		rc = -ENOMEM;
+		goto err;
+	}
 
 	udc->gadget.speed = USB_SPEED_UNKNOWN;
 	udc->gadget.max_speed = USB_SPEED_HIGH;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
  2022-12-14  2:54 ` Jiasheng Jiang
  (?)
  (?)
@ 2022-12-14  8:25   ` Greg KH
  -1 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2022-12-14  8:25 UTC (permalink / raw)
  To: linux-aspeed

On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent in order to
> avoid NULL pointer dereference.
> 
> This flaw was found using an experimental static analysis tool we are
> developing, APP-Miner, which has not been disclosed.
> 
> The allyesconfig build using GCC 9.3.0 shows no new warning. As we
> don't have a UDC device to test with, no runtime testing was able to
> be performed.
> 
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2:
> 
> 1. Add "goto err;" when allocation fails.

You already sent a previous v2 that differs from this one, this should
be v3, right?


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-14  8:25   ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2022-12-14  8:25 UTC (permalink / raw)
  To: Jiasheng Jiang
  Cc: neal_liu, joel, andrew, sumit.semwal, christian.koenig,
	linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
	linux-media, dri-devel, linaro-mm-sig

On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent in order to
> avoid NULL pointer dereference.
> 
> This flaw was found using an experimental static analysis tool we are
> developing, APP-Miner, which has not been disclosed.
> 
> The allyesconfig build using GCC 9.3.0 shows no new warning. As we
> don't have a UDC device to test with, no runtime testing was able to
> be performed.
> 
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2:
> 
> 1. Add "goto err;" when allocation fails.

You already sent a previous v2 that differs from this one, this should
be v3, right?


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-14  8:25   ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2022-12-14  8:25 UTC (permalink / raw)
  To: Jiasheng Jiang
  Cc: neal_liu, joel, andrew, sumit.semwal, christian.koenig,
	linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
	linux-media, dri-devel, linaro-mm-sig

On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent in order to
> avoid NULL pointer dereference.
> 
> This flaw was found using an experimental static analysis tool we are
> developing, APP-Miner, which has not been disclosed.
> 
> The allyesconfig build using GCC 9.3.0 shows no new warning. As we
> don't have a UDC device to test with, no runtime testing was able to
> be performed.
> 
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2:
> 
> 1. Add "goto err;" when allocation fails.

You already sent a previous v2 that differs from this one, this should
be v3, right?


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent
@ 2022-12-14  8:25   ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2022-12-14  8:25 UTC (permalink / raw)
  To: Jiasheng Jiang
  Cc: linux-aspeed, andrew, neal_liu, linux-usb, linux-kernel,
	dri-devel, sumit.semwal, linaro-mm-sig, joel, christian.koenig,
	linux-arm-kernel, linux-media

On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of dma_alloc_coherent in order to
> avoid NULL pointer dereference.
> 
> This flaw was found using an experimental static analysis tool we are
> developing, APP-Miner, which has not been disclosed.
> 
> The allyesconfig build using GCC 9.3.0 shows no new warning. As we
> don't have a UDC device to test with, no runtime testing was able to
> be performed.
> 
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2:
> 
> 1. Add "goto err;" when allocation fails.

You already sent a previous v2 that differs from this one, this should
be v3, right?


^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-12-14  8:27 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-13 12:21 [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent Jiasheng Jiang
2022-12-13 12:21 ` Jiasheng Jiang
2022-12-13 12:21 ` Jiasheng Jiang
2022-12-13 12:21 ` Jiasheng Jiang
2022-12-13 14:32 ` Greg KH
2022-12-13 14:32   ` Greg KH
2022-12-13 14:32   ` Greg KH
2022-12-13 14:32   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2022-12-14  2:54 Jiasheng Jiang
2022-12-14  2:54 ` Jiasheng Jiang
2022-12-14  2:54 ` Jiasheng Jiang
2022-12-14  2:54 ` Jiasheng Jiang
2022-12-14  8:25 ` Greg KH
2022-12-14  8:25   ` Greg KH
2022-12-14  8:25   ` Greg KH
2022-12-14  8:25   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.