From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix iostat parameter for discard
Date: Tue, 13 Dec 2022 11:11:08 -0800 [thread overview]
Message-ID: <Y5jOTL66ph3Nq/Hr@google.com> (raw)
In-Reply-To: <20221213115454.14885-1-frank.li@vivo.com>
On 12/13, Yangtao Li wrote:
> > What do you think of extending this function to support io_counts?
> >
> > void f2fs_update_iostat(struct f2fs_sb_info *sbi, struct inode *inode,
> > enum iostat_type type, unsigned long long io_bytes,
> > unsigned long long io_counts)
>
> Support to have extra io_count.
>
> But I don't think there is any need to add additional parameters to f2fs_update_iostat.
> IIUC, each call to f2fs_update_iostat means that the corresponding count increases by 1,
> so only the internal processing of the function is required.
>
> BTW, let's type out the iocount of the additional record in the following way?
>
> time: 1670930162
> [WRITE]
> app buffered data: 4096(1)
How about giving in another columns with additional stats like avg. len/call or max. len?
app buffered data: 4096 1
>
> Thx,
> Yangtao
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix iostat parameter for discard
Date: Tue, 13 Dec 2022 11:11:08 -0800 [thread overview]
Message-ID: <Y5jOTL66ph3Nq/Hr@google.com> (raw)
In-Reply-To: <20221213115454.14885-1-frank.li@vivo.com>
On 12/13, Yangtao Li wrote:
> > What do you think of extending this function to support io_counts?
> >
> > void f2fs_update_iostat(struct f2fs_sb_info *sbi, struct inode *inode,
> > enum iostat_type type, unsigned long long io_bytes,
> > unsigned long long io_counts)
>
> Support to have extra io_count.
>
> But I don't think there is any need to add additional parameters to f2fs_update_iostat.
> IIUC, each call to f2fs_update_iostat means that the corresponding count increases by 1,
> so only the internal processing of the function is required.
>
> BTW, let's type out the iocount of the additional record in the following way?
>
> time: 1670930162
> [WRITE]
> app buffered data: 4096(1)
How about giving in another columns with additional stats like avg. len/call or max. len?
app buffered data: 4096 1
>
> Thx,
> Yangtao
next prev parent reply other threads:[~2022-12-13 19:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 14:56 [f2fs-dev] [PATCH] f2fs: fix iostat parameter for discard Yangtao Li via Linux-f2fs-devel
2022-12-05 14:56 ` Yangtao Li
2022-12-11 2:23 ` [f2fs-dev] " Chao Yu
2022-12-11 2:23 ` Chao Yu
2022-12-12 22:59 ` [f2fs-dev] " Jaegeuk Kim
2022-12-12 22:59 ` Jaegeuk Kim
2022-12-13 1:46 ` [f2fs-dev] " Chao Yu
2022-12-13 1:46 ` Chao Yu
2022-12-13 11:54 ` [f2fs-dev] " Yangtao Li via Linux-f2fs-devel
2022-12-13 11:54 ` Yangtao Li
2022-12-13 19:11 ` Jaegeuk Kim [this message]
2022-12-13 19:11 ` Jaegeuk Kim
2022-12-15 2:21 ` [f2fs-dev] " Chao Yu
2022-12-15 2:21 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5jOTL66ph3Nq/Hr@google.com \
--to=jaegeuk@kernel.org \
--cc=frank.li@vivo.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.