All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Vineet Gupta <vineetg@rivosinc.com>
Cc: linux-riscv@lists.infradead.org, linux@rivosinc.com,
	Jisheng Zhang <jszhang@kernel.org>
Subject: Re: [PATCH] riscv: add base extensions to enum riscv_isa_ext_id
Date: Thu, 22 Dec 2022 23:35:10 +0000	[thread overview]
Message-ID: <Y6TprjVBPX6CRvOm@spud> (raw)
In-Reply-To: <1cd24228-847f-61a1-2466-07f0cc4c221a@rivosinc.com>


[-- Attachment #1.1: Type: text/plain, Size: 826 bytes --]

On Thu, Dec 22, 2022 at 03:13:56PM -0800, Vineet Gupta wrote:
> 
> 
> On 12/22/22 14:53, Conor Dooley wrote:
> > Hi Vineet,
> > 
> > On Thu, Dec 22, 2022 at 02:41:04PM -0800, Vineet Gupta wrote:
> > > This allows for using the enum in general to refer to any extension.
> > What is the point of this patch? It's hard to understand the rationale
> > without having any user, especially...
> 
> Right I'm trying to build a cpu feature enable API which required handling
> of all extensions.

Does it matter to you if it's defines or an enum, as long as every
extension is exposed to you via the same mechanism?

> Ideally yes this needs to go there. But it seemed more like a cleanup type
> patch to warrant a standalone submission.

Meh, dw. Not expecting people to know about every patch under the sun.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-12-22 23:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 22:41 [PATCH] riscv: add base extensions to enum riscv_isa_ext_id Vineet Gupta
2022-12-22 22:53 ` Conor Dooley
2022-12-22 23:01   ` Conor Dooley
2022-12-22 23:13   ` Vineet Gupta
2022-12-22 23:35     ` Conor Dooley [this message]
2022-12-23  0:03       ` Vineet Gupta
2022-12-23  0:30         ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6TprjVBPX6CRvOm@spud \
    --to=conor@kernel.org \
    --cc=jszhang@kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@rivosinc.com \
    --cc=vineetg@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.