From: Borislav Petkov <bp@alien8.de>
To: Kun-Fa Lin <milkfafa@gmail.com>
Cc: krzysztof.kozlowski@linaro.org, robh+dt@kernel.org,
tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org,
rric@kernel.org, benjaminfair@google.com, yuenn@google.com,
venture@google.com, avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
openbmc@lists.ozlabs.org, KWLIU@nuvoton.com, YSCHU@nuvoton.com,
ctcchien@nuvoton.com, kflin@nuvoton.com
Subject: Re: [PATCH v17 3/3] EDAC/npcm: Add NPCM memory controller driver
Date: Mon, 26 Dec 2022 05:50:42 +0100 [thread overview]
Message-ID: <Y6koIrTN2PYpQVGO@zn.tnic> (raw)
In-Reply-To: <CADnNmFqQ5_OQ-FiqdSZAtXFdG2X=qociXBykqL0TqtMw9r_=_A@mail.gmail.com>
On Mon, Dec 26, 2022 at 11:50:54AM +0800, Kun-Fa Lin wrote:
> > > + syndrome = priv->location ? 1 << priv->bit :
> > > + data_synd[priv->bit];
> >
> > syndrome = priv->location ? 1 << priv->bit
> > : data_synd[priv->bit];
>
> Just to confirm the indentation, is it right as follows?
>
> syndrome = priv->location ? 1 << priv->bit
> : data_synd[priv->bit];
>
> And I was wondering if I should just remove the line break and let it stick out?
The idea is to have the '?' and the ':' under each other so that one
can visually immediately "parse" where each of the sides of the ternary
statement start.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Kun-Fa Lin <milkfafa@gmail.com>
Cc: devicetree@vger.kernel.org, tony.luck@intel.com, rric@kernel.org,
benjaminfair@google.com, linux-edac@vger.kernel.org,
KWLIU@nuvoton.com, avifishman70@gmail.com, venture@google.com,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
tali.perry1@gmail.com, krzysztof.kozlowski@linaro.org,
robh+dt@kernel.org, james.morse@arm.com, ctcchien@nuvoton.com,
YSCHU@nuvoton.com, mchehab@kernel.org, kflin@nuvoton.com,
tmaimon77@gmail.com
Subject: Re: [PATCH v17 3/3] EDAC/npcm: Add NPCM memory controller driver
Date: Mon, 26 Dec 2022 05:50:42 +0100 [thread overview]
Message-ID: <Y6koIrTN2PYpQVGO@zn.tnic> (raw)
In-Reply-To: <CADnNmFqQ5_OQ-FiqdSZAtXFdG2X=qociXBykqL0TqtMw9r_=_A@mail.gmail.com>
On Mon, Dec 26, 2022 at 11:50:54AM +0800, Kun-Fa Lin wrote:
> > > + syndrome = priv->location ? 1 << priv->bit :
> > > + data_synd[priv->bit];
> >
> > syndrome = priv->location ? 1 << priv->bit
> > : data_synd[priv->bit];
>
> Just to confirm the indentation, is it right as follows?
>
> syndrome = priv->location ? 1 << priv->bit
> : data_synd[priv->bit];
>
> And I was wondering if I should just remove the line break and let it stick out?
The idea is to have the '?' and the ':' under each other so that one
can visually immediately "parse" where each of the sides of the ternary
statement start.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-12-26 4:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 3:28 [PATCH v17 0/3] EDAC/nuvoton: Add NPCM memory controller driver Marvin Lin
2022-12-23 3:28 ` Marvin Lin
2022-12-23 3:28 ` [PATCH v17 1/3] ARM: dts: nuvoton: Add node for NPCM memory controller Marvin Lin
2022-12-23 3:28 ` Marvin Lin
2022-12-23 3:28 ` [PATCH v17 2/3] dt-bindings: edac: nuvoton: Add document " Marvin Lin
2022-12-23 3:28 ` Marvin Lin
2022-12-27 8:58 ` Krzysztof Kozlowski
2022-12-28 9:35 ` Kun-Fa Lin
2022-12-28 9:35 ` Kun-Fa Lin
2022-12-23 3:28 ` [PATCH v17 3/3] EDAC/npcm: Add NPCM memory controller driver Marvin Lin
2022-12-23 3:28 ` Marvin Lin
2022-12-23 13:05 ` Borislav Petkov
2022-12-23 13:05 ` Borislav Petkov
2022-12-26 3:50 ` Kun-Fa Lin
2022-12-26 3:50 ` Kun-Fa Lin
2022-12-26 4:50 ` Borislav Petkov [this message]
2022-12-26 4:50 ` Borislav Petkov
2022-12-26 5:29 ` Kun-Fa Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6koIrTN2PYpQVGO@zn.tnic \
--to=bp@alien8.de \
--cc=KWLIU@nuvoton.com \
--cc=YSCHU@nuvoton.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=ctcchien@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=kflin@nuvoton.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=milkfafa@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=rric@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=tony.luck@intel.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.