All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
	Rajat Khandelwal <rajat.khandelwal@linux.intel.com>,
	netdev@vger.kernel.org, rajat.khandelwal@intel.com,
	jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
	kuba@kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
	davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP
Date: Wed, 4 Jan 2023 08:31:31 +0200	[thread overview]
Message-ID: <Y7UdQ3aHzKejN0Aj@unreal> (raw)
In-Reply-To: <Y7RjCkanr0Ulx3TD@unreal>

On Tue, Jan 03, 2023 at 07:16:58PM +0200, Leon Romanovsky wrote:
> On Tue, Jan 03, 2023 at 08:21:04AM -0600, Bjorn Helgaas wrote:

<...>

> > > > If a quirk like this is only needed when the driver is loaded, 
> > > 
> > > This is always the case with PCI devices managed through kernel, isn't it?
> > > Users don't care/aware about "broken" devices unless they start to use them.
> > 
> > Indeed, that's usually the case.  There's a lot of stuff in quirks.c
> > that could probably be in drivers instead.
> 
> NP, so or deprecate quirks.c and prohibit any change to that file or
> don't allow drivers to mangle PCI in their probe routines.
> Everything in-between will cause to enormous mess in long run.

Another thing to consider what if you go with "probe variant", users
will see behavioral differences between drivers and subsystems on
how to control these quirks.

As an example, see proposal in this thread to add ethtool private flag
to enable/disable quirk. In other places, it will be module parameter,
sysfs or special to that subsystem tool.

Thanks

> 
> Thanks
> 
> > 
> > Bjorn
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
	Rajat Khandelwal <rajat.khandelwal@linux.intel.com>,
	anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
	rajat.khandelwal@intel.com, jesse.brandeburg@intel.com,
	linux-kernel@vger.kernel.org, edumazet@google.com,
	intel-wired-lan@lists.osuosl.org, linux-pci@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP
Date: Wed, 4 Jan 2023 08:31:31 +0200	[thread overview]
Message-ID: <Y7UdQ3aHzKejN0Aj@unreal> (raw)
In-Reply-To: <Y7RjCkanr0Ulx3TD@unreal>

On Tue, Jan 03, 2023 at 07:16:58PM +0200, Leon Romanovsky wrote:
> On Tue, Jan 03, 2023 at 08:21:04AM -0600, Bjorn Helgaas wrote:

<...>

> > > > If a quirk like this is only needed when the driver is loaded, 
> > > 
> > > This is always the case with PCI devices managed through kernel, isn't it?
> > > Users don't care/aware about "broken" devices unless they start to use them.
> > 
> > Indeed, that's usually the case.  There's a lot of stuff in quirks.c
> > that could probably be in drivers instead.
> 
> NP, so or deprecate quirks.c and prohibit any change to that file or
> don't allow drivers to mangle PCI in their probe routines.
> Everything in-between will cause to enormous mess in long run.

Another thing to consider what if you go with "probe variant", users
will see behavioral differences between drivers and subsystems on
how to control these quirks.

As an example, see proposal in this thread to add ethtool private flag
to enable/disable quirk. In other places, it will be module parameter,
sysfs or special to that subsystem tool.

Thanks

> 
> Thanks
> 
> > 
> > Bjorn

  reply	other threads:[~2023-01-04  6:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 12:26 [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP Rajat Khandelwal
2022-12-29 12:26 ` Rajat Khandelwal
2023-01-01  7:27 ` [Intel-wired-lan] " Neftin, Sasha
2023-01-01  7:27   ` Neftin, Sasha
2023-01-01  8:32 ` Leon Romanovsky
2023-01-01  8:32   ` Leon Romanovsky
2023-01-01 10:34   ` [Intel-wired-lan] " Paul Menzel
2023-01-01 10:34     ` Paul Menzel
2023-01-03  9:54     ` Leon Romanovsky
2023-01-03  9:54       ` Leon Romanovsky
2023-01-03 11:54       ` Bjorn Helgaas
2023-01-03 11:54         ` Bjorn Helgaas
2023-01-03 12:00         ` Leon Romanovsky
2023-01-03 12:00           ` Leon Romanovsky
2023-01-03 14:21           ` Bjorn Helgaas
2023-01-03 14:21             ` Bjorn Helgaas
2023-01-03 17:16             ` Leon Romanovsky
2023-01-03 17:16               ` Leon Romanovsky
2023-01-04  6:31               ` Leon Romanovsky [this message]
2023-01-04  6:31                 ` Leon Romanovsky
2023-01-04  5:35             ` Neftin, Sasha
2023-01-01 10:32 ` Paul Menzel
2023-01-01 10:32   ` Paul Menzel
2023-01-02 17:38   ` Khandelwal, Rajat
2023-01-02 17:38     ` Khandelwal, Rajat
2023-01-03  5:44     ` Neftin, Sasha
2023-01-03  6:58       ` Khandelwal, Rajat
2023-01-03 19:13         ` Bjorn Helgaas
2023-01-03 19:13           ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7UdQ3aHzKejN0Aj@unreal \
    --to=leon@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=helgaas@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=rajat.khandelwal@intel.com \
    --cc=rajat.khandelwal@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.