From: Lee Jones <lee@kernel.org>
To: nick.hawkins@hpe.com
Cc: verdun@hpe.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/5] ARM: Add GXP I2C Support
Date: Thu, 19 Jan 2023 14:25:12 +0000 [thread overview]
Message-ID: <Y8lSyJWm+JAQw3AW@google.com> (raw)
In-Reply-To: <20230117204439.76841-1-nick.hawkins@hpe.com>
On Tue, 17 Jan 2023, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> The GXP SoC supports 10 I2C engines. Each I2C engine is completely
> independent and can function both as an I2C master and I2C slave. The
> I2C master can operate in a multi master environment. The engines support
> a scalable speed from 8kHZ to 1.5 Mhz.
>
> ---
>
> Changes since v1:
> *Removed yaml documentation of hpe,gxp-sysreg as it has been
> applied to syscon.yaml
> *Made i2cX a generic node name i2c in dts file
> *Added status field to the dtsi and the dts for i2c bus
> *Removed unnecessary size-cells and address-cells from yaml
> *Removed phandle from hpe,sysreg-phandle
> *Changed hpe,i2c-max-bus-freq to clock-frequency
> *Removed rogue tab in structure definition
> *Removed use of __iomem *base local variables as it was
> unnecessary
> *Switched #if IS_ENABLED() -> if (IS_ENABLED()) inside
> functions
> *Removed use of pr_* functions
> *Removed informational prints in register and unregister
> functions
> *Removed print from interrupt handler
> *Removed informational prints from probe function
> *Switched dev_err -> dev_err_probe in probe function
> *Used the respective helper for mapping the resource to
> __iomem
>
> Nick Hawkins (5):
> i2c: hpe: Add GXP SoC I2C Controller
> dt-bindings: i2c: Add hpe,gxp-i2c
> ARM: dts: hpe: Add I2C Topology
> ARM: multi_v7_defconfig: add gxp i2c module
> MAINTAINERS: Add HPE GXP I2C Support
>
> .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 54 ++
> MAINTAINERS | 2 +
> arch/arm/boot/dts/hpe-bmc-dl360gen10.dts | 109 ++++
> arch/arm/boot/dts/hpe-gxp.dtsi | 125 ++++
> arch/arm/configs/multi_v7_defconfig | 1 +
> drivers/i2c/busses/Kconfig | 7 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-gxp.c | 609 ++++++++++++++++++
> 8 files changed, 908 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml
> create mode 100644 drivers/i2c/busses/i2c-gxp.c
Not trying to be rude, but why have you sent this to me?
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: nick.hawkins@hpe.com
Cc: verdun@hpe.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/5] ARM: Add GXP I2C Support
Date: Thu, 19 Jan 2023 14:25:12 +0000 [thread overview]
Message-ID: <Y8lSyJWm+JAQw3AW@google.com> (raw)
In-Reply-To: <20230117204439.76841-1-nick.hawkins@hpe.com>
On Tue, 17 Jan 2023, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> The GXP SoC supports 10 I2C engines. Each I2C engine is completely
> independent and can function both as an I2C master and I2C slave. The
> I2C master can operate in a multi master environment. The engines support
> a scalable speed from 8kHZ to 1.5 Mhz.
>
> ---
>
> Changes since v1:
> *Removed yaml documentation of hpe,gxp-sysreg as it has been
> applied to syscon.yaml
> *Made i2cX a generic node name i2c in dts file
> *Added status field to the dtsi and the dts for i2c bus
> *Removed unnecessary size-cells and address-cells from yaml
> *Removed phandle from hpe,sysreg-phandle
> *Changed hpe,i2c-max-bus-freq to clock-frequency
> *Removed rogue tab in structure definition
> *Removed use of __iomem *base local variables as it was
> unnecessary
> *Switched #if IS_ENABLED() -> if (IS_ENABLED()) inside
> functions
> *Removed use of pr_* functions
> *Removed informational prints in register and unregister
> functions
> *Removed print from interrupt handler
> *Removed informational prints from probe function
> *Switched dev_err -> dev_err_probe in probe function
> *Used the respective helper for mapping the resource to
> __iomem
>
> Nick Hawkins (5):
> i2c: hpe: Add GXP SoC I2C Controller
> dt-bindings: i2c: Add hpe,gxp-i2c
> ARM: dts: hpe: Add I2C Topology
> ARM: multi_v7_defconfig: add gxp i2c module
> MAINTAINERS: Add HPE GXP I2C Support
>
> .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 54 ++
> MAINTAINERS | 2 +
> arch/arm/boot/dts/hpe-bmc-dl360gen10.dts | 109 ++++
> arch/arm/boot/dts/hpe-gxp.dtsi | 125 ++++
> arch/arm/configs/multi_v7_defconfig | 1 +
> drivers/i2c/busses/Kconfig | 7 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-gxp.c | 609 ++++++++++++++++++
> 8 files changed, 908 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml
> create mode 100644 drivers/i2c/busses/i2c-gxp.c
Not trying to be rude, but why have you sent this to me?
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-20 4:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 20:44 [PATCH v2 0/5] ARM: Add GXP I2C Support nick.hawkins
2023-01-17 20:44 ` nick.hawkins
2023-01-17 20:44 ` [PATCH v2 1/5] i2c: hpe: Add GXP SoC I2C Controller nick.hawkins
2023-01-17 20:44 ` nick.hawkins
2023-01-18 1:36 ` Joel Stanley
2023-01-18 1:36 ` Joel Stanley
2023-01-17 20:44 ` [PATCH v2 2/5] dt-bindings: i2c: Add hpe,gxp-i2c nick.hawkins
2023-01-17 20:44 ` nick.hawkins
2023-01-18 16:34 ` Rob Herring
2023-01-18 16:34 ` Rob Herring
2023-01-17 20:44 ` [PATCH v2 3/5] ARM: dts: hpe: Add I2C Topology nick.hawkins
2023-01-17 20:44 ` nick.hawkins
2023-01-17 20:44 ` [PATCH v2 4/5] ARM: multi_v7_defconfig: add gxp i2c module nick.hawkins
2023-01-17 20:44 ` nick.hawkins
2023-01-17 20:44 ` [PATCH v2 5/5] MAINTAINERS: Add HPE GXP I2C Support nick.hawkins
2023-01-17 20:44 ` nick.hawkins
2023-01-19 14:25 ` Lee Jones [this message]
2023-01-19 14:25 ` [PATCH v2 0/5] ARM: Add " Lee Jones
2023-01-19 15:03 ` Hawkins, Nick
2023-01-19 15:03 ` Hawkins, Nick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lSyJWm+JAQw3AW@google.com \
--to=lee@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.