From: Petr Mladek <pmladek@suse.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
live-patching@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Song Liu <song@kernel.org>
Subject: Re: [PATCH 1/2] powerpc/module_64: Improve restore_r2() return semantics
Date: Wed, 25 Jan 2023 14:24:50 +0100 [thread overview]
Message-ID: <Y9EtohjVnoJLqccx@alley> (raw)
In-Reply-To: <15baf76c271a0ae09f7b8556e50f2b4251e7049d.1674617130.git.jpoimboe@kernel.org>
On Tue 2023-01-24 19:38:04, Josh Poimboeuf wrote:
> restore_r2() returns 1 on success, which is surprising for a non-boolean
> function. Change it to return 0 on success and -errno on error to match
> kernel coding convention.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Looks good:
Reviewed-by: Petr Mladek <pmladek@suse.com>
It is in the right direction. Just note that there are more functions
with the boolean semantic passed via int return value. But there
are also other functions already using the 0/-E* return values so
this is rather positive change.
Best Regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: linux-kernel@vger.kernel.org, Song Liu <song@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
live-patching@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] powerpc/module_64: Improve restore_r2() return semantics
Date: Wed, 25 Jan 2023 14:24:50 +0100 [thread overview]
Message-ID: <Y9EtohjVnoJLqccx@alley> (raw)
In-Reply-To: <15baf76c271a0ae09f7b8556e50f2b4251e7049d.1674617130.git.jpoimboe@kernel.org>
On Tue 2023-01-24 19:38:04, Josh Poimboeuf wrote:
> restore_r2() returns 1 on success, which is surprising for a non-boolean
> function. Change it to return 0 on success and -errno on error to match
> kernel coding convention.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Looks good:
Reviewed-by: Petr Mladek <pmladek@suse.com>
It is in the right direction. Just note that there are more functions
with the boolean semantic passed via int return value. But there
are also other functions already using the 0/-E* return values so
this is rather positive change.
Best Regards,
Petr
next prev parent reply other threads:[~2023-01-25 13:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 3:38 [PATCH 0/2] powerpc: Fix livepatch module re-patching issue Josh Poimboeuf
2023-01-25 3:38 ` Josh Poimboeuf
2023-01-25 3:38 ` [PATCH 1/2] powerpc/module_64: Improve restore_r2() return semantics Josh Poimboeuf
2023-01-25 3:38 ` Josh Poimboeuf
2023-01-25 5:53 ` Song Liu
2023-01-25 5:53 ` Song Liu
2023-01-25 13:24 ` Petr Mladek [this message]
2023-01-25 13:24 ` Petr Mladek
2023-01-27 12:38 ` Miroslav Benes
2023-01-27 12:38 ` Miroslav Benes
2023-01-25 3:38 ` [PATCH 2/2] powerpc/module_64: Fix "expected nop" error on module re-patching Josh Poimboeuf
2023-01-25 3:38 ` Josh Poimboeuf
2023-01-25 6:09 ` Song Liu
2023-01-25 6:09 ` Song Liu
2023-01-25 16:46 ` Josh Poimboeuf
2023-01-25 16:46 ` Josh Poimboeuf
2023-01-25 17:36 ` Song Liu
2023-01-25 17:36 ` Song Liu
2023-01-25 18:53 ` Josh Poimboeuf
2023-01-25 18:58 ` Song Liu
2023-01-25 13:31 ` Petr Mladek
2023-01-25 13:31 ` Petr Mladek
2023-01-27 12:50 ` Miroslav Benes
2023-01-27 12:50 ` Miroslav Benes
2023-01-27 13:48 ` [PATCH 0/2] powerpc: Fix livepatch module re-patching issue Joe Lawrence
2023-01-27 13:48 ` Joe Lawrence
2023-02-04 17:23 ` Josh Poimboeuf
2023-02-04 17:23 ` Josh Poimboeuf
2023-02-05 0:46 ` Michael Ellerman
2023-02-05 0:46 ` Michael Ellerman
2023-02-05 16:21 ` Josh Poimboeuf
2023-02-05 16:21 ` Josh Poimboeuf
2023-02-05 0:46 ` Michael Ellerman
2023-02-05 0:46 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9EtohjVnoJLqccx@alley \
--to=pmladek@suse.com \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.