Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

From: Leon Romanovsky <leon@kernel.org>
To: bkkarthik <bkkarthik@pesu.pes.edu>
Cc: gregkh@linuxfoundation.org,
	Anupama K Patil <anupamakpatil123@gmail.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	linux-acpi@vger.kernel.org, kernelnewbies@kernelnewbies.org,
	skhan@linuxfoundation.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices
Date: Tue, 27 Apr 2021 07:26:27 +0300	[thread overview]
Message-ID: <YIeSc1qePhuQ1XRK@unreal> (raw)
In-Reply-To: <20210426175031.w26ovnffjiow346h@burgerking>

On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote:
> On 21/04/26 08:04AM, Leon Romanovsky wrote:
> > On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote:
> > > isapnp_proc_init() does not look at the return value from
> > > isapnp_proc_attach_device(). Check for this return value in
> > > isapnp_proc_detach_device().
> > > 
> > > Cleanup in isapnp_proc_detach_device and
> > > isapnp_proc_detach_bus() for cleanup.
> > > 
> > > Changed sprintf() to the kernel-space function scnprintf() as it returns
> > > the actual number of bytes written.
> > > 
> > > Removed unnecessary variables de, e of type 'struct proc_dir_entry' to
> > > save memory.

<...>

> > > +static int isapnp_proc_detach_device(struct pnp_dev *dev)
> > > +{
> > > +	proc_remove(dev->procent);
> > > +	dev->procent = NULL;
> > > +	return 0;
> > > +}
> > > +
> > > +static int isapnp_proc_detach_bus(struct pnp_card *bus)
> > > +{
> > > +	proc_remove(bus->procdir);
> > > +	return 0;
> > > +}
> > 
> > Please don't add one line functions that are called only once and have
> > return value that no one care about it.
> 
> These were only intended for a clean-up job, the idea of this function came from how PCI handles procfs.
> Maybe those should be changed?

Probably, the CONFIG_PROC_FS around pci_proc_*() is not needed too.

Thanks

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies