All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Anupama K Patil <anupamakpatil123@gmail.com>
Cc: kernelnewbies@kernelnewbies.org, gregkh@linuxfoundation.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	bkkarthik@pesu.pes.edu, linux-kernel@vger.kernel.org,
	Jaroslav Kysela <perex@perex.cz>,
	linux-acpi@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices
Date: Sat, 24 Apr 2021 16:37:52 -0400	[thread overview]
Message-ID: <437247.1619296672@turing-police> (raw)
In-Reply-To: <20210424194301.jmsqpycvsm7izbk3@ubuntu>


[-- Attachment #1.1: Type: text/plain, Size: 495 bytes --]

On Sun, 25 Apr 2021 01:13:01 +0530, Anupama K Patil said:
> Changed sprintf() to the kernel-space function scnprintf() as it returns
> the actual number of bytes written.

> +	if (!bus->procdir) {
> +		scnprintf(name, 16, "%02x", bus->number);

> +	scnprintf(name, 16, "%02x", dev->number);

Why do this when you don't *use* the number of bytes written, but instead ignore
the value returned?

For bonus points:  Given the %02x format, under what conditions can it
return a value other than 2?


[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

WARNING: multiple messages have this Message-ID (diff)
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Anupama K Patil <anupamakpatil123@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org, bkkarthik@pesu.pes.edu,
	gregkh@linuxfoundation.org, kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices
Date: Sat, 24 Apr 2021 16:37:52 -0400	[thread overview]
Message-ID: <437247.1619296672@turing-police> (raw)
In-Reply-To: <20210424194301.jmsqpycvsm7izbk3@ubuntu>

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

On Sun, 25 Apr 2021 01:13:01 +0530, Anupama K Patil said:
> Changed sprintf() to the kernel-space function scnprintf() as it returns
> the actual number of bytes written.

> +	if (!bus->procdir) {
> +		scnprintf(name, 16, "%02x", bus->number);

> +	scnprintf(name, 16, "%02x", dev->number);

Why do this when you don't *use* the number of bytes written, but instead ignore
the value returned?

For bonus points:  Given the %02x format, under what conditions can it
return a value other than 2?


[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2021-04-24 20:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 19:43 [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices Anupama K Patil
2021-04-24 19:43 ` Anupama K Patil
2021-04-24 20:37 ` Valdis Klētnieks [this message]
2021-04-24 20:37   ` Valdis Klētnieks
2021-04-25  1:06 ` Barnabás Pőcze
2021-04-25  1:06   ` Barnabás Pőcze
2021-04-26  5:04 ` Leon Romanovsky
2021-04-26  5:04   ` Leon Romanovsky
2021-04-26 17:50   ` bkkarthik
2021-04-26 17:50     ` bkkarthik
2021-04-27  4:26     ` Leon Romanovsky
2021-04-27  4:26       ` Leon Romanovsky
2021-04-29  4:31       ` Valdis Klētnieks
2021-04-29  4:31         ` Valdis Klētnieks
2021-04-29  7:05         ` Leon Romanovsky
2021-04-29  7:05           ` Leon Romanovsky
2021-04-28 12:04     ` Jaroslav Kysela
2021-04-28 12:04       ` Jaroslav Kysela
2021-04-28 12:21       ` Leon Romanovsky
2021-04-28 12:21         ` Leon Romanovsky
2021-04-28 12:26         ` bkkarthik
2021-04-28 12:26           ` bkkarthik
2021-04-28 12:30         ` Jaroslav Kysela
2021-04-28 12:30           ` Jaroslav Kysela
2021-04-28 12:37           ` bkkarthik
2021-04-28 12:37             ` bkkarthik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=437247.1619296672@turing-police \
    --to=valdis.kletnieks@vt.edu \
    --cc=anupamakpatil123@gmail.com \
    --cc=bkkarthik@pesu.pes.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.