From: Leon Romanovsky <leon@kernel.org>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Xianting Tian <xianting.tian@linux.alibaba.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kuba@kernel.org,
davem@davemloft.net
Subject: Re: [PATCH] virtio_net: Remove BUG() to aviod machine dead
Date: Wed, 2 Jun 2021 08:59:26 +0300 [thread overview]
Message-ID: <YLcePtKhnt9gXq8E@unreal> (raw)
In-Reply-To: <72f284c6-b2f5-a395-a68f-afe801eb81be@redhat.com>
On Tue, May 25, 2021 at 02:19:03PM +0800, Jason Wang wrote:
>
> 在 2021/5/19 下午10:18, Xianting Tian 写道:
> > thanks, I submit the patch as commented by Andrew
> > https://lkml.org/lkml/2021/5/18/256
> >
> > Actually, if xmit_skb() returns error, below code will give a warning
> > with error code.
> >
> > /* Try to transmit */
> > err = xmit_skb(sq, skb);
> >
> > /* This should not happen! */
> > if (unlikely(err)) {
> > dev->stats.tx_fifo_errors++;
> > if (net_ratelimit())
> > dev_warn(&dev->dev,
> > "Unexpected TXQ (%d) queue failure: %d\n",
> > qnum, err);
> > dev->stats.tx_dropped++;
> > dev_kfree_skb_any(skb);
> > return NETDEV_TX_OK;
> > }
> >
> >
> >
> >
> >
> > 在 2021/5/18 下午5:54, Michael S. Tsirkin 写道:
> > > typo in subject
> > >
> > > On Tue, May 18, 2021 at 05:46:56PM +0800, Xianting Tian wrote:
> > > > When met error, we output a print to avoid a BUG().
>
>
> So you don't explain why you need to remove BUG(). I think it deserve a
> BUG().
BUG() will crash the machine and virtio_net is not kernel core
functionality that must stop the machine to prevent anything truly
harmful and basic.
I would argue that code in drivers/* shouldn't call BUG() macros at all.
If it is impossible, don't check for that or add WARN_ON() and recover,
but don't crash whole system.
Thanks
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Jason Wang <jasowang@redhat.com>
Cc: Xianting Tian <xianting.tian@linux.alibaba.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
davem@davemloft.net, kuba@kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_net: Remove BUG() to aviod machine dead
Date: Wed, 2 Jun 2021 08:59:26 +0300 [thread overview]
Message-ID: <YLcePtKhnt9gXq8E@unreal> (raw)
In-Reply-To: <72f284c6-b2f5-a395-a68f-afe801eb81be@redhat.com>
On Tue, May 25, 2021 at 02:19:03PM +0800, Jason Wang wrote:
>
> 在 2021/5/19 下午10:18, Xianting Tian 写道:
> > thanks, I submit the patch as commented by Andrew
> > https://lkml.org/lkml/2021/5/18/256
> >
> > Actually, if xmit_skb() returns error, below code will give a warning
> > with error code.
> >
> > /* Try to transmit */
> > err = xmit_skb(sq, skb);
> >
> > /* This should not happen! */
> > if (unlikely(err)) {
> > dev->stats.tx_fifo_errors++;
> > if (net_ratelimit())
> > dev_warn(&dev->dev,
> > "Unexpected TXQ (%d) queue failure: %d\n",
> > qnum, err);
> > dev->stats.tx_dropped++;
> > dev_kfree_skb_any(skb);
> > return NETDEV_TX_OK;
> > }
> >
> >
> >
> >
> >
> > 在 2021/5/18 下午5:54, Michael S. Tsirkin 写道:
> > > typo in subject
> > >
> > > On Tue, May 18, 2021 at 05:46:56PM +0800, Xianting Tian wrote:
> > > > When met error, we output a print to avoid a BUG().
>
>
> So you don't explain why you need to remove BUG(). I think it deserve a
> BUG().
BUG() will crash the machine and virtio_net is not kernel core
functionality that must stop the machine to prevent anything truly
harmful and basic.
I would argue that code in drivers/* shouldn't call BUG() macros at all.
If it is impossible, don't check for that or add WARN_ON() and recover,
but don't crash whole system.
Thanks
next prev parent reply other threads:[~2021-06-02 5:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 9:46 [PATCH] virtio_net: Remove BUG() to aviod machine dead Xianting Tian
2021-05-18 9:54 ` Michael S. Tsirkin
2021-05-18 9:54 ` Michael S. Tsirkin
2021-05-19 14:18 ` Xianting Tian
2021-05-25 6:19 ` Jason Wang
2021-05-25 6:19 ` Jason Wang
2021-06-02 5:59 ` Leon Romanovsky [this message]
2021-06-02 5:59 ` Leon Romanovsky
2021-06-02 7:14 ` Jason Wang
2021-06-02 7:14 ` Jason Wang
2021-06-02 12:54 ` Leon Romanovsky
2021-06-02 12:54 ` Leon Romanovsky
2021-05-20 7:35 ` Stefano Garzarella
2021-05-20 7:35 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLcePtKhnt9gXq8E@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xianting.tian@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.