From: Andrew Lunn <andrew@lunn.ch>
To: 周琰杰 <zhouyanjie@wanyeetech.com>
Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
sihui.liu@ingenic.com, jun.jiang@ingenic.com,
sernia.zhou@foxmail.com, paul@crapouillou.net
Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support.
Date: Sun, 13 Jun 2021 18:31:36 +0200 [thread overview]
Message-ID: <YMYy6JMSHm1Cqdt2@lunn.ch> (raw)
In-Reply-To: <20210613163452.1f01d418@zhouyanjie-virtual-machine>
On Sun, Jun 13, 2021 at 04:34:52PM +0800, 周琰杰 wrote:
> 于 Thu, 10 Jun 2021 16:57:29 +0200
> Andrew Lunn <andrew@lunn.ch> 写道:
>
> > > Here is Ingenic's reply, the time length corresponding to a unit is
> > > 19.5ps (19500fs).
> >
> > Sometimes, there is a negative offset in the delays. So a delay value
> > of 0 written to the register actually means -200ps or something.
>
> Ah, perhaps this explains why we still need to add fine-tuning
> parameter in rgmii-id and rgmii-txid modes to ensure that the network
> works properly.
Please try to find this out. rgmii means no delay. If the hardware is
doing -500pS by default, you need to take this into account, and add
the 500pS back on.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: 周琰杰 <zhouyanjie@wanyeetech.com>
Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
sihui.liu@ingenic.com, jun.jiang@ingenic.com,
sernia.zhou@foxmail.com, paul@crapouillou.net
Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support.
Date: Sun, 13 Jun 2021 18:31:36 +0200 [thread overview]
Message-ID: <YMYy6JMSHm1Cqdt2@lunn.ch> (raw)
In-Reply-To: <20210613163452.1f01d418@zhouyanjie-virtual-machine>
On Sun, Jun 13, 2021 at 04:34:52PM +0800, 周琰杰 wrote:
> 于 Thu, 10 Jun 2021 16:57:29 +0200
> Andrew Lunn <andrew@lunn.ch> 写道:
>
> > > Here is Ingenic's reply, the time length corresponding to a unit is
> > > 19.5ps (19500fs).
> >
> > Sometimes, there is a negative offset in the delays. So a delay value
> > of 0 written to the register actually means -200ps or something.
>
> Ah, perhaps this explains why we still need to add fine-tuning
> parameter in rgmii-id and rgmii-txid modes to ensure that the network
> works properly.
Please try to find this out. rgmii means no delay. If the hardware is
doing -500pS by default, you need to take this into account, and add
the 500pS back on.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-13 16:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 17:35 [PATCH v2 0/2] Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-09 17:35 ` 周琰杰 (Zhou Yanjie)
2021-06-09 17:35 ` [PATCH v2 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-06-09 17:35 ` 周琰杰 (Zhou Yanjie)
2021-06-09 17:35 ` [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-09 17:35 ` 周琰杰 (Zhou Yanjie)
2021-06-10 3:19 ` Andrew Lunn
2021-06-10 3:19 ` Andrew Lunn
2021-06-10 8:00 ` Zhou Yanjie
2021-06-10 8:00 ` Zhou Yanjie
2021-06-10 12:15 ` Andrew Lunn
2021-06-10 12:15 ` Andrew Lunn
[not found] ` <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com>
2021-06-10 14:42 ` Andrew Lunn
2021-06-10 14:42 ` Andrew Lunn
2021-06-13 8:26 ` 周琰杰
2021-06-13 8:26 ` 周琰杰
[not found] ` <12f35415-532e-5514-bc97-683fb9655091@wanyeetech.com>
2021-06-10 14:57 ` Andrew Lunn
2021-06-10 14:57 ` Andrew Lunn
2021-06-13 8:34 ` 周琰杰
2021-06-13 8:34 ` 周琰杰
2021-06-13 16:31 ` Andrew Lunn [this message]
2021-06-13 16:31 ` Andrew Lunn
2021-06-14 15:57 ` 周琰杰
2021-06-14 15:57 ` 周琰杰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMYy6JMSHm1Cqdt2@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=aric.pzqi@ingenic.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=joabreu@synopsys.com \
--cc=jun.jiang@ingenic.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=peppe.cavallaro@st.com \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=sihui.liu@ingenic.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.