* [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable
@ 2021-07-05 8:25 Thomas Huth
2021-07-05 8:35 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Huth @ 2021-07-05 8:25 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini; +Cc: qemu-trivial, Richard Zak, Eric Blake
The wrapper should not be needed here (it's not the shebang line of
a shell script), and it is causing trouble on Haiku where "env"
resides in a different directory.
Reported-by: Richard Zak <richard.j.zak@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 30f19d33bb..6c36330eef 100644
--- a/Makefile
+++ b/Makefile
@@ -14,7 +14,7 @@ SRC_PATH=.
# we have explicit rules for everything
MAKEFLAGS += -rR
-SHELL = /usr/bin/env bash -o pipefail
+SHELL = bash -o pipefail
# Usage: $(call quiet-command,command and args,"NAME","args to print")
# This will run "command and args", and either:
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable
2021-07-05 8:25 [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable Thomas Huth
@ 2021-07-05 8:35 ` Daniel P. Berrangé
2021-07-05 8:46 ` Philippe Mathieu-Daudé
2021-07-05 16:58 ` Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2021-07-05 8:35 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Paolo Bonzini, qemu-trivial, Richard Zak, Eric Blake
On Mon, Jul 05, 2021 at 10:25:42AM +0200, Thomas Huth wrote:
> The wrapper should not be needed here (it's not the shebang line of
> a shell script), and it is causing trouble on Haiku where "env"
> resides in a different directory.
>
> Reported-by: Richard Zak <richard.j.zak@gmail.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable
@ 2021-07-05 8:35 ` Daniel P. Berrangé
0 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2021-07-05 8:35 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-trivial, Paolo Bonzini, Eric Blake, qemu-devel, Richard Zak
On Mon, Jul 05, 2021 at 10:25:42AM +0200, Thomas Huth wrote:
> The wrapper should not be needed here (it's not the shebang line of
> a shell script), and it is causing trouble on Haiku where "env"
> resides in a different directory.
>
> Reported-by: Richard Zak <richard.j.zak@gmail.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable
2021-07-05 8:25 [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable Thomas Huth
2021-07-05 8:35 ` Daniel P. Berrangé
@ 2021-07-05 8:46 ` Philippe Mathieu-Daudé
2021-07-05 16:58 ` Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-05 8:46 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Paolo Bonzini
Cc: qemu-trivial, Richard Zak, Eric Blake
On 7/5/21 10:25 AM, Thomas Huth wrote:
> The wrapper should not be needed here (it's not the shebang line of
> a shell script), and it is causing trouble on Haiku where "env"
> resides in a different directory.
>
> Reported-by: Richard Zak <richard.j.zak@gmail.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable
2021-07-05 8:25 [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable Thomas Huth
2021-07-05 8:35 ` Daniel P. Berrangé
2021-07-05 8:46 ` Philippe Mathieu-Daudé
@ 2021-07-05 16:58 ` Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2021-07-05 16:58 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial, Richard Zak, Eric Blake
On 05/07/21 10:25, Thomas Huth wrote:
> The wrapper should not be needed here (it's not the shebang line of
> a shell script), and it is causing trouble on Haiku where "env"
> resides in a different directory.
>
> Reported-by: Richard Zak <richard.j.zak@gmail.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 30f19d33bb..6c36330eef 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -14,7 +14,7 @@ SRC_PATH=.
> # we have explicit rules for everything
> MAKEFLAGS += -rR
>
> -SHELL = /usr/bin/env bash -o pipefail
> +SHELL = bash -o pipefail
>
> # Usage: $(call quiet-command,command and args,"NAME","args to print")
> # This will run "command and args", and either:
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-05 16:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-05 8:25 [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable Thomas Huth
2021-07-05 8:35 ` Daniel P. Berrangé
2021-07-05 8:35 ` Daniel P. Berrangé
2021-07-05 8:46 ` Philippe Mathieu-Daudé
2021-07-05 16:58 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.