All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [bug report] iommu_dma_unmap_sg() is very slow then running IO from remote numa node
Date: Thu, 22 Jul 2021 15:58:04 +0800	[thread overview]
Message-ID: <YPklDMng1hL3bQ+v@T590> (raw)
In-Reply-To: <a2650064-41cf-cb62-7ab4-d14ef1856966@huawei.com>

On Wed, Jul 21, 2021 at 12:07:22PM +0100, John Garry wrote:
> On 21/07/2021 10:59, Ming Lei wrote:
> > > I have now removed that from the tree, so please re-pull.
> > Now the kernel can be built successfully, but not see obvious improvement
> > on the reported issue:
> > 
> > [root@ampere-mtjade-04 ~]# uname -a
> > Linux ampere-mtjade-04.khw4.lab.eng.bos.redhat.com 5.14.0-rc2_smmu_fix+ #2 SMP Wed Jul 21 05:49:03 EDT 2021 aarch64 aarch64 aarch64 GNU/Linux
> > 
> > [root@ampere-mtjade-04 ~]# taskset -c 0 ~/git/tools/test/nvme/io_uring 10 1 /dev/nvme1n1 4k
> > + fio --bs=4k --ioengine=io_uring --fixedbufs --registerfiles --hipri --iodepth=64 --iodepth_batch_submit=16 --iodepth_batch_complete_min=16 --filename=/dev/nvme1n1 --direct=1 --runtime=10 --numjobs=1 --rw=randread --name=test --group_reporting
> > test: (g=0): rw=randread, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=io_uring, iodepth=64
> > fio-3.27
> > Starting 1 process
> > Jobs: 1 (f=1): [r(1)][100.0%][r=1503MiB/s][r=385k IOPS][eta 00m:00s]
> > test: (groupid=0, jobs=1): err= 0: pid=3143: Wed Jul 21 05:58:14 2021
> >    read: IOPS=384k, BW=1501MiB/s (1573MB/s)(14.7GiB/10001msec)
> 
> I am not sure what baseline you used previously, but you were getting 327K
> then, so at least this would be an improvement.

Looks the improvement isn't from your patches, please see the test result on
v5.14-rc2:

[root@ampere-mtjade-04 ~]# uname -a
Linux ampere-mtjade-04.khw4.lab.eng.bos.redhat.com 5.14.0-rc2_linus #3 SMP Thu Jul 22 03:41:24 EDT 2021 aarch64 aarch64 aarch64 GNU/Linux
[root@ampere-mtjade-04 ~]# taskset -c 0 ~/git/tools/test/nvme/io_uring 20 1 /dev/nvme1n1 4k
+ fio --bs=4k --ioengine=io_uring --fixedbufs --registerfiles --hipri --iodepth=64 --iodepth_batch_submit=16 --iodepth_batch_complete_min=16 --filename=/dev/nvme1n1 --direct=1 --runtime=20 --numjobs=1 --rw=randread --name=test --group_reporting
test: (g=0): rw=randread, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=io_uring, iodepth=64
fio-3.27
Starting 1 process
Jobs: 1 (f=1): [r(1)][100.0%][r=1489MiB/s][r=381k IOPS][eta 00m:00s]
test: (groupid=0, jobs=1): err= 0: pid=3099: Thu Jul 22 03:53:04 2021
  read: IOPS=381k, BW=1487MiB/s (1559MB/s)(29.0GiB/20001msec)


thanks, 
Ming

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
	iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [bug report] iommu_dma_unmap_sg() is very slow then running IO from remote numa node
Date: Thu, 22 Jul 2021 15:58:04 +0800	[thread overview]
Message-ID: <YPklDMng1hL3bQ+v@T590> (raw)
In-Reply-To: <a2650064-41cf-cb62-7ab4-d14ef1856966@huawei.com>

On Wed, Jul 21, 2021 at 12:07:22PM +0100, John Garry wrote:
> On 21/07/2021 10:59, Ming Lei wrote:
> > > I have now removed that from the tree, so please re-pull.
> > Now the kernel can be built successfully, but not see obvious improvement
> > on the reported issue:
> > 
> > [root@ampere-mtjade-04 ~]# uname -a
> > Linux ampere-mtjade-04.khw4.lab.eng.bos.redhat.com 5.14.0-rc2_smmu_fix+ #2 SMP Wed Jul 21 05:49:03 EDT 2021 aarch64 aarch64 aarch64 GNU/Linux
> > 
> > [root@ampere-mtjade-04 ~]# taskset -c 0 ~/git/tools/test/nvme/io_uring 10 1 /dev/nvme1n1 4k
> > + fio --bs=4k --ioengine=io_uring --fixedbufs --registerfiles --hipri --iodepth=64 --iodepth_batch_submit=16 --iodepth_batch_complete_min=16 --filename=/dev/nvme1n1 --direct=1 --runtime=10 --numjobs=1 --rw=randread --name=test --group_reporting
> > test: (g=0): rw=randread, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=io_uring, iodepth=64
> > fio-3.27
> > Starting 1 process
> > Jobs: 1 (f=1): [r(1)][100.0%][r=1503MiB/s][r=385k IOPS][eta 00m:00s]
> > test: (groupid=0, jobs=1): err= 0: pid=3143: Wed Jul 21 05:58:14 2021
> >    read: IOPS=384k, BW=1501MiB/s (1573MB/s)(14.7GiB/10001msec)
> 
> I am not sure what baseline you used previously, but you were getting 327K
> then, so at least this would be an improvement.

Looks the improvement isn't from your patches, please see the test result on
v5.14-rc2:

[root@ampere-mtjade-04 ~]# uname -a
Linux ampere-mtjade-04.khw4.lab.eng.bos.redhat.com 5.14.0-rc2_linus #3 SMP Thu Jul 22 03:41:24 EDT 2021 aarch64 aarch64 aarch64 GNU/Linux
[root@ampere-mtjade-04 ~]# taskset -c 0 ~/git/tools/test/nvme/io_uring 20 1 /dev/nvme1n1 4k
+ fio --bs=4k --ioengine=io_uring --fixedbufs --registerfiles --hipri --iodepth=64 --iodepth_batch_submit=16 --iodepth_batch_complete_min=16 --filename=/dev/nvme1n1 --direct=1 --runtime=20 --numjobs=1 --rw=randread --name=test --group_reporting
test: (g=0): rw=randread, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=io_uring, iodepth=64
fio-3.27
Starting 1 process
Jobs: 1 (f=1): [r(1)][100.0%][r=1489MiB/s][r=381k IOPS][eta 00m:00s]
test: (groupid=0, jobs=1): err= 0: pid=3099: Thu Jul 22 03:53:04 2021
  read: IOPS=381k, BW=1487MiB/s (1559MB/s)(29.0GiB/20001msec)


thanks, 
Ming


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
	iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [bug report] iommu_dma_unmap_sg() is very slow then running IO from remote numa node
Date: Thu, 22 Jul 2021 15:58:04 +0800	[thread overview]
Message-ID: <YPklDMng1hL3bQ+v@T590> (raw)
In-Reply-To: <a2650064-41cf-cb62-7ab4-d14ef1856966@huawei.com>

On Wed, Jul 21, 2021 at 12:07:22PM +0100, John Garry wrote:
> On 21/07/2021 10:59, Ming Lei wrote:
> > > I have now removed that from the tree, so please re-pull.
> > Now the kernel can be built successfully, but not see obvious improvement
> > on the reported issue:
> > 
> > [root@ampere-mtjade-04 ~]# uname -a
> > Linux ampere-mtjade-04.khw4.lab.eng.bos.redhat.com 5.14.0-rc2_smmu_fix+ #2 SMP Wed Jul 21 05:49:03 EDT 2021 aarch64 aarch64 aarch64 GNU/Linux
> > 
> > [root@ampere-mtjade-04 ~]# taskset -c 0 ~/git/tools/test/nvme/io_uring 10 1 /dev/nvme1n1 4k
> > + fio --bs=4k --ioengine=io_uring --fixedbufs --registerfiles --hipri --iodepth=64 --iodepth_batch_submit=16 --iodepth_batch_complete_min=16 --filename=/dev/nvme1n1 --direct=1 --runtime=10 --numjobs=1 --rw=randread --name=test --group_reporting
> > test: (g=0): rw=randread, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=io_uring, iodepth=64
> > fio-3.27
> > Starting 1 process
> > Jobs: 1 (f=1): [r(1)][100.0%][r=1503MiB/s][r=385k IOPS][eta 00m:00s]
> > test: (groupid=0, jobs=1): err= 0: pid=3143: Wed Jul 21 05:58:14 2021
> >    read: IOPS=384k, BW=1501MiB/s (1573MB/s)(14.7GiB/10001msec)
> 
> I am not sure what baseline you used previously, but you were getting 327K
> then, so at least this would be an improvement.

Looks the improvement isn't from your patches, please see the test result on
v5.14-rc2:

[root@ampere-mtjade-04 ~]# uname -a
Linux ampere-mtjade-04.khw4.lab.eng.bos.redhat.com 5.14.0-rc2_linus #3 SMP Thu Jul 22 03:41:24 EDT 2021 aarch64 aarch64 aarch64 GNU/Linux
[root@ampere-mtjade-04 ~]# taskset -c 0 ~/git/tools/test/nvme/io_uring 20 1 /dev/nvme1n1 4k
+ fio --bs=4k --ioengine=io_uring --fixedbufs --registerfiles --hipri --iodepth=64 --iodepth_batch_submit=16 --iodepth_batch_complete_min=16 --filename=/dev/nvme1n1 --direct=1 --runtime=20 --numjobs=1 --rw=randread --name=test --group_reporting
test: (g=0): rw=randread, bs=(R) 4096B-4096B, (W) 4096B-4096B, (T) 4096B-4096B, ioengine=io_uring, iodepth=64
fio-3.27
Starting 1 process
Jobs: 1 (f=1): [r(1)][100.0%][r=1489MiB/s][r=381k IOPS][eta 00m:00s]
test: (groupid=0, jobs=1): err= 0: pid=3099: Thu Jul 22 03:53:04 2021
  read: IOPS=381k, BW=1487MiB/s (1559MB/s)(29.0GiB/20001msec)


thanks, 
Ming


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-07-22  7:58 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  8:38 [bug report] iommu_dma_unmap_sg() is very slow then running IO from remote numa node Ming Lei
2021-07-09  8:38 ` Ming Lei
2021-07-09  8:38 ` Ming Lei
2021-07-09 10:16 ` Russell King (Oracle)
2021-07-09 10:16   ` Russell King (Oracle)
2021-07-09 10:16   ` Russell King (Oracle)
2021-07-09 14:21   ` Ming Lei
2021-07-09 14:21     ` Ming Lei
2021-07-09 14:21     ` Ming Lei
2021-07-09 10:26 ` Robin Murphy
2021-07-09 10:26   ` Robin Murphy
2021-07-09 10:26   ` Robin Murphy
2021-07-09 11:04   ` John Garry
2021-07-09 11:04     ` John Garry
2021-07-09 11:04     ` John Garry
2021-07-09 12:34     ` Robin Murphy
2021-07-09 12:34       ` Robin Murphy
2021-07-09 12:34       ` Robin Murphy
2021-07-09 14:24   ` Ming Lei
2021-07-09 14:24     ` Ming Lei
2021-07-09 14:24     ` Ming Lei
2021-07-19 16:14     ` John Garry
2021-07-19 16:14       ` John Garry
2021-07-19 16:14       ` John Garry
2021-07-21  1:40       ` Ming Lei
2021-07-21  1:40         ` Ming Lei
2021-07-21  1:40         ` Ming Lei
2021-07-21  9:23         ` John Garry
2021-07-21  9:23           ` John Garry
2021-07-21  9:23           ` John Garry
2021-07-21  9:59           ` Ming Lei
2021-07-21  9:59             ` Ming Lei
2021-07-21  9:59             ` Ming Lei
2021-07-21 11:07             ` John Garry
2021-07-21 11:07               ` John Garry
2021-07-21 11:07               ` John Garry
2021-07-21 11:58               ` Ming Lei
2021-07-21 11:58                 ` Ming Lei
2021-07-21 11:58                 ` Ming Lei
2021-07-22  7:58               ` Ming Lei [this message]
2021-07-22  7:58                 ` Ming Lei
2021-07-22  7:58                 ` Ming Lei
2021-07-22 10:05                 ` John Garry
2021-07-22 10:05                   ` John Garry
2021-07-22 10:05                   ` John Garry
2021-07-22 10:19                   ` Ming Lei
2021-07-22 10:19                     ` Ming Lei
2021-07-22 10:19                     ` Ming Lei
2021-07-22 11:12                     ` John Garry
2021-07-22 11:12                       ` John Garry
2021-07-22 11:12                       ` John Garry
2021-07-22 12:53                       ` Marc Zyngier
2021-07-22 12:53                         ` Marc Zyngier
2021-07-22 12:53                         ` Marc Zyngier
2021-07-22 13:54                         ` John Garry
2021-07-22 13:54                           ` John Garry
2021-07-22 13:54                           ` John Garry
2021-07-22 15:54                       ` Ming Lei
2021-07-22 15:54                         ` Ming Lei
2021-07-22 15:54                         ` Ming Lei
2021-07-22 17:40                         ` Robin Murphy
2021-07-22 17:40                           ` Robin Murphy
2021-07-22 17:40                           ` Robin Murphy
2021-07-23 10:21                           ` Ming Lei
2021-07-23 10:21                             ` Ming Lei
2021-07-23 10:21                             ` Ming Lei
2021-07-26  7:51                             ` John Garry
2021-07-26  7:51                               ` John Garry
2021-07-26  7:51                               ` John Garry
2021-07-28  1:32                               ` Ming Lei
2021-07-28  1:32                                 ` Ming Lei
2021-07-28  1:32                                 ` Ming Lei
2021-07-28 10:38                                 ` John Garry
2021-07-28 10:38                                   ` John Garry
2021-07-28 10:38                                   ` John Garry
2021-07-28 15:17                                   ` Ming Lei
2021-07-28 15:17                                     ` Ming Lei
2021-07-28 15:17                                     ` Ming Lei
2021-07-28 15:39                                     ` Robin Murphy
2021-07-28 15:39                                       ` Robin Murphy
2021-07-28 15:39                                       ` Robin Murphy
2021-08-10  9:36                                     ` John Garry
2021-08-10  9:36                                       ` John Garry
2021-08-10  9:36                                       ` John Garry
2021-08-10 10:35                                       ` Ming Lei
2021-08-10 10:35                                         ` Ming Lei
2021-08-10 10:35                                         ` Ming Lei
2021-07-27 17:08                             ` Robin Murphy
2021-07-27 17:08                               ` Robin Murphy
2021-07-27 17:08                               ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPklDMng1hL3bQ+v@T590 \
    --to=ming.lei@redhat.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=john.garry@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.