From: Greg KH <gregkh@linuxfoundation.org>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: axboe@kernel.dk, kernelnewbies@kernelnewbies.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
pavel@ucw.cz, linux-leds@vger.kernel.org
Subject: Re: [RFC PATCH 4/8] block: Add block class attributes to manage LED trigger list
Date: Thu, 29 Jul 2021 07:54:23 +0200 [thread overview]
Message-ID: <YQJCj/LjjCqb93AS@kroah.com> (raw)
In-Reply-To: <20210729015344.3366750-5-arequipeno@gmail.com>
On Wed, Jul 28, 2021 at 08:53:40PM -0500, Ian Pilcher wrote:
> * New class attributes - /sys/class/block/led_trigger_{new,list,del}
>
> * Add init function - blk_ledtrig_init() - to create the attributes
> in sysfs. Call blk_ledtrig_init() from genhd_device_init() (in
> block/genhd.c).
>
> * New file - block/blk-ledtrig.h
That is an odd way to write a changelog, please read the documentation
file about how to write a good changelog.
thanks,
greg k-h
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org,
axboe@kernel.dk, linux-kernel@vger.kernel.org, pavel@ucw.cz,
kernelnewbies@kernelnewbies.org
Subject: Re: [RFC PATCH 4/8] block: Add block class attributes to manage LED trigger list
Date: Thu, 29 Jul 2021 07:54:23 +0200 [thread overview]
Message-ID: <YQJCj/LjjCqb93AS@kroah.com> (raw)
In-Reply-To: <20210729015344.3366750-5-arequipeno@gmail.com>
On Wed, Jul 28, 2021 at 08:53:40PM -0500, Ian Pilcher wrote:
> * New class attributes - /sys/class/block/led_trigger_{new,list,del}
>
> * Add init function - blk_ledtrig_init() - to create the attributes
> in sysfs. Call blk_ledtrig_init() from genhd_device_init() (in
> block/genhd.c).
>
> * New file - block/blk-ledtrig.h
That is an odd way to write a changelog, please read the documentation
file about how to write a good changelog.
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-29 6:14 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 1:53 [RFC PATCH 0/8] Add configurable block device LED triggers Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 1/8] docs: Add block device LED trigger documentation Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 3:09 ` Valdis Klētnieks
2021-07-29 3:09 ` Valdis Klētnieks
2021-07-29 15:52 ` Ian Pilcher
2021-07-29 15:52 ` Ian Pilcher
2021-07-30 5:22 ` Greg KH
2021-07-30 5:22 ` Greg KH
2021-07-29 5:53 ` Greg KH
2021-07-29 5:53 ` Greg KH
2021-07-29 11:59 ` Marek Behún
2021-07-29 11:59 ` Marek Behún
2021-07-29 18:03 ` Ian Pilcher
2021-07-29 18:03 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 2/8] block: Add block device LED trigger list Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 3:14 ` Valdis Klētnieks
2021-07-29 3:14 ` Valdis Klētnieks
2021-07-29 15:55 ` Ian Pilcher
2021-07-29 15:55 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 3/8] block: Add kernel APIs to create & delete block device LED triggers Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 3:45 ` Valdis Klētnieks
2021-07-29 3:45 ` Valdis Klētnieks
2021-07-29 16:16 ` Ian Pilcher
2021-07-29 16:16 ` Ian Pilcher
2021-07-29 5:52 ` Greg KH
2021-07-29 5:52 ` Greg KH
2021-07-29 1:53 ` [RFC PATCH 4/8] block: Add block class attributes to manage LED trigger list Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 5:54 ` Greg KH [this message]
2021-07-29 5:54 ` Greg KH
2021-07-29 1:53 ` [RFC PATCH 5/8] block: Add block device LED trigger info to struct genhd Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 6/8] block: Add kernel APIs to set & clear per-block device LED triggers Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 7/8] block: Add block device attributes to set & clear " Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 8/8] block: Blink device LED when request is sent to low-level driver Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 8:54 ` [RFC PATCH 0/8] Add configurable block device LED triggers Pavel Machek
2021-07-29 8:54 ` Pavel Machek
2021-07-29 17:03 ` Ian Pilcher
2021-07-29 17:03 ` Ian Pilcher
2021-07-29 18:35 ` Pavel Machek
2021-07-29 18:35 ` Pavel Machek
2021-07-29 19:14 ` Ian Pilcher
2021-07-29 19:14 ` Ian Pilcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQJCj/LjjCqb93AS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arequipeno@gmail.com \
--cc=axboe@kernel.dk \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.