From: Ian Pilcher <arequipeno@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
kernelnewbies@kernelnewbies.org
Subject: Re: [RFC PATCH 0/8] Add configurable block device LED triggers
Date: Thu, 29 Jul 2021 12:03:04 -0500 [thread overview]
Message-ID: <b108799e-24a2-d5ec-e18e-b7ae8bded085@gmail.com> (raw)
In-Reply-To: <20210729085413.GA16945@amd>
On 7/29/21 3:54 AM, Pavel Machek wrote:
> We normally have a trigger ("block device activity") which can then
> expose parameters ("I watch for read" and "I monitor sda1").
>
> Is there a reason normal solution can not be used?
This big difference is that this allows different devices to drive
different LEDs. For example, my NAS has 5 drive bays, each of which
has its own activity LED. With these patches, I can create a
separate trigger for each of those LEDs and associate the drive in each
bay with the correct LED:
sdb --> trigger1 --> LED1
⋮ ⋮ ⋮
sdf --> trigger5 --> LED5
(sda is the SATA DOM boot drive.)
Note that this also supports associating multiple devices with a single
trigger, so it can be used for more complicated schemes. For example,
if my NAS had an additional LED and an optical drive, I could do this:
sr0 --+
|
+--> trigger0 --> LED0
|
sda --+
sdb -----> trigger1 --> LED1
⋮ ⋮ ⋮
sdf -----> trigger5 --> LED5
As far as I know, the current triggers (disk-activity, disk-read,
disk-write, and ide-disk) don't support this sort of arbitrary
device-trigger association.
This patch set also support triggering LEDs from pretty much any block
device (virtual as well as physical), not just ATA devices, although
that's just a matter of the place from which the trigger is "fired".
I hope this explains things.
Thanks!
--
========================================================================
In Soviet Russia, Google searches you!
========================================================================
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
WARNING: multiple messages have this Message-ID (diff)
From: Ian Pilcher <arequipeno@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org,
axboe@kernel.dk, linux-kernel@vger.kernel.org,
kernelnewbies@kernelnewbies.org
Subject: Re: [RFC PATCH 0/8] Add configurable block device LED triggers
Date: Thu, 29 Jul 2021 12:03:04 -0500 [thread overview]
Message-ID: <b108799e-24a2-d5ec-e18e-b7ae8bded085@gmail.com> (raw)
In-Reply-To: <20210729085413.GA16945@amd>
On 7/29/21 3:54 AM, Pavel Machek wrote:
> We normally have a trigger ("block device activity") which can then
> expose parameters ("I watch for read" and "I monitor sda1").
>
> Is there a reason normal solution can not be used?
This big difference is that this allows different devices to drive
different LEDs. For example, my NAS has 5 drive bays, each of which
has its own activity LED. With these patches, I can create a
separate trigger for each of those LEDs and associate the drive in each
bay with the correct LED:
sdb --> trigger1 --> LED1
⋮ ⋮ ⋮
sdf --> trigger5 --> LED5
(sda is the SATA DOM boot drive.)
Note that this also supports associating multiple devices with a single
trigger, so it can be used for more complicated schemes. For example,
if my NAS had an additional LED and an optical drive, I could do this:
sr0 --+
|
+--> trigger0 --> LED0
|
sda --+
sdb -----> trigger1 --> LED1
⋮ ⋮ ⋮
sdf -----> trigger5 --> LED5
As far as I know, the current triggers (disk-activity, disk-read,
disk-write, and ide-disk) don't support this sort of arbitrary
device-trigger association.
This patch set also support triggering LEDs from pretty much any block
device (virtual as well as physical), not just ATA devices, although
that's just a matter of the place from which the trigger is "fired".
I hope this explains things.
Thanks!
--
========================================================================
In Soviet Russia, Google searches you!
========================================================================
next prev parent reply other threads:[~2021-07-29 17:03 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 1:53 [RFC PATCH 0/8] Add configurable block device LED triggers Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 1/8] docs: Add block device LED trigger documentation Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 3:09 ` Valdis Klētnieks
2021-07-29 3:09 ` Valdis Klētnieks
2021-07-29 15:52 ` Ian Pilcher
2021-07-29 15:52 ` Ian Pilcher
2021-07-30 5:22 ` Greg KH
2021-07-30 5:22 ` Greg KH
2021-07-29 5:53 ` Greg KH
2021-07-29 5:53 ` Greg KH
2021-07-29 11:59 ` Marek Behún
2021-07-29 11:59 ` Marek Behún
2021-07-29 18:03 ` Ian Pilcher
2021-07-29 18:03 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 2/8] block: Add block device LED trigger list Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 3:14 ` Valdis Klētnieks
2021-07-29 3:14 ` Valdis Klētnieks
2021-07-29 15:55 ` Ian Pilcher
2021-07-29 15:55 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 3/8] block: Add kernel APIs to create & delete block device LED triggers Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 3:45 ` Valdis Klētnieks
2021-07-29 3:45 ` Valdis Klētnieks
2021-07-29 16:16 ` Ian Pilcher
2021-07-29 16:16 ` Ian Pilcher
2021-07-29 5:52 ` Greg KH
2021-07-29 5:52 ` Greg KH
2021-07-29 1:53 ` [RFC PATCH 4/8] block: Add block class attributes to manage LED trigger list Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 5:54 ` Greg KH
2021-07-29 5:54 ` Greg KH
2021-07-29 1:53 ` [RFC PATCH 5/8] block: Add block device LED trigger info to struct genhd Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 6/8] block: Add kernel APIs to set & clear per-block device LED triggers Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 7/8] block: Add block device attributes to set & clear " Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 1:53 ` [RFC PATCH 8/8] block: Blink device LED when request is sent to low-level driver Ian Pilcher
2021-07-29 1:53 ` Ian Pilcher
2021-07-29 8:54 ` [RFC PATCH 0/8] Add configurable block device LED triggers Pavel Machek
2021-07-29 8:54 ` Pavel Machek
2021-07-29 17:03 ` Ian Pilcher [this message]
2021-07-29 17:03 ` Ian Pilcher
2021-07-29 18:35 ` Pavel Machek
2021-07-29 18:35 ` Pavel Machek
2021-07-29 19:14 ` Ian Pilcher
2021-07-29 19:14 ` Ian Pilcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b108799e-24a2-d5ec-e18e-b7ae8bded085@gmail.com \
--to=arequipeno@gmail.com \
--cc=axboe@kernel.dk \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.