From: Sam Ravnborg <sam@ravnborg.org>
To: Nikola Pavlica <pavlica.nikola@gmail.com>
Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com,
airlied@linux.ie, daniel@ffwll.ch,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: display: simple: Add Vivax TPC-9150 panel
Date: Wed, 18 Aug 2021 20:24:52 +0200 [thread overview]
Message-ID: <YR1QdDgB0H+8J318@ravnborg.org> (raw)
In-Reply-To: <20210818144648.72665-2-pavlica.nikola@gmail.com>
Hi Nikola,
On Wed, Aug 18, 2021 at 04:46:47PM +0200, Nikola Pavlica wrote:
> This tablet display is unique and hence must be added to documentation.
> Unfortunately, it's real make and number is not known due to obscure and
> missing documentation and lack of writing on the display assembly
> itself.
>
> So the natural alternative that came to mind is to name the panel after
> the device that contained it (an Android tablet). Hopefully that isn't
> an issue.
>
> I can confirm that the parameters that I've obtained are correct since
> they came from a dump of the original Android OS.
>
> Signed-off-by: Nikola Pavlica <pavlica.nikola@gmail.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I like this to be *before* the patch to panel-simple.c, as we cannot
apply the panel-simple.c patch before the compatible is documented.
Or we can apply it, but checkpatch will complain and that will stop me
applying.
So in other words - reverse the order of the patches.
Sam
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 62b0d54d87b7..d0efefa5a820 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -285,6 +285,8 @@ properties:
> - urt,umsh-8596md-11t
> - urt,umsh-8596md-19t
> - urt,umsh-8596md-20t
> + # Vivax TPC-9150 tablet 9.0" WSVGA TFT LCD panel
> + - vivax,tpc9150-panel
> # VXT 800x480 color TFT LCD panel
> - vxt,vl050-8048nt-c01
> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> --
> 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Nikola Pavlica <pavlica.nikola@gmail.com>
Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com,
airlied@linux.ie, daniel@ffwll.ch,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: display: simple: Add Vivax TPC-9150 panel
Date: Wed, 18 Aug 2021 20:24:52 +0200 [thread overview]
Message-ID: <YR1QdDgB0H+8J318@ravnborg.org> (raw)
In-Reply-To: <20210818144648.72665-2-pavlica.nikola@gmail.com>
Hi Nikola,
On Wed, Aug 18, 2021 at 04:46:47PM +0200, Nikola Pavlica wrote:
> This tablet display is unique and hence must be added to documentation.
> Unfortunately, it's real make and number is not known due to obscure and
> missing documentation and lack of writing on the display assembly
> itself.
>
> So the natural alternative that came to mind is to name the panel after
> the device that contained it (an Android tablet). Hopefully that isn't
> an issue.
>
> I can confirm that the parameters that I've obtained are correct since
> they came from a dump of the original Android OS.
>
> Signed-off-by: Nikola Pavlica <pavlica.nikola@gmail.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I like this to be *before* the patch to panel-simple.c, as we cannot
apply the panel-simple.c patch before the compatible is documented.
Or we can apply it, but checkpatch will complain and that will stop me
applying.
So in other words - reverse the order of the patches.
Sam
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 62b0d54d87b7..d0efefa5a820 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -285,6 +285,8 @@ properties:
> - urt,umsh-8596md-11t
> - urt,umsh-8596md-19t
> - urt,umsh-8596md-20t
> + # Vivax TPC-9150 tablet 9.0" WSVGA TFT LCD panel
> + - vivax,tpc9150-panel
> # VXT 800x480 color TFT LCD panel
> - vxt,vl050-8048nt-c01
> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> --
> 2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-18 18:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 14:46 [PATCH 1/3] drm/panel-simple: Add Vivax TPC-9150 panel v4 Nikola Pavlica
2021-08-18 14:46 ` Nikola Pavlica
2021-08-18 14:46 ` [PATCH 2/3] dt-bindings: display: simple: Add Vivax TPC-9150 panel Nikola Pavlica
2021-08-18 14:46 ` Nikola Pavlica
2021-08-18 18:24 ` Sam Ravnborg [this message]
2021-08-18 18:24 ` Sam Ravnborg
2021-08-18 14:46 ` [PATCH 3/3] dt-bindings: add vendor prefix for Vivax Nikola Pavlica
2021-08-18 14:46 ` Nikola Pavlica
2021-08-18 18:22 ` Sam Ravnborg
2021-08-18 18:22 ` Sam Ravnborg
2021-08-18 18:26 ` Sam Ravnborg
2021-08-18 18:26 ` Sam Ravnborg
2021-08-18 18:21 ` [PATCH 1/3] drm/panel-simple: Add Vivax TPC-9150 panel v4 Sam Ravnborg
2021-08-18 18:21 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR1QdDgB0H+8J318@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=pavlica.nikola@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.