Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters

[Rob Herring <robh@kernel.org>]

On Mon, Aug 09, 2021 at 02:57:33PM +0200, Geert Uytterhoeven wrote:
> Hi Biju,
> 
> On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > The DMAC driver on RZ/G2L expects the slave channel configuration
> > to be passed in dmas property.
> > This patch updates the example node to include the encoded slave
> > channel configuration.
> >
> > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support")
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> > v3->v4:
> >  * Updated bindings as the DMAC driver on RZ/G2L expects the
> >    slave channel configuration to be passed in dmas property.
> 
> Thanks for the update!
> 
> > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > @@ -93,8 +93,8 @@ examples:
> >              clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2";
> >              power-domains = <&cpg>;
> >              resets = <&cpg R9A07G044_SSI0_RST_M2_REG>;
> > -            dmas = <&dmac 0x255>,
> > -                   <&dmac 0x256>;
> > +            dmas = <&dmac 0x2655>,
> > +                   <&dmac 0x2656>;
> >              dma-names = "tx", "rx";
> >              #sound-dai-cells = <0>;
> >      };
> 
> I think it would be good to describe the expected format in the description
> for the dmas property, so the DTS writer knows what the numerical
> values in the example really mean.

Yes, but that's a property of the DMA controller binding, not this one. 
It could vary from chip to chip.

Rob