All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Nikhil Devshatwar <nikhil.nd@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-phy@lists.infradead.org
Subject: Re: [PATCH v4 6/6] phy: dt-bindings: cdns,dphy: add Rx DPHY compatible
Date: Mon, 23 Aug 2021 04:44:54 +0300	[thread overview]
Message-ID: <YSL9lkLB0wKk9sem@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210820190346.18550-7-p.yadav@ti.com>

Hi Pratyush,

Thank you for the patch.

On Sat, Aug 21, 2021 at 12:33:46AM +0530, Pratyush Yadav wrote:
> The DPHY is treated to be in Tx mode by default. Add a new compatible
> for Rx mode DPHYs.
> 
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> 
> ---
> 
> Changes in v4:
> - New in v4.
> 
>  Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> index d5a5e1f0b671..48b6a841152e 100644
> --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> @@ -11,8 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    items:
> +    oneOf:
>        - const: cdns,dphy
> +      - const: cdns,dphy-rx

It's customary to use an enum instead:

  compatibles:
    enum:
      - cdns,dphy
      - cdns,dphy-tx

I don't know if Rob has a preference for consistency (or for any other
reason). In either case,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  
>    reg:
>      maxItems: 1

-- 
Regards,

Laurent Pinchart

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Nikhil Devshatwar <nikhil.nd@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-phy@lists.infradead.org
Subject: Re: [PATCH v4 6/6] phy: dt-bindings: cdns,dphy: add Rx DPHY compatible
Date: Mon, 23 Aug 2021 04:44:54 +0300	[thread overview]
Message-ID: <YSL9lkLB0wKk9sem@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210820190346.18550-7-p.yadav@ti.com>

Hi Pratyush,

Thank you for the patch.

On Sat, Aug 21, 2021 at 12:33:46AM +0530, Pratyush Yadav wrote:
> The DPHY is treated to be in Tx mode by default. Add a new compatible
> for Rx mode DPHYs.
> 
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> 
> ---
> 
> Changes in v4:
> - New in v4.
> 
>  Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> index d5a5e1f0b671..48b6a841152e 100644
> --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> @@ -11,8 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    items:
> +    oneOf:
>        - const: cdns,dphy
> +      - const: cdns,dphy-rx

It's customary to use an enum instead:

  compatibles:
    enum:
      - cdns,dphy
      - cdns,dphy-tx

I don't know if Rob has a preference for consistency (or for any other
reason). In either case,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  
>    reg:
>      maxItems: 1

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2021-08-23  1:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 19:03 [PATCH v4 0/6] Rx mode support for Cadence DPHY Pratyush Yadav
2021-08-20 19:03 ` Pratyush Yadav
2021-08-20 19:03 ` [PATCH v4 1/6] phy: cdns-dphy: Prepare for Rx support Pratyush Yadav
2021-08-20 19:03   ` Pratyush Yadav
2021-08-23  1:25   ` Laurent Pinchart
2021-08-23  1:25     ` Laurent Pinchart
2021-08-26 19:14     ` Pratyush Yadav
2021-08-26 19:14       ` Pratyush Yadav
2021-08-20 19:03 ` [PATCH v4 2/6] phy: cdns-dphy: Add " Pratyush Yadav
2021-08-20 19:03   ` Pratyush Yadav
2021-08-23  1:37   ` Laurent Pinchart
2021-08-23  1:37     ` Laurent Pinchart
2021-08-26 18:49     ` Pratyush Yadav
2021-08-26 18:49       ` Pratyush Yadav
2021-08-26 19:34       ` Laurent Pinchart
2021-08-26 19:34         ` Laurent Pinchart
2021-08-20 19:03 ` [PATCH v4 3/6] phy: dt-bindings: Convert Cadence DPHY binding to YAML Pratyush Yadav
2021-08-20 19:03   ` Pratyush Yadav
2021-08-20 19:03 ` [PATCH v4 4/6] phy: dt-bindings: cdns,dphy: make clocks optional Pratyush Yadav
2021-08-20 19:03   ` Pratyush Yadav
2021-08-23  1:40   ` Laurent Pinchart
2021-08-23  1:40     ` Laurent Pinchart
2021-08-23  8:57     ` Pratyush Yadav
2021-08-23  8:57       ` Pratyush Yadav
2021-08-20 19:03 ` [PATCH v4 5/6] phy: dt-bindings: cdns, dphy: add power-domains property Pratyush Yadav
2021-08-20 19:03   ` [PATCH v4 5/6] phy: dt-bindings: cdns,dphy: " Pratyush Yadav
2021-08-20 19:03 ` [PATCH v4 6/6] phy: dt-bindings: cdns,dphy: add Rx DPHY compatible Pratyush Yadav
2021-08-20 19:03   ` Pratyush Yadav
2021-08-23  1:44   ` Laurent Pinchart [this message]
2021-08-23  1:44     ` Laurent Pinchart
2021-08-23 22:43     ` Rob Herring
2021-08-23 22:43       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSL9lkLB0wKk9sem@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=nikhil.nd@ti.com \
    --cc=p.yadav@ti.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.