From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] getuid: Convert getuid01 and getuid03 to new API
Date: Mon, 6 Sep 2021 17:17:22 +0200 [thread overview]
Message-ID: <YTYxAnd1FDGq/nTW@yuki> (raw)
In-Reply-To: <20210826090511.106853-1-threefifteen.wangkunfeng@huawei.com>
Hi!
Looks good, but there is no value in keeping the getuid01.c because it
tests same assertion that is covered in getuid03.c as well.
So I would keep only getuid01.c and moved the functionality from
getuid03.c there.
--
Cyril Hrubis
chrubis@suse.cz
WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis@suse.cz>
To: Wang Kunfeng <threefifteen.wangkunfeng@huawei.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] getuid: Convert getuid01 and getuid03 to new API
Date: Mon, 6 Sep 2021 17:17:22 +0200 [thread overview]
Message-ID: <YTYxAnd1FDGq/nTW@yuki> (raw)
Message-ID: <20210906151722.YpFEG1CKitZAdGJGbu6GYKQfst1edmofg_-17cz_NSY@z> (raw)
In-Reply-To: <20210826090511.106853-1-threefifteen.wangkunfeng@huawei.com>
Hi!
Looks good, but there is no value in keeping the getuid01.c because it
tests same assertion that is covered in getuid03.c as well.
So I would keep only getuid01.c and moved the functionality from
getuid03.c there.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-06 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 9:05 [LTP] [PATCH] getuid: Convert getuid01 and getuid03 to new API Wang Kunfeng
2021-09-06 15:17 ` Cyril Hrubis [this message]
2021-09-06 15:17 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTYxAnd1FDGq/nTW@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.