From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: Vipin Sharma <vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: brookxu <brookxu.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood
Date: Thu, 9 Sep 2021 20:56:16 +0200 [thread overview]
Message-ID: <YTpY0G3+IJYmGbdd@blackbook> (raw)
In-Reply-To: <CAHVum0ffLr+MsF0O+yEWKcdpR0J0TQx6GdDxeZFZY7utZT8=KA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Sep 09, 2021 at 09:49:56AM -0700, Vipin Sharma <vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
> We are adding two files in this patch series, misc.events and
> misc.events.local. I think "fail" should go in misc.events.local and
> its name should be changed to "max".
I consider the max vs fail orthogonal to local vs hierarchical. I.e.
both entries can be in both files:
(1) misc.events.local:max number of times the cgroup's misc.max was hit
(2) misc.events.local:fail number of times operation failed in the cgroup
(3) misc.events:max number of times the cgroup's misc.max was hit in the subtree
(4) misc.events:fail number of times operation failed in the subtree
Is that too many? Admittedly, I assume (1) and (4) will be the more useful ones.
However, I'm afraid overloading "max" as suggested might be (more)
confusing. ('subtree' above := self or descendant)
Michal
WARNING: multiple messages have this Message-ID (diff)
From: "Michal Koutný" <mkoutny@suse.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: brookxu <brookxu.cn@gmail.com>,
tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood
Date: Thu, 9 Sep 2021 20:56:16 +0200 [thread overview]
Message-ID: <YTpY0G3+IJYmGbdd@blackbook> (raw)
In-Reply-To: <CAHVum0ffLr+MsF0O+yEWKcdpR0J0TQx6GdDxeZFZY7utZT8=KA@mail.gmail.com>
On Thu, Sep 09, 2021 at 09:49:56AM -0700, Vipin Sharma <vipinsh@google.com> wrote:
> We are adding two files in this patch series, misc.events and
> misc.events.local. I think "fail" should go in misc.events.local and
> its name should be changed to "max".
I consider the max vs fail orthogonal to local vs hierarchical. I.e.
both entries can be in both files:
(1) misc.events.local:max number of times the cgroup's misc.max was hit
(2) misc.events.local:fail number of times operation failed in the cgroup
(3) misc.events:max number of times the cgroup's misc.max was hit in the subtree
(4) misc.events:fail number of times operation failed in the subtree
Is that too many? Admittedly, I assume (1) and (4) will be the more useful ones.
However, I'm afraid overloading "max" as suggested might be (more)
confusing. ('subtree' above := self or descendant)
Michal
next prev parent reply other threads:[~2021-09-09 18:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 5:24 [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local brookxu
[not found] ` <988f340462a1a3c62b7dc2c64ceb89a4c0a00552.1631077837.git.brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2021-09-08 5:24 ` [RFC PATCH 2/3] misc_cgroup: introduce misc.failcnt for V1 brookxu
2021-09-08 5:24 ` brookxu
[not found] ` <c4e091c8c0208554b97f751ae80a093f55f19883.1631077837.git.brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2021-09-09 14:37 ` Michal Koutný
2021-09-09 14:37 ` Michal Koutný
2021-09-08 5:24 ` [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood brookxu
2021-09-08 5:24 ` brookxu
[not found] ` <86e89df640f2b4a65dd77bdbab8152fa8e8f5bf1.1631077837.git.brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2021-09-09 14:37 ` Michal Koutný
2021-09-09 14:37 ` Michal Koutný
[not found] ` <20210909143720.GA14709-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2021-09-09 16:49 ` Vipin Sharma
2021-09-09 16:49 ` Vipin Sharma
[not found] ` <CAHVum0ffLr+MsF0O+yEWKcdpR0J0TQx6GdDxeZFZY7utZT8=KA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-09 18:56 ` Michal Koutný [this message]
2021-09-09 18:56 ` Michal Koutný
2021-09-10 5:30 ` brookxu
2021-09-10 5:30 ` brookxu
[not found] ` <478e986c-bc69-62b8-936e-5b075f9270b4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-09-10 9:23 ` Michal Koutný
2021-09-10 9:23 ` Michal Koutný
[not found] ` <20210910092310.GA18084-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2021-09-10 14:29 ` brookxu.cn
2021-09-10 14:29 ` brookxu.cn
[not found] ` <1679f995-5a6f-11b8-7870-54318db07d0d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-09-10 15:36 ` Michal Koutný
2021-09-10 15:36 ` Michal Koutný
2021-09-10 16:29 ` Tejun Heo
[not found] ` <YTuH9fULTx+pLuuH-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2021-09-10 17:16 ` Vipin Sharma
2021-09-10 17:16 ` Vipin Sharma
[not found] ` <CAHVum0ezWW=4x2YgXHhEUFQOkFGBpP+R1Uc-KedHr+r0LGibwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-10 17:19 ` Tejun Heo
2021-09-10 17:19 ` Tejun Heo
2021-09-10 17:31 ` Vipin Sharma
[not found] ` <CAHVum0e+68df7b_e0RoCGgA1h_SLdTt9t2MZ0VgA9afPW9iEvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-10 17:37 ` Tejun Heo
2021-09-10 17:37 ` Tejun Heo
2021-09-09 14:37 ` [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local Michal Koutný
2021-09-09 14:37 ` Michal Koutný
2021-09-09 17:08 ` Vipin Sharma
2021-09-09 17:08 ` Vipin Sharma
[not found] ` <CAHVum0eGN=v1kLqHQg7HBESp8Kg4aGZFNd4XTpxfeyToXPmPVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-10 5:20 ` brookxu
2021-09-10 5:20 ` brookxu
[not found] ` <8259b666-f3a4-6788-880c-38d679414bcb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-09-10 10:33 ` Michal Koutný
2021-09-10 10:33 ` Michal Koutný
[not found] ` <20210910103306.GA24156-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2021-09-10 16:32 ` Tejun Heo
2021-09-10 16:32 ` Tejun Heo
2021-09-09 16:56 ` Vipin Sharma
2021-09-09 16:56 ` Vipin Sharma
[not found] ` <CAHVum0cGkzLg_5fZNFNTG=RRqGYW-8YG2V3gst1TevjtQ4YdBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-10 5:21 ` brookxu
2021-09-10 5:21 ` brookxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTpY0G3+IJYmGbdd@blackbook \
--to=mkoutny-ibi9rg/b67k@public.gmane.org \
--cc=brookxu.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.