From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Vipin Sharma <vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>,
"brookxu.cn" <brookxu.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood
Date: Fri, 10 Sep 2021 07:19:43 -1000 [thread overview]
Message-ID: <YTuTr5Hw4hPIWepd@slm.duckdns.org> (raw)
In-Reply-To: <CAHVum0ezWW=4x2YgXHhEUFQOkFGBpP+R1Uc-KedHr+r0LGibwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hello,
On Fri, Sep 10, 2021 at 10:16:46AM -0700, Vipin Sharma wrote:
> For now, I think we can just have one file, events.local
> (non-hierarchical) which has %s.max type entries. This will tell us
> which cgroup is under pressure and I believe this is helpful.
How about just sticking with hierarchical events? Do you see a lot of
downsides with that compared to .local?
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Vipin Sharma <vipinsh@google.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
"brookxu.cn" <brookxu.cn@gmail.com>,
lizefan.x@bytedance.com, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood
Date: Fri, 10 Sep 2021 07:19:43 -1000 [thread overview]
Message-ID: <YTuTr5Hw4hPIWepd@slm.duckdns.org> (raw)
In-Reply-To: <CAHVum0ezWW=4x2YgXHhEUFQOkFGBpP+R1Uc-KedHr+r0LGibwA@mail.gmail.com>
Hello,
On Fri, Sep 10, 2021 at 10:16:46AM -0700, Vipin Sharma wrote:
> For now, I think we can just have one file, events.local
> (non-hierarchical) which has %s.max type entries. This will tell us
> which cgroup is under pressure and I believe this is helpful.
How about just sticking with hierarchical events? Do you see a lot of
downsides with that compared to .local?
Thanks.
--
tejun
next prev parent reply other threads:[~2021-09-10 17:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 5:24 [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local brookxu
[not found] ` <988f340462a1a3c62b7dc2c64ceb89a4c0a00552.1631077837.git.brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2021-09-08 5:24 ` [RFC PATCH 2/3] misc_cgroup: introduce misc.failcnt for V1 brookxu
2021-09-08 5:24 ` brookxu
[not found] ` <c4e091c8c0208554b97f751ae80a093f55f19883.1631077837.git.brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2021-09-09 14:37 ` Michal Koutný
2021-09-09 14:37 ` Michal Koutný
2021-09-08 5:24 ` [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood brookxu
2021-09-08 5:24 ` brookxu
[not found] ` <86e89df640f2b4a65dd77bdbab8152fa8e8f5bf1.1631077837.git.brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2021-09-09 14:37 ` Michal Koutný
2021-09-09 14:37 ` Michal Koutný
[not found] ` <20210909143720.GA14709-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2021-09-09 16:49 ` Vipin Sharma
2021-09-09 16:49 ` Vipin Sharma
[not found] ` <CAHVum0ffLr+MsF0O+yEWKcdpR0J0TQx6GdDxeZFZY7utZT8=KA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-09 18:56 ` Michal Koutný
2021-09-09 18:56 ` Michal Koutný
2021-09-10 5:30 ` brookxu
2021-09-10 5:30 ` brookxu
[not found] ` <478e986c-bc69-62b8-936e-5b075f9270b4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-09-10 9:23 ` Michal Koutný
2021-09-10 9:23 ` Michal Koutný
[not found] ` <20210910092310.GA18084-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2021-09-10 14:29 ` brookxu.cn
2021-09-10 14:29 ` brookxu.cn
[not found] ` <1679f995-5a6f-11b8-7870-54318db07d0d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-09-10 15:36 ` Michal Koutný
2021-09-10 15:36 ` Michal Koutný
2021-09-10 16:29 ` Tejun Heo
[not found] ` <YTuH9fULTx+pLuuH-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2021-09-10 17:16 ` Vipin Sharma
2021-09-10 17:16 ` Vipin Sharma
[not found] ` <CAHVum0ezWW=4x2YgXHhEUFQOkFGBpP+R1Uc-KedHr+r0LGibwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-10 17:19 ` Tejun Heo [this message]
2021-09-10 17:19 ` Tejun Heo
2021-09-10 17:31 ` Vipin Sharma
[not found] ` <CAHVum0e+68df7b_e0RoCGgA1h_SLdTt9t2MZ0VgA9afPW9iEvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-10 17:37 ` Tejun Heo
2021-09-10 17:37 ` Tejun Heo
2021-09-09 14:37 ` [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local Michal Koutný
2021-09-09 14:37 ` Michal Koutný
2021-09-09 17:08 ` Vipin Sharma
2021-09-09 17:08 ` Vipin Sharma
[not found] ` <CAHVum0eGN=v1kLqHQg7HBESp8Kg4aGZFNd4XTpxfeyToXPmPVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-10 5:20 ` brookxu
2021-09-10 5:20 ` brookxu
[not found] ` <8259b666-f3a4-6788-880c-38d679414bcb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-09-10 10:33 ` Michal Koutný
2021-09-10 10:33 ` Michal Koutný
[not found] ` <20210910103306.GA24156-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2021-09-10 16:32 ` Tejun Heo
2021-09-10 16:32 ` Tejun Heo
2021-09-09 16:56 ` Vipin Sharma
2021-09-09 16:56 ` Vipin Sharma
[not found] ` <CAHVum0cGkzLg_5fZNFNTG=RRqGYW-8YG2V3gst1TevjtQ4YdBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-09-10 5:21 ` brookxu
2021-09-10 5:21 ` brookxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTuTr5Hw4hPIWepd@slm.duckdns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=brookxu.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=mkoutny-IBi9RG/b67k@public.gmane.org \
--cc=vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.