From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/8] syscalls/setresgid02: Convert to new API
Date: Fri, 10 Sep 2021 16:33:06 +0200 [thread overview]
Message-ID: <YTtsomf8YXHThm6t@yuki> (raw)
In-Reply-To: <20210909155126.2720-4-mdoucha@suse.cz>
Hi!
I've pushed patches up to this point, thanks.
For the rest it has to be decided if we will use TST_EXP_FAIL() or not.
I've also did a minor changes to this patch, see below.
> +/*\
> + * [Description]
> + *
> + * Verify that setresgid() will successfully set the expected GID when called
> + * by root with the following combinations of arguments:
> + * 1. setresgid(-1, -1, -1)
> + * 2. setresgid(-1, -1, other)
> + * 3. setresgid(-1, other, -1)
> + * 4. setresgid(other, -1, -1)
> + * 5. setresgid(root, root, root)
> + * 6. setresgid(root, main, main)
> + */
I've reformatted this part so that it rendes as a list in the asciidoc
syntax.
> struct test_case_t { /* test case structure */
> - uid_t *rgid; /* real GID */
> - uid_t *egid; /* effective GID */
> - uid_t *sgid; /* saved GID */
> - struct passwd *exp_rgid; /* Expected real GID */
> - struct passwd *exp_egid; /* Expected effective GID */
> - struct passwd *exp_sgid; /* Expected saved GID */
> + gid_t *rgid; /* real GID */
> + gid_t *egid; /* effective GID */
> + gid_t *sgid; /* saved GID */
> + gid_t *exp_rgid; /* Expected real GID */
> + gid_t *exp_egid; /* Expected effective GID */
> + gid_t *exp_sgid; /* Expected saved GID */
> char *desc; /* Test description */
> };
And also got rid of these useless comments, that were commenting the
obvious.
--
Cyril Hrubis
chrubis@suse.cz
WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 4/8] syscalls/setresgid02: Convert to new API
Date: Fri, 10 Sep 2021 16:33:06 +0200 [thread overview]
Message-ID: <YTtsomf8YXHThm6t@yuki> (raw)
Message-ID: <20210910143306.Epow_mX5jyyqok4Dys7mtCQGGWRq9MG2ta0MJbZ2q-c@z> (raw)
In-Reply-To: <20210909155126.2720-4-mdoucha@suse.cz>
Hi!
I've pushed patches up to this point, thanks.
For the rest it has to be decided if we will use TST_EXP_FAIL() or not.
I've also did a minor changes to this patch, see below.
> +/*\
> + * [Description]
> + *
> + * Verify that setresgid() will successfully set the expected GID when called
> + * by root with the following combinations of arguments:
> + * 1. setresgid(-1, -1, -1)
> + * 2. setresgid(-1, -1, other)
> + * 3. setresgid(-1, other, -1)
> + * 4. setresgid(other, -1, -1)
> + * 5. setresgid(root, root, root)
> + * 6. setresgid(root, main, main)
> + */
I've reformatted this part so that it rendes as a list in the asciidoc
syntax.
> struct test_case_t { /* test case structure */
> - uid_t *rgid; /* real GID */
> - uid_t *egid; /* effective GID */
> - uid_t *sgid; /* saved GID */
> - struct passwd *exp_rgid; /* Expected real GID */
> - struct passwd *exp_egid; /* Expected effective GID */
> - struct passwd *exp_sgid; /* Expected saved GID */
> + gid_t *rgid; /* real GID */
> + gid_t *egid; /* effective GID */
> + gid_t *sgid; /* saved GID */
> + gid_t *exp_rgid; /* Expected real GID */
> + gid_t *exp_egid; /* Expected effective GID */
> + gid_t *exp_sgid; /* Expected saved GID */
> char *desc; /* Test description */
> };
And also got rid of these useless comments, that were commenting the
obvious.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-10 14:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 15:51 [LTP] [PATCH 1/8] syscalls/rename09: Simplify and convert to new API Martin Doucha
2021-09-09 15:51 ` Martin Doucha
2021-09-09 15:51 ` [LTP] [PATCH 2/8] Add SAFE_SETRESUID()/SAFE_SETRESGID() helper functions Martin Doucha
2021-09-09 15:51 ` Martin Doucha
2021-09-09 15:51 ` [LTP] [PATCH 3/8] Add tst_check_resuid() and tst_check_resgid() " Martin Doucha
2021-09-09 15:51 ` Martin Doucha
2021-09-09 15:51 ` [LTP] [PATCH 4/8] syscalls/setresgid02: Convert to new API Martin Doucha
2021-09-09 15:51 ` Martin Doucha
2021-09-10 14:33 ` Cyril Hrubis [this message]
2021-09-10 14:33 ` Cyril Hrubis
2021-09-09 15:51 ` [LTP] [PATCH 5/8] syscalls/setresgid03: " Martin Doucha
2021-09-09 15:51 ` Martin Doucha
2021-09-09 15:51 ` [LTP] [PATCH 6/8] syscalls/setresuid01: " Martin Doucha
2021-09-09 15:51 ` Martin Doucha
2021-09-09 15:51 ` [LTP] [PATCH 7/8] syscalls/setresuid02: " Martin Doucha
2021-09-09 15:51 ` Martin Doucha
2021-09-09 15:51 ` [LTP] [PATCH 8/8] syscalls/setresuid03: " Martin Doucha
2021-09-09 15:51 ` Martin Doucha
2021-09-09 16:32 ` pvorel
2021-09-09 16:32 ` pvorel
2021-09-10 14:29 ` Cyril Hrubis
2021-09-10 14:29 ` Cyril Hrubis
2021-09-10 19:05 ` Petr Vorel
2021-09-10 19:05 ` Petr Vorel
2021-09-13 9:12 ` Martin Doucha
2021-09-13 9:12 ` Martin Doucha
2021-09-13 14:11 ` Martin Doucha
2021-09-13 14:11 ` Martin Doucha
2021-09-13 14:46 ` Petr Vorel
2021-09-13 14:46 ` Petr Vorel
2021-09-13 14:51 ` Cyril Hrubis
2021-09-13 14:51 ` Cyril Hrubis
2021-09-14 5:06 ` Petr Vorel
2021-09-14 5:06 ` Petr Vorel
2021-09-14 9:50 ` Cyril Hrubis
2021-09-14 9:50 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTtsomf8YXHThm6t@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.