* Re: [PATCH] USB: phy: tahvo:replace "%p" with "%pK"
[not found] <20210924075913.31584-1-yangzhiwei@uniontech.com>
@ 2021-09-24 8:19 ` Greg Kroah-Hartman
0 siblings, 0 replies; only message in thread
From: Greg Kroah-Hartman @ 2021-09-24 8:19 UTC (permalink / raw)
To: Zhiwei Yang; +Cc: Felipe Balbi, linux-usb
On Fri, Sep 24, 2021 at 03:59:13PM +0800, Zhiwei Yang wrote:
> Use "%pK" to avoid kernel address leaked
>
> Signed-off-by: Zhiwei Yang <yangzhiwei@uniontech.com>
> ---
> drivers/usb/phy/phy-tahvo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index baebb1f5a973..5dc600fadc5f 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -194,7 +194,7 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
> phy);
>
> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
> + dev_dbg(&tu->pt_dev->dev, "%s %pK\n", __func__, host);
>
> mutex_lock(&tu->serialize);
>
> @@ -224,7 +224,7 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
> phy);
>
> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);
> + dev_dbg(&tu->pt_dev->dev, "%s %pK\n", __func__, gadget);
>
> mutex_lock(&tu->serialize);
>
> --
> 2.20.1
>
>
>
Both of these lines should just be removed as ftrace can be (and should
be) used instead for stuff like "did the kernel get to this function?"
that these lines seem to be for.
So can you just resubmit this as removing those lines?
thanks,
greg k-h
^ permalink raw reply [flat|nested] only message in thread