All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, QEMU Trivial <qemu-trivial@nongnu.org>,
	qemu-block@nongnu.org, Qing Wang <qinwang@redhat.com>
Subject: Re: [PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in
Date: Thu, 16 Sep 2021 09:43:27 +0200	[thread overview]
Message-ID: <YUL1n5CLLQdmLfCr@redhat.com> (raw)
In-Reply-To: <152eb50e-621f-cbac-4748-dc689aa08635@redhat.com>

Am 15.09.2021 um 23:36 hat Philippe Mathieu-Daudé geschrieben:
> ping & Cc'ing qemu-trivial@ (reviewed twice) ...
> 
> On 8/16/21 8:04 PM, Philippe Mathieu-Daudé wrote:
> > When configuring QEMU with --disable-fuse, the qemu-storage-daemon
> > still reports FUSE command line options in its help:
> > 
> >   $ qemu-storage-daemon -h
> >   Usage: qemu-storage-daemon [options]
> >   QEMU storage daemon
> > 
> >     --export [type=]fuse,id=<id>,node-name=<node-name>,mountpoint=<file>
> >              [,growable=on|off][,writable=on|off]
> >                            export the specified block node over FUSE
> > 
> > Remove this help message when FUSE is disabled, to avoid:
> > 
> >   $ qemu-storage-daemon --export fuse
> >   qemu-storage-daemon: --export fuse: Invalid parameter 'fuse'
> > 
> > Reported-by: Qing Wang <qinwang@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks, applied to the block branch.

Kevin



WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Qing Wang <qinwang@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in
Date: Thu, 16 Sep 2021 09:43:27 +0200	[thread overview]
Message-ID: <YUL1n5CLLQdmLfCr@redhat.com> (raw)
In-Reply-To: <152eb50e-621f-cbac-4748-dc689aa08635@redhat.com>

Am 15.09.2021 um 23:36 hat Philippe Mathieu-Daudé geschrieben:
> ping & Cc'ing qemu-trivial@ (reviewed twice) ...
> 
> On 8/16/21 8:04 PM, Philippe Mathieu-Daudé wrote:
> > When configuring QEMU with --disable-fuse, the qemu-storage-daemon
> > still reports FUSE command line options in its help:
> > 
> >   $ qemu-storage-daemon -h
> >   Usage: qemu-storage-daemon [options]
> >   QEMU storage daemon
> > 
> >     --export [type=]fuse,id=<id>,node-name=<node-name>,mountpoint=<file>
> >              [,growable=on|off][,writable=on|off]
> >                            export the specified block node over FUSE
> > 
> > Remove this help message when FUSE is disabled, to avoid:
> > 
> >   $ qemu-storage-daemon --export fuse
> >   qemu-storage-daemon: --export fuse: Invalid parameter 'fuse'
> > 
> > Reported-by: Qing Wang <qinwang@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks, applied to the block branch.

Kevin



  reply	other threads:[~2021-09-16  7:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 18:04 [PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in Philippe Mathieu-Daudé
2021-08-16 21:03 ` Eric Blake
2021-08-17  8:28 ` Hanna Reitz
2021-09-15 21:36 ` Philippe Mathieu-Daudé
2021-09-15 21:36   ` Philippe Mathieu-Daudé
2021-09-16  7:43   ` Kevin Wolf [this message]
2021-09-16  7:43     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUL1n5CLLQdmLfCr@redhat.com \
    --to=kwolf@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=qinwang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.