All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: kishon@ti.com, vkoul@kernel.org, andrew@lunn.ch,
	alexandre.belloni@bootlin.com, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: phy: Add constants for lan966x serdes
Date: Mon, 18 Oct 2021 14:28:24 -0500	[thread overview]
Message-ID: <YW3K2GX+hmkwt3EE@robh.at.kernel.org> (raw)
In-Reply-To: <20211015123920.176782-3-horatiu.vultur@microchip.com>

On Fri, Oct 15, 2021 at 02:39:19PM +0200, Horatiu Vultur wrote:
> Lan966x has: 2 integrated PHYs, 3 SerDes and 2 RGMII interfaces. Which
> requires to be muxed based on the HW representation.
> 
> So add constants for each interface to be able to distinguish them.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  include/dt-bindings/phy/phy-lan966x-serdes.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 include/dt-bindings/phy/phy-lan966x-serdes.h
> 
> diff --git a/include/dt-bindings/phy/phy-lan966x-serdes.h b/include/dt-bindings/phy/phy-lan966x-serdes.h
> new file mode 100644
> index 000000000000..8a05f93ecf41
> --- /dev/null
> +++ b/include/dt-bindings/phy/phy-lan966x-serdes.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +
> +#ifndef __PHY_LAN966X_SERDES_H__
> +#define __PHY_LAN966X_SERDES_H__
> +
> +#define PHY(x)		(x)
> +#define PHY_MAX		PHY(2)
> +#define SERDES6G(x)	(PHY_MAX + 1 + (x))
> +#define SERDES6G_MAX	SERDES6G(3)
> +#define RGMII(x)	(SERDES6G_MAX + 1 + (x))
> +#define RGMII_MAX	RGMII(2)
> +#define SERDES_MAX	(RGMII_MAX + 1)

I still don't understand. #phy-cells description says we have:

<port idx> <serdes idx>

But here it's 3 numbers. How are these defines used to fill in the 2 
cells?

Rob

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: kishon@ti.com, vkoul@kernel.org, andrew@lunn.ch,
	alexandre.belloni@bootlin.com, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: phy: Add constants for lan966x serdes
Date: Mon, 18 Oct 2021 14:28:24 -0500	[thread overview]
Message-ID: <YW3K2GX+hmkwt3EE@robh.at.kernel.org> (raw)
In-Reply-To: <20211015123920.176782-3-horatiu.vultur@microchip.com>

On Fri, Oct 15, 2021 at 02:39:19PM +0200, Horatiu Vultur wrote:
> Lan966x has: 2 integrated PHYs, 3 SerDes and 2 RGMII interfaces. Which
> requires to be muxed based on the HW representation.
> 
> So add constants for each interface to be able to distinguish them.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  include/dt-bindings/phy/phy-lan966x-serdes.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 include/dt-bindings/phy/phy-lan966x-serdes.h
> 
> diff --git a/include/dt-bindings/phy/phy-lan966x-serdes.h b/include/dt-bindings/phy/phy-lan966x-serdes.h
> new file mode 100644
> index 000000000000..8a05f93ecf41
> --- /dev/null
> +++ b/include/dt-bindings/phy/phy-lan966x-serdes.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +
> +#ifndef __PHY_LAN966X_SERDES_H__
> +#define __PHY_LAN966X_SERDES_H__
> +
> +#define PHY(x)		(x)
> +#define PHY_MAX		PHY(2)
> +#define SERDES6G(x)	(PHY_MAX + 1 + (x))
> +#define SERDES6G_MAX	SERDES6G(3)
> +#define RGMII(x)	(SERDES6G_MAX + 1 + (x))
> +#define RGMII_MAX	RGMII(2)
> +#define SERDES_MAX	(RGMII_MAX + 1)

I still don't understand. #phy-cells description says we have:

<port idx> <serdes idx>

But here it's 3 numbers. How are these defines used to fill in the 2 
cells?

Rob

  reply	other threads:[~2021-10-18 19:47 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15 12:39 [PATCH v3 0/3] Add driver for lan966x Serdes driver Horatiu Vultur
2021-10-15 12:39 ` Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 1/3] dt-bindings: phy: Add lan966x-serdes binding Horatiu Vultur
2021-10-15 12:39   ` Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 2/3] dt-bindings: phy: Add constants for lan966x serdes Horatiu Vultur
2021-10-15 12:39   ` Horatiu Vultur
2021-10-18 19:28   ` Rob Herring [this message]
2021-10-18 19:28     ` Rob Herring
2021-10-19  9:12     ` Horatiu Vultur
2021-10-19  9:12       ` Horatiu Vultur
2021-10-19 13:38       ` Rob Herring
2021-10-19 13:38         ` Rob Herring
2021-10-20  9:07         ` Horatiu Vultur
2021-10-20  9:07           ` Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 3/3] phy: Add lan966x ethernet serdes PHY driver Horatiu Vultur
2021-10-15 12:39   ` Horatiu Vultur
2021-10-19 17:57   ` Vinod Koul
2021-10-19 17:57     ` Vinod Koul
2021-10-20  9:17     ` Horatiu Vultur
2021-10-20  9:17       ` Horatiu Vultur
2021-10-20 15:35       ` Vinod Koul
2021-10-20 15:35         ` Vinod Koul
2021-10-20 15:49         ` Alexandre Belloni
2021-10-20 15:49           ` Alexandre Belloni
2021-10-21  6:10           ` Vinod Koul
2021-10-21  6:10             ` Vinod Koul
2021-10-21  9:10             ` Horatiu Vultur
2021-10-21  9:10               ` Horatiu Vultur
2021-10-21 17:49               ` Vinod Koul
2021-10-21 17:49                 ` Vinod Koul
2021-10-28  8:57                 ` Horatiu Vultur
2021-10-28  8:57                   ` Horatiu Vultur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YW3K2GX+hmkwt3EE@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=horatiu.vultur@microchip.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.