All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: kishon@ti.com, robh+dt@kernel.org, andrew@lunn.ch,
	alexandre.belloni@bootlin.com, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] phy: Add lan966x ethernet serdes PHY driver
Date: Wed, 20 Oct 2021 21:05:49 +0530	[thread overview]
Message-ID: <YXA3VVUGEjUR4HDC@matsya> (raw)
In-Reply-To: <20211020091733.fxph2pq3xa3byvry@soft-dev3-1.localhost>

On 20-10-21, 11:17, Horatiu Vultur wrote:
> The 10/19/2021 23:27, Vinod Koul wrote:
> > 
> > On 15-10-21, 14:39, Horatiu Vultur wrote:
> > > Add the Microchip lan966x ethernet serdes PHY driver for interfaces
> > > available in the lan966x SoC.
> > >
> > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > > ---
> > >  drivers/phy/microchip/Kconfig               |   8 +
> > >  drivers/phy/microchip/Makefile              |   1 +
> > >  drivers/phy/microchip/lan966x_serdes.c      | 540 ++++++++++++++++++++
> > >  drivers/phy/microchip/lan966x_serdes_regs.h | 482 +++++++++++++++++
> > >  4 files changed, 1031 insertions(+)
> > >  create mode 100644 drivers/phy/microchip/lan966x_serdes.c
> > >  create mode 100644 drivers/phy/microchip/lan966x_serdes_regs.h
> > >
> > > diff --git a/drivers/phy/microchip/Kconfig b/drivers/phy/microchip/Kconfig
> > > index 3728a284bf64..38039ed0754c 100644
> > > --- a/drivers/phy/microchip/Kconfig
> > > +++ b/drivers/phy/microchip/Kconfig
> > > @@ -11,3 +11,11 @@ config PHY_SPARX5_SERDES
> > >       depends on HAS_IOMEM
> > >       help
> > >         Enable this for support of the 10G/25G SerDes on Microchip Sparx5.
> > > +
> > > +config PHY_LAN966X_SERDES
> > > +     tristate "SerDes PHY driver for Microchip LAN966X"
> > > +     select GENERIC_PHY
> > > +     depends on OF
> > > +     depends on MFD_SYSCON
> > > +     help
> > > +       Enable this for supporting SerDes muxing with Microchip LAN966X
> > > diff --git a/drivers/phy/microchip/Makefile b/drivers/phy/microchip/Makefile
> > > index 7b98345712aa..fd73b87960a5 100644
> > > --- a/drivers/phy/microchip/Makefile
> > > +++ b/drivers/phy/microchip/Makefile
> > > @@ -4,3 +4,4 @@
> > >  #
> > >
> > >  obj-$(CONFIG_PHY_SPARX5_SERDES) := sparx5_serdes.o
> > > +obj-$(CONFIG_PHY_LAN966X_SERDES) := lan966x_serdes.o
> > > diff --git a/drivers/phy/microchip/lan966x_serdes.c b/drivers/phy/microchip/lan966x_serdes.c
> > > new file mode 100644
> > > index 000000000000..e663bb9186a8
> > > --- /dev/null
> > > +++ b/drivers/phy/microchip/lan966x_serdes.c
> > > @@ -0,0 +1,540 @@
> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > 
> > Any reason why this is dual licensed, why not GPL only?
> 
> No reason, I think I copy this from a different file.

Please have a chat with your lawyers on the correct license this should
have!

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: kishon@ti.com, robh+dt@kernel.org, andrew@lunn.ch,
	alexandre.belloni@bootlin.com, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] phy: Add lan966x ethernet serdes PHY driver
Date: Wed, 20 Oct 2021 21:05:49 +0530	[thread overview]
Message-ID: <YXA3VVUGEjUR4HDC@matsya> (raw)
In-Reply-To: <20211020091733.fxph2pq3xa3byvry@soft-dev3-1.localhost>

On 20-10-21, 11:17, Horatiu Vultur wrote:
> The 10/19/2021 23:27, Vinod Koul wrote:
> > 
> > On 15-10-21, 14:39, Horatiu Vultur wrote:
> > > Add the Microchip lan966x ethernet serdes PHY driver for interfaces
> > > available in the lan966x SoC.
> > >
> > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > > ---
> > >  drivers/phy/microchip/Kconfig               |   8 +
> > >  drivers/phy/microchip/Makefile              |   1 +
> > >  drivers/phy/microchip/lan966x_serdes.c      | 540 ++++++++++++++++++++
> > >  drivers/phy/microchip/lan966x_serdes_regs.h | 482 +++++++++++++++++
> > >  4 files changed, 1031 insertions(+)
> > >  create mode 100644 drivers/phy/microchip/lan966x_serdes.c
> > >  create mode 100644 drivers/phy/microchip/lan966x_serdes_regs.h
> > >
> > > diff --git a/drivers/phy/microchip/Kconfig b/drivers/phy/microchip/Kconfig
> > > index 3728a284bf64..38039ed0754c 100644
> > > --- a/drivers/phy/microchip/Kconfig
> > > +++ b/drivers/phy/microchip/Kconfig
> > > @@ -11,3 +11,11 @@ config PHY_SPARX5_SERDES
> > >       depends on HAS_IOMEM
> > >       help
> > >         Enable this for support of the 10G/25G SerDes on Microchip Sparx5.
> > > +
> > > +config PHY_LAN966X_SERDES
> > > +     tristate "SerDes PHY driver for Microchip LAN966X"
> > > +     select GENERIC_PHY
> > > +     depends on OF
> > > +     depends on MFD_SYSCON
> > > +     help
> > > +       Enable this for supporting SerDes muxing with Microchip LAN966X
> > > diff --git a/drivers/phy/microchip/Makefile b/drivers/phy/microchip/Makefile
> > > index 7b98345712aa..fd73b87960a5 100644
> > > --- a/drivers/phy/microchip/Makefile
> > > +++ b/drivers/phy/microchip/Makefile
> > > @@ -4,3 +4,4 @@
> > >  #
> > >
> > >  obj-$(CONFIG_PHY_SPARX5_SERDES) := sparx5_serdes.o
> > > +obj-$(CONFIG_PHY_LAN966X_SERDES) := lan966x_serdes.o
> > > diff --git a/drivers/phy/microchip/lan966x_serdes.c b/drivers/phy/microchip/lan966x_serdes.c
> > > new file mode 100644
> > > index 000000000000..e663bb9186a8
> > > --- /dev/null
> > > +++ b/drivers/phy/microchip/lan966x_serdes.c
> > > @@ -0,0 +1,540 @@
> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > 
> > Any reason why this is dual licensed, why not GPL only?
> 
> No reason, I think I copy this from a different file.

Please have a chat with your lawyers on the correct license this should
have!

-- 
~Vinod

  reply	other threads:[~2021-10-20 15:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15 12:39 [PATCH v3 0/3] Add driver for lan966x Serdes driver Horatiu Vultur
2021-10-15 12:39 ` Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 1/3] dt-bindings: phy: Add lan966x-serdes binding Horatiu Vultur
2021-10-15 12:39   ` Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 2/3] dt-bindings: phy: Add constants for lan966x serdes Horatiu Vultur
2021-10-15 12:39   ` Horatiu Vultur
2021-10-18 19:28   ` Rob Herring
2021-10-18 19:28     ` Rob Herring
2021-10-19  9:12     ` Horatiu Vultur
2021-10-19  9:12       ` Horatiu Vultur
2021-10-19 13:38       ` Rob Herring
2021-10-19 13:38         ` Rob Herring
2021-10-20  9:07         ` Horatiu Vultur
2021-10-20  9:07           ` Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 3/3] phy: Add lan966x ethernet serdes PHY driver Horatiu Vultur
2021-10-15 12:39   ` Horatiu Vultur
2021-10-19 17:57   ` Vinod Koul
2021-10-19 17:57     ` Vinod Koul
2021-10-20  9:17     ` Horatiu Vultur
2021-10-20  9:17       ` Horatiu Vultur
2021-10-20 15:35       ` Vinod Koul [this message]
2021-10-20 15:35         ` Vinod Koul
2021-10-20 15:49         ` Alexandre Belloni
2021-10-20 15:49           ` Alexandre Belloni
2021-10-21  6:10           ` Vinod Koul
2021-10-21  6:10             ` Vinod Koul
2021-10-21  9:10             ` Horatiu Vultur
2021-10-21  9:10               ` Horatiu Vultur
2021-10-21 17:49               ` Vinod Koul
2021-10-21 17:49                 ` Vinod Koul
2021-10-28  8:57                 ` Horatiu Vultur
2021-10-28  8:57                   ` Horatiu Vultur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXA3VVUGEjUR4HDC@matsya \
    --to=vkoul@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=horatiu.vultur@microchip.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.