From: Lee Jones <lee.jones@linaro.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Mark Brown <broonie@kernel.org>, Michael Walle <michael@walle.cc>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Lima <mauro.lima@eclypsium.com>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 2/3] mtd: spi-nor: intel-spi: Convert to SPI MEM
Date: Thu, 21 Oct 2021 11:57:14 +0100 [thread overview]
Message-ID: <YXFHimJ75Bpg5sSP@google.com> (raw)
In-Reply-To: <20211007112132.30934-3-mika.westerberg@linux.intel.com>
On Thu, 07 Oct 2021, Mika Westerberg wrote:
> The preferred way to implement SPI-NOR controller drivers is through SPI
> subsubsystem utilizing the SPI MEM core functions. This converts the
> Intel SPI flash controller driver over the SPI MEM by moving the driver
> from SPI-NOR subsystem to SPI subsystem and in one go make it use the
> SPI MEM functions. The driver name will be changed from intel-spi to
> spi-intel to match the convention used in the SPI subsystem.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/mtd/spi-nor/controllers/Kconfig | 36 ---
> drivers/mtd/spi-nor/controllers/Makefile | 3 -
> drivers/mtd/spi-nor/controllers/intel-spi.h | 21 --
> drivers/spi/Kconfig | 39 +++
> drivers/spi/Makefile | 3 +
> .../intel-spi-pci.c => spi/spi-intel-pci.c} | 20 +-
> .../spi-intel-platform.c} | 21 +-
> .../intel-spi.c => spi/spi-intel.c} | 304 +++++++++++-------
> drivers/spi/spi-intel.h | 19 ++
> include/linux/mfd/lpc_ich.h | 2 +-
> .../x86/{intel-spi.h => spi-intel.h} | 6 +-
> 11 files changed, 254 insertions(+), 220 deletions(-)
> delete mode 100644 drivers/mtd/spi-nor/controllers/intel-spi.h
> rename drivers/{mtd/spi-nor/controllers/intel-spi-pci.c => spi/spi-intel-pci.c} (86%)
> rename drivers/{mtd/spi-nor/controllers/intel-spi-platform.c => spi/spi-intel-platform.c} (65%)
> rename drivers/{mtd/spi-nor/controllers/intel-spi.c => spi/spi-intel.c} (80%)
> create mode 100644 drivers/spi/spi-intel.h
> rename include/linux/platform_data/x86/{intel-spi.h => spi-intel.h} (89%)
For the MFD parts:
Acked-by: Lee Jones <lee.jones@linaro.org>
Whoever ends up taking this needs to send out a pull-request to an
immutable branch please.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Mark Brown <broonie@kernel.org>, Michael Walle <michael@walle.cc>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Lima <mauro.lima@eclypsium.com>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 2/3] mtd: spi-nor: intel-spi: Convert to SPI MEM
Date: Thu, 21 Oct 2021 11:57:14 +0100 [thread overview]
Message-ID: <YXFHimJ75Bpg5sSP@google.com> (raw)
In-Reply-To: <20211007112132.30934-3-mika.westerberg@linux.intel.com>
On Thu, 07 Oct 2021, Mika Westerberg wrote:
> The preferred way to implement SPI-NOR controller drivers is through SPI
> subsubsystem utilizing the SPI MEM core functions. This converts the
> Intel SPI flash controller driver over the SPI MEM by moving the driver
> from SPI-NOR subsystem to SPI subsystem and in one go make it use the
> SPI MEM functions. The driver name will be changed from intel-spi to
> spi-intel to match the convention used in the SPI subsystem.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/mtd/spi-nor/controllers/Kconfig | 36 ---
> drivers/mtd/spi-nor/controllers/Makefile | 3 -
> drivers/mtd/spi-nor/controllers/intel-spi.h | 21 --
> drivers/spi/Kconfig | 39 +++
> drivers/spi/Makefile | 3 +
> .../intel-spi-pci.c => spi/spi-intel-pci.c} | 20 +-
> .../spi-intel-platform.c} | 21 +-
> .../intel-spi.c => spi/spi-intel.c} | 304 +++++++++++-------
> drivers/spi/spi-intel.h | 19 ++
> include/linux/mfd/lpc_ich.h | 2 +-
> .../x86/{intel-spi.h => spi-intel.h} | 6 +-
> 11 files changed, 254 insertions(+), 220 deletions(-)
> delete mode 100644 drivers/mtd/spi-nor/controllers/intel-spi.h
> rename drivers/{mtd/spi-nor/controllers/intel-spi-pci.c => spi/spi-intel-pci.c} (86%)
> rename drivers/{mtd/spi-nor/controllers/intel-spi-platform.c => spi/spi-intel-platform.c} (65%)
> rename drivers/{mtd/spi-nor/controllers/intel-spi.c => spi/spi-intel.c} (80%)
> create mode 100644 drivers/spi/spi-intel.h
> rename include/linux/platform_data/x86/{intel-spi.h => spi-intel.h} (89%)
For the MFD parts:
Acked-by: Lee Jones <lee.jones@linaro.org>
Whoever ends up taking this needs to send out a pull-request to an
immutable branch please.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-10-21 10:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 11:21 [PATCH v2 0/3] mtd: spi-nor / spi / MFD: Convert intel-spi to SPI MEM Mika Westerberg
2021-10-07 11:21 ` Mika Westerberg
2021-10-07 11:21 ` [PATCH v2 1/3] mtd: spi-nor: intel-spi: Disable write protection only if asked Mika Westerberg
2021-10-07 11:21 ` Mika Westerberg
2021-10-21 10:56 ` Lee Jones
2021-10-21 10:56 ` Lee Jones
2021-10-07 11:21 ` [PATCH v2 2/3] mtd: spi-nor: intel-spi: Convert to SPI MEM Mika Westerberg
2021-10-07 11:21 ` Mika Westerberg
2021-10-21 10:57 ` Lee Jones [this message]
2021-10-21 10:57 ` Lee Jones
2021-10-07 11:21 ` [PATCH v2 3/3] Documentation / MTD: Rename the intel-spi driver Mika Westerberg
2021-10-07 11:21 ` Mika Westerberg
2021-10-12 19:07 ` [PATCH v2 0/3] mtd: spi-nor / spi / MFD: Convert intel-spi to SPI MEM Andy Shevchenko
2021-10-12 19:07 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXFHimJ75Bpg5sSP@google.com \
--to=lee.jones@linaro.org \
--cc=alexander.sverdlin@nokia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mauro.lima@eclypsium.com \
--cc=michael@walle.cc \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.