From: Mark Brown <broonie@kernel.org>
To: Vincent Knecht <vincent.knecht@mailoo.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
stephan@gerhold.net, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v1 1/4] ASoC: codecs: tfa989x: Add switch to allow disabling amplifier
Date: Mon, 25 Oct 2021 11:52:04 +0100 [thread overview]
Message-ID: <YXaMVHo9drCIuD3u@sirena.org.uk> (raw)
In-Reply-To: <20211024085840.1536438-2-vincent.knecht@mailoo.org>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Sun, Oct 24, 2021 at 10:58:37AM +0200, Vincent Knecht wrote:
> From: Stephan Gerhold <stephan@gerhold.net>
>
> In some configurations it may be necessary to explicitly disable
> the amplifier with an ALSA mixer. An example for this is a stereo
> setup with two TFA989X. If only one of them should be used (e.g.
> to use it as an earpiece) the other one must be explicitly disabled.
>
> Add a virtual "Amp Switch" to implement that. There is no register
> for this (SND_SOC_NOPM) so it only prevents DAPM from activating
> the amplifier. Also it is inverted (= enabled by default) for
> compatibility with devices that do not need this functionality.
Why can you not use a standard pin switch on the speaker output for
this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Vincent Knecht <vincent.knecht@mailoo.org>
Cc: stephan@gerhold.net, lgirdwood@gmail.com, robh+dt@kernel.org,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v1 1/4] ASoC: codecs: tfa989x: Add switch to allow disabling amplifier
Date: Mon, 25 Oct 2021 11:52:04 +0100 [thread overview]
Message-ID: <YXaMVHo9drCIuD3u@sirena.org.uk> (raw)
In-Reply-To: <20211024085840.1536438-2-vincent.knecht@mailoo.org>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Sun, Oct 24, 2021 at 10:58:37AM +0200, Vincent Knecht wrote:
> From: Stephan Gerhold <stephan@gerhold.net>
>
> In some configurations it may be necessary to explicitly disable
> the amplifier with an ALSA mixer. An example for this is a stereo
> setup with two TFA989X. If only one of them should be used (e.g.
> to use it as an earpiece) the other one must be explicitly disabled.
>
> Add a virtual "Amp Switch" to implement that. There is no register
> for this (SND_SOC_NOPM) so it only prevents DAPM from activating
> the amplifier. Also it is inverted (= enabled by default) for
> compatibility with devices that do not need this functionality.
Why can you not use a standard pin switch on the speaker output for
this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-25 10:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 8:58 [PATCH v1 0/4] Add tfa9897 speaker/receiver modes switching Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-24 8:58 ` [PATCH v1 1/4] ASoC: codecs: tfa989x: Add switch to allow disabling amplifier Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-25 10:52 ` Mark Brown [this message]
2021-10-25 10:52 ` Mark Brown
2021-10-28 7:22 ` Stephan Gerhold
2021-10-28 7:22 ` Stephan Gerhold
2021-10-24 8:58 ` [PATCH v1 2/4] ASoC: codecs: tfa989x: Add support for tfa9897 RCV bit Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-24 8:58 ` [PATCH v1 3/4] ASoC: dt-bindings: nxp, tfa989x: Add rcv-gpios property for tfa9897 Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-29 2:13 ` Rob Herring
2021-10-29 2:13 ` Rob Herring
2021-10-31 9:35 ` Vincent Knecht
2021-10-31 9:35 ` Vincent Knecht
2021-10-24 8:58 ` [PATCH v1 4/4] ASoC: codecs: tfa989x: Add support for tfa9897 optional rcv-gpios Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-29 15:20 ` (subset) [PATCH v1 0/4] Add tfa9897 speaker/receiver modes switching Mark Brown
2021-10-29 15:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXaMVHo9drCIuD3u@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=tiwai@suse.com \
--cc=vincent.knecht@mailoo.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.