From: Rob Herring <robh@kernel.org>
To: Vincent Knecht <vincent.knecht@mailoo.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
stephan@gerhold.net, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v1 3/4] ASoC: dt-bindings: nxp, tfa989x: Add rcv-gpios property for tfa9897
Date: Thu, 28 Oct 2021 21:13:10 -0500 [thread overview]
Message-ID: <YXtYtsPCeh937oF6@robh.at.kernel.org> (raw)
In-Reply-To: <20211024085840.1536438-4-vincent.knecht@mailoo.org>
On Sun, Oct 24, 2021 at 10:58:39AM +0200, Vincent Knecht wrote:
> Add optional rcv-gpios property specific to tfa9897 receiver mode.
>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
> .../devicetree/bindings/sound/nxp,tfa989x.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> index 7667471be1e4..a9e15baedafd 100644
> --- a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> @@ -12,6 +12,16 @@ maintainers:
> allOf:
> - $ref: name-prefix.yaml#
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: nxp,tfa9897
> + then:
> + properties:
> + rcv-gpios:
> + description: optional GPIO to be asserted when receiver mode is enabled.
Did you test this works?
You have to define the property outside the if/then schema at the top
level. Then use an if/then schema to restrict it (rcv-gpios: false).
> +
> properties:
> compatible:
> enum:
> --
> 2.31.1
>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Vincent Knecht <vincent.knecht@mailoo.org>
Cc: stephan@gerhold.net, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v1 3/4] ASoC: dt-bindings: nxp, tfa989x: Add rcv-gpios property for tfa9897
Date: Thu, 28 Oct 2021 21:13:10 -0500 [thread overview]
Message-ID: <YXtYtsPCeh937oF6@robh.at.kernel.org> (raw)
In-Reply-To: <20211024085840.1536438-4-vincent.knecht@mailoo.org>
On Sun, Oct 24, 2021 at 10:58:39AM +0200, Vincent Knecht wrote:
> Add optional rcv-gpios property specific to tfa9897 receiver mode.
>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
> .../devicetree/bindings/sound/nxp,tfa989x.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> index 7667471be1e4..a9e15baedafd 100644
> --- a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> @@ -12,6 +12,16 @@ maintainers:
> allOf:
> - $ref: name-prefix.yaml#
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: nxp,tfa9897
> + then:
> + properties:
> + rcv-gpios:
> + description: optional GPIO to be asserted when receiver mode is enabled.
Did you test this works?
You have to define the property outside the if/then schema at the top
level. Then use an if/then schema to restrict it (rcv-gpios: false).
> +
> properties:
> compatible:
> enum:
> --
> 2.31.1
>
>
>
>
next prev parent reply other threads:[~2021-10-29 2:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 8:58 [PATCH v1 0/4] Add tfa9897 speaker/receiver modes switching Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-24 8:58 ` [PATCH v1 1/4] ASoC: codecs: tfa989x: Add switch to allow disabling amplifier Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-25 10:52 ` Mark Brown
2021-10-25 10:52 ` Mark Brown
2021-10-28 7:22 ` Stephan Gerhold
2021-10-28 7:22 ` Stephan Gerhold
2021-10-24 8:58 ` [PATCH v1 2/4] ASoC: codecs: tfa989x: Add support for tfa9897 RCV bit Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-24 8:58 ` [PATCH v1 3/4] ASoC: dt-bindings: nxp, tfa989x: Add rcv-gpios property for tfa9897 Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-29 2:13 ` Rob Herring [this message]
2021-10-29 2:13 ` Rob Herring
2021-10-31 9:35 ` Vincent Knecht
2021-10-31 9:35 ` Vincent Knecht
2021-10-24 8:58 ` [PATCH v1 4/4] ASoC: codecs: tfa989x: Add support for tfa9897 optional rcv-gpios Vincent Knecht
2021-10-24 8:58 ` Vincent Knecht
2021-10-29 15:20 ` (subset) [PATCH v1 0/4] Add tfa9897 speaker/receiver modes switching Mark Brown
2021-10-29 15:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXtYtsPCeh937oF6@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stephan@gerhold.net \
--cc=tiwai@suse.com \
--cc=vincent.knecht@mailoo.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.