[PATCH] gdm724x: add SPDX License in gdm724x drivers

[PATCH] gdm724x: add SPDX License in gdm724x drivers

[Ankit Kumar Pandey]

This work ensure SPDX-License convention is followed. License is taken
from file gdm_mux.c present in drivers/staging/gdm724x.

Signed-off-by: Ankit Kumar Pandey <itsankitkp@gmail.com>
---
 drivers/staging/gdm724x/gdmulte.mod.c | 40 +++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 drivers/staging/gdm724x/gdmulte.mod.c

diff --git a/drivers/staging/gdm724x/gdmulte.mod.c b/drivers/staging/gdm724x/gdmulte.mod.c
new file mode 100644
index 000000000..6ddc19dcc
--- /dev/null
+++ b/drivers/staging/gdm724x/gdmulte.mod.c
@@ -0,0 +1,40 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2012 GCT Semiconductor, Inc. All rights reserved. */
+
+#include <linux/module.h>
+#define INCLUDE_VERMAGIC
+#include <linux/build-salt.h>
+#include <linux/elfnote-lto.h>
+#include <linux/vermagic.h>
+#include <linux/compiler.h>
+
+BUILD_SALT;
+BUILD_LTO_INFO;
+
+MODULE_INFO(vermagic, VERMAGIC_STRING);
+MODULE_INFO(name, KBUILD_MODNAME);
+
+__visible struct module __this_module
+__section(".gnu.linkonce.this_module") = {
+	.name = KBUILD_MODNAME,
+	.init = init_module,
+#ifdef CONFIG_MODULE_UNLOAD
+	.exit = cleanup_module,
+#endif
+	.arch = MODULE_ARCH_INIT,
+};
+
+MODULE_INFO(intree, "Y");
+
+#ifdef CONFIG_RETPOLINE
+MODULE_INFO(retpoline, "Y");
+#endif
+
+MODULE_INFO(staging, "Y");
+
+MODULE_INFO(depends, "");
+
+MODULE_ALIAS("usb:v1076p8000d*dc*dsc*dp*ic02isc06ip*in*");
+MODULE_ALIAS("usb:v1076p9000d*dc*dsc*dp*ic02isc06ip*in*");
+
+MODULE_INFO(srcversion, "EBCF613A4FE4F4BD3A2C60F");
-- 
2.25.1

Re: [PATCH] gdm724x: add SPDX License in gdm724x drivers

[Greg KH]

On Wed, Nov 03, 2021 at 12:28:44AM +0530, Ankit Kumar Pandey wrote:
> This work ensure SPDX-License convention is followed. License is taken
> from file gdm_mux.c present in drivers/staging/gdm724x.
> 
> Signed-off-by: Ankit Kumar Pandey <itsankitkp@gmail.com>
> ---
>  drivers/staging/gdm724x/gdmulte.mod.c | 40 +++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 drivers/staging/gdm724x/gdmulte.mod.c

Why are you adding this file to the kernel source tree?

Re: [PATCH] gdm724x: add SPDX License in gdm724x drivers (resend)

[Greg KH]

On Wed, Nov 03, 2021 at 01:49:27PM +0530, Ankit Pandey wrote:
> I am sorry, there was some issue with my git and I was looking at wrong
> history. I have fixed my git and checked drivers/staging/gdm724x/ for
> license issues. No such issue was present.
> Please ignore this patch.
> 
> Note: This was my first patch, I am still figuring out and learning things.
> 
> On Wed, 3 Nov, 2021, 1:20 am Greg KH, <gregkh@linuxfoundation.org> wrote:
> 
> > On Wed, Nov 03, 2021 at 12:28:44AM +0530, Ankit Kumar Pandey wrote:
> > > This work ensure SPDX-License convention is followed. License is taken
> > > from file gdm_mux.c present in drivers/staging/gdm724x.
> > >
> > > Signed-off-by: Ankit Kumar Pandey <itsankitkp@gmail.com>
> > > ---
> > >  drivers/staging/gdm724x/gdmulte.mod.c | 40 +++++++++++++++++++++++++++
> > >  1 file changed, 40 insertions(+)
> > >  create mode 100644 drivers/staging/gdm724x/gdmulte.mod.c
> >
> > Why are you adding this file to the kernel source tree?

This file should not have been in your git history at all, it is
automataically generated by the build.

So what tool was scanning it for a SPDX license?

thanks,

greg k-h