From: Sam Ravnborg <sam@ravnborg.org>
To: Yauhen Kharuzhy <jekhor@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
Date: Sun, 7 Nov 2021 11:12:56 +0100 [thread overview]
Message-ID: <YYemqI7MP/rdKuq9@ravnborg.org> (raw)
In-Reply-To: <YYb6r8+aw1bR9R4z@jeknote.loshitsa1.net>
Hi Yauhen,
On Sun, Nov 07, 2021 at 12:59:11AM +0300, Yauhen Kharuzhy wrote:
> On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote:
> > The Lenovo Yoga Book X91F/L uses a panel which has been mounted
> > 90 degrees rotated. Add a quirk for this.
>
> Tested on my Yoga Book, works.
Great - and then it would be prudent that you acknowledge this with:
Tested-by: Yauhen Kharuzhy <jekhor@gmail.com>
A "Tested-by:" is in many cases better than an Acked-by: because you
actually applied the patch, build it and verified that it works.
Where an Acked-by: is just to say that you have looked at the patch and
agrees with the patch.
So a Tested-by: gives you the credit you deserve here.
Sam
next prev parent reply other threads:[~2021-11-07 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 13:02 [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L Hans de Goede
2021-11-06 14:37 ` Simon Ser
2021-11-06 21:59 ` Yauhen Kharuzhy
2021-11-07 10:12 ` Sam Ravnborg [this message]
2021-11-07 11:27 ` Yauhen Kharuzhy
2021-11-18 11:55 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYemqI7MP/rdKuq9@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=jekhor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.