* [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
@ 2021-11-06 13:02 Hans de Goede
2021-11-06 14:37 ` Simon Ser
2021-11-06 21:59 ` Yauhen Kharuzhy
0 siblings, 2 replies; 6+ messages in thread
From: Hans de Goede @ 2021-11-06 13:02 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard
Cc: Hans de Goede, Yauhen Kharuzhy, dri-devel
The Lenovo Yoga Book X91F/L uses a panel which has been mounted
90 degrees rotated. Add a quirk for this.
Cc: Yauhen Kharuzhy <jekhor@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index d92b9408fe48..2cced702d225 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -262,6 +262,12 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
},
.driver_data = (void *)&lcd1200x1920_rightside_up,
+ }, { /* Lenovo Yoga Book X90F / X91F / X91L */
+ .matches = {
+ /* Non exact match to match all versions */
+ DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
+ },
+ .driver_data = (void *)&lcd1200x1920_rightside_up,
}, { /* OneGX1 Pro */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "SYSTEM_MANUFACTURER"),
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
2021-11-06 13:02 [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L Hans de Goede
@ 2021-11-06 14:37 ` Simon Ser
2021-11-06 21:59 ` Yauhen Kharuzhy
1 sibling, 0 replies; 6+ messages in thread
From: Simon Ser @ 2021-11-06 14:37 UTC (permalink / raw)
To: Hans de Goede; +Cc: dri-devel, Yauhen Kharuzhy
Acked-by: Simon Ser <contact@emersion.fr>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
2021-11-06 13:02 [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L Hans de Goede
2021-11-06 14:37 ` Simon Ser
@ 2021-11-06 21:59 ` Yauhen Kharuzhy
2021-11-07 10:12 ` Sam Ravnborg
1 sibling, 1 reply; 6+ messages in thread
From: Yauhen Kharuzhy @ 2021-11-06 21:59 UTC (permalink / raw)
To: Hans de Goede; +Cc: dri-devel
On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote:
> The Lenovo Yoga Book X91F/L uses a panel which has been mounted
> 90 degrees rotated. Add a quirk for this.
Tested on my Yoga Book, works.
Acked-by: Yauhen Kharuzhy <jekhor@gmail.com>
> Cc: Yauhen Kharuzhy <jekhor@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index d92b9408fe48..2cced702d225 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -262,6 +262,12 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
> },
> .driver_data = (void *)&lcd1200x1920_rightside_up,
> + }, { /* Lenovo Yoga Book X90F / X91F / X91L */
> + .matches = {
> + /* Non exact match to match all versions */
> + DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
> + },
> + .driver_data = (void *)&lcd1200x1920_rightside_up,
> }, { /* OneGX1 Pro */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "SYSTEM_MANUFACTURER"),
> --
> 2.31.1
>
--
Yauhen Kharuzhy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
2021-11-06 21:59 ` Yauhen Kharuzhy
@ 2021-11-07 10:12 ` Sam Ravnborg
2021-11-07 11:27 ` Yauhen Kharuzhy
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2021-11-07 10:12 UTC (permalink / raw)
To: Yauhen Kharuzhy; +Cc: Hans de Goede, dri-devel
Hi Yauhen,
On Sun, Nov 07, 2021 at 12:59:11AM +0300, Yauhen Kharuzhy wrote:
> On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote:
> > The Lenovo Yoga Book X91F/L uses a panel which has been mounted
> > 90 degrees rotated. Add a quirk for this.
>
> Tested on my Yoga Book, works.
Great - and then it would be prudent that you acknowledge this with:
Tested-by: Yauhen Kharuzhy <jekhor@gmail.com>
A "Tested-by:" is in many cases better than an Acked-by: because you
actually applied the patch, build it and verified that it works.
Where an Acked-by: is just to say that you have looked at the patch and
agrees with the patch.
So a Tested-by: gives you the credit you deserve here.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
2021-11-07 10:12 ` Sam Ravnborg
@ 2021-11-07 11:27 ` Yauhen Kharuzhy
2021-11-18 11:55 ` Hans de Goede
0 siblings, 1 reply; 6+ messages in thread
From: Yauhen Kharuzhy @ 2021-11-07 11:27 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Hans de Goede, dri-devel
On Sun, Nov 07, 2021 at 11:12:56AM +0100, Sam Ravnborg wrote:
> Hi Yauhen,
> On Sun, Nov 07, 2021 at 12:59:11AM +0300, Yauhen Kharuzhy wrote:
> > On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote:
> > > The Lenovo Yoga Book X91F/L uses a panel which has been mounted
> > > 90 degrees rotated. Add a quirk for this.
> >
> > Tested on my Yoga Book, works.
> Great - and then it would be prudent that you acknowledge this with:
> Tested-by: Yauhen Kharuzhy <jekhor@gmail.com>
>
> A "Tested-by:" is in many cases better than an Acked-by: because you
> actually applied the patch, build it and verified that it works.
> Where an Acked-by: is just to say that you have looked at the patch and
> agrees with the patch.
>
> So a Tested-by: gives you the credit you deserve here.
Yes, of course. I forgot about such option.
Tested-by: Yauhen Kharuzhy <jekhor@gmail.com>
--
Yauhen Kharuzhy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L
2021-11-07 11:27 ` Yauhen Kharuzhy
@ 2021-11-18 11:55 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2021-11-18 11:55 UTC (permalink / raw)
To: Yauhen Kharuzhy, Sam Ravnborg; +Cc: dri-devel
Hi,
On 11/7/21 12:27, Yauhen Kharuzhy wrote:
> On Sun, Nov 07, 2021 at 11:12:56AM +0100, Sam Ravnborg wrote:
>> Hi Yauhen,
>> On Sun, Nov 07, 2021 at 12:59:11AM +0300, Yauhen Kharuzhy wrote:
>>> On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote:
>>>> The Lenovo Yoga Book X91F/L uses a panel which has been mounted
>>>> 90 degrees rotated. Add a quirk for this.
>>>
>>> Tested on my Yoga Book, works.
>> Great - and then it would be prudent that you acknowledge this with:
>> Tested-by: Yauhen Kharuzhy <jekhor@gmail.com>
>>
>> A "Tested-by:" is in many cases better than an Acked-by: because you
>> actually applied the patch, build it and verified that it works.
>> Where an Acked-by: is just to say that you have looked at the patch and
>> agrees with the patch.
>>
>> So a Tested-by: gives you the credit you deserve here.
>
> Yes, of course. I forgot about such option.
>
> Tested-by: Yauhen Kharuzhy <jekhor@gmail.com>
Thank you, I've pushed this to drm-misc-next now.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-18 11:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-06 13:02 [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L Hans de Goede
2021-11-06 14:37 ` Simon Ser
2021-11-06 21:59 ` Yauhen Kharuzhy
2021-11-07 10:12 ` Sam Ravnborg
2021-11-07 11:27 ` Yauhen Kharuzhy
2021-11-18 11:55 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.