From: Joerg Roedel <joro@8bytes.org>
To: Alex Bee <knaerzche@gmail.com>
Cc: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568
Date: Wed, 24 Nov 2021 17:34:35 +0100 [thread overview]
Message-ID: <YZ5pm2kFM41OOu+Y@8bytes.org> (raw)
In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com>
On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote:
> With the submission of iommu driver for RK3568 a subtle bug was
> introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be
> the other way arround - that leads to random errors, especially when
> addresses beyond 32 bit are used.
>
> Fix it.
>
> Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2")
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
Applied for v5.16, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Alex Bee <knaerzche@gmail.com>
Cc: Will Deacon <will@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568
Date: Wed, 24 Nov 2021 17:34:35 +0100 [thread overview]
Message-ID: <YZ5pm2kFM41OOu+Y@8bytes.org> (raw)
In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com>
On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote:
> With the submission of iommu driver for RK3568 a subtle bug was
> introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be
> the other way arround - that leads to random errors, especially when
> addresses beyond 32 bit are used.
>
> Fix it.
>
> Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2")
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
Applied for v5.16, thanks.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Alex Bee <knaerzche@gmail.com>
Cc: Will Deacon <will@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568
Date: Wed, 24 Nov 2021 17:34:35 +0100 [thread overview]
Message-ID: <YZ5pm2kFM41OOu+Y@8bytes.org> (raw)
In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com>
On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote:
> With the submission of iommu driver for RK3568 a subtle bug was
> introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be
> the other way arround - that leads to random errors, especially when
> addresses beyond 32 bit are used.
>
> Fix it.
>
> Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2")
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
Applied for v5.16, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Alex Bee <knaerzche@gmail.com>
Cc: Will Deacon <will@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568
Date: Wed, 24 Nov 2021 17:34:35 +0100 [thread overview]
Message-ID: <YZ5pm2kFM41OOu+Y@8bytes.org> (raw)
In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com>
On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote:
> With the submission of iommu driver for RK3568 a subtle bug was
> introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be
> the other way arround - that leads to random errors, especially when
> addresses beyond 32 bit are used.
>
> Fix it.
>
> Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2")
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
Applied for v5.16, thanks.
next prev parent reply other threads:[~2021-11-24 16:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 2:13 [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568 Alex Bee
2021-11-24 2:13 ` Alex Bee
2021-11-24 2:13 ` Alex Bee
2021-11-24 2:13 ` Alex Bee
2021-11-24 8:25 ` Benjamin Gaignard
2021-11-24 8:25 ` Benjamin Gaignard
2021-11-24 8:25 ` Benjamin Gaignard
2021-11-24 8:25 ` Benjamin Gaignard
2021-11-24 10:35 ` Heiko Stübner
2021-11-24 10:35 ` Heiko Stübner
2021-11-24 10:35 ` Heiko Stübner
2021-11-24 10:35 ` Heiko Stübner
2021-11-24 12:44 ` Peter Geis
2021-11-24 12:44 ` Peter Geis
2021-11-24 12:44 ` Peter Geis
2021-11-24 12:44 ` Peter Geis
2021-11-24 12:48 ` Dan Johansen
2021-11-24 16:34 ` Joerg Roedel [this message]
2021-11-24 16:34 ` Joerg Roedel
2021-11-24 16:34 ` Joerg Roedel
2021-11-24 16:34 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ5pm2kFM41OOu+Y@8bytes.org \
--to=joro@8bytes.org \
--cc=benjamin.gaignard@collabora.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=knaerzche@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.