From: Tzung-Bi Shih <tzungbi@google.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces
Date: Tue, 16 Nov 2021 17:24:01 +0800 [thread overview]
Message-ID: <YZN4se+Ihm2H20GG@google.com> (raw)
In-Reply-To: <20211111041500.17363-12-yunfei.dong@mediatek.com>
On Thu, Nov 11, 2021 at 12:14:52PM +0800, Yunfei Dong wrote:
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c
[...]
> +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx)
> {
[...]
> +
> + if (dev->subdev_dev[hw_idx])
> + return dev->subdev_dev[hw_idx];
> +
> + node = dev->subdev_node[hw_idx];
> + if (!node) {
> + mtk_v4l2_err("Get lat node fail:%d", hw_idx);
> + return NULL;
> + }
> +
> + hw_pdev = of_find_device_by_node(node);
> + of_node_put(node);
Raised the question in [v10,06/19] media: mtk-vcodec: Manage multi hardware information[1], is the reference count borrowed from mtk_vcodec_subdev_device_check? If so, it needs comments for documentation.
[1]: https://patchwork.linuxtv.org/project/linux-media/patch/20211111041500.17363-7-yunfei.dong@mediatek.com/
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces
Date: Tue, 16 Nov 2021 17:24:01 +0800 [thread overview]
Message-ID: <YZN4se+Ihm2H20GG@google.com> (raw)
In-Reply-To: <20211111041500.17363-12-yunfei.dong@mediatek.com>
On Thu, Nov 11, 2021 at 12:14:52PM +0800, Yunfei Dong wrote:
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c
[...]
> +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx)
> {
[...]
> +
> + if (dev->subdev_dev[hw_idx])
> + return dev->subdev_dev[hw_idx];
> +
> + node = dev->subdev_node[hw_idx];
> + if (!node) {
> + mtk_v4l2_err("Get lat node fail:%d", hw_idx);
> + return NULL;
> + }
> +
> + hw_pdev = of_find_device_by_node(node);
> + of_node_put(node);
Raised the question in [v10,06/19] media: mtk-vcodec: Manage multi hardware information[1], is the reference count borrowed from mtk_vcodec_subdev_device_check? If so, it needs comments for documentation.
[1]: https://patchwork.linuxtv.org/project/linux-media/patch/20211111041500.17363-7-yunfei.dong@mediatek.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces
Date: Tue, 16 Nov 2021 17:24:01 +0800 [thread overview]
Message-ID: <YZN4se+Ihm2H20GG@google.com> (raw)
In-Reply-To: <20211111041500.17363-12-yunfei.dong@mediatek.com>
On Thu, Nov 11, 2021 at 12:14:52PM +0800, Yunfei Dong wrote:
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c
[...]
> +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx)
> {
[...]
> +
> + if (dev->subdev_dev[hw_idx])
> + return dev->subdev_dev[hw_idx];
> +
> + node = dev->subdev_node[hw_idx];
> + if (!node) {
> + mtk_v4l2_err("Get lat node fail:%d", hw_idx);
> + return NULL;
> + }
> +
> + hw_pdev = of_find_device_by_node(node);
> + of_node_put(node);
Raised the question in [v10,06/19] media: mtk-vcodec: Manage multi hardware information[1], is the reference count borrowed from mtk_vcodec_subdev_device_check? If so, it needs comments for documentation.
[1]: https://patchwork.linuxtv.org/project/linux-media/patch/20211111041500.17363-7-yunfei.dong@mediatek.com/
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Fritz Koenig <frkoenig@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tomasz Figa <tfiga@google.com>, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tiffany Lin <tiffany.lin@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
Alexandre Courbot <acourbot@chromium.org>,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces
Date: Tue, 16 Nov 2021 17:24:01 +0800 [thread overview]
Message-ID: <YZN4se+Ihm2H20GG@google.com> (raw)
In-Reply-To: <20211111041500.17363-12-yunfei.dong@mediatek.com>
On Thu, Nov 11, 2021 at 12:14:52PM +0800, Yunfei Dong wrote:
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c
[...]
> +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx)
> {
[...]
> +
> + if (dev->subdev_dev[hw_idx])
> + return dev->subdev_dev[hw_idx];
> +
> + node = dev->subdev_node[hw_idx];
> + if (!node) {
> + mtk_v4l2_err("Get lat node fail:%d", hw_idx);
> + return NULL;
> + }
> +
> + hw_pdev = of_find_device_by_node(node);
> + of_node_put(node);
Raised the question in [v10,06/19] media: mtk-vcodec: Manage multi hardware information[1], is the reference count borrowed from mtk_vcodec_subdev_device_check? If so, it needs comments for documentation.
[1]: https://patchwork.linuxtv.org/project/linux-media/patch/20211111041500.17363-7-yunfei.dong@mediatek.com/
next prev parent reply other threads:[~2021-11-16 9:24 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 4:14 [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 01/19] media: mtk-vcodec: Get numbers of register bases from DT Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 03/19] media: mtk-vcodec: Refactor vcodec pm interface Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 04/19] media: mtk-vcodec: export decoder pm functions Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 05/19] media: mtk-vcodec: Support MT8192 Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 06/19] media: mtk-vcodec: Manage multi hardware information Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-16 9:23 ` Tzung-Bi Shih
2021-11-16 9:23 ` Tzung-Bi Shih
2021-11-16 9:23 ` Tzung-Bi Shih
2021-11-16 9:23 ` Tzung-Bi Shih
2021-11-11 4:14 ` [PATCH v10, 07/19] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 08/19] media: mtk-vcodec: Use pure single core for MT8183 Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 09/19] media: mtk-vcodec: Add irq interface for multi hardware Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-16 9:24 ` Tzung-Bi Shih [this message]
2021-11-16 9:24 ` Tzung-Bi Shih
2021-11-16 9:24 ` Tzung-Bi Shih
2021-11-16 9:24 ` Tzung-Bi Shih
2021-11-11 4:14 ` [PATCH v10, 12/19] media: mtk-vcodec: Add new interface to lock different hardware Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 13/19] media: mtk-vcodec: Add work queue for core hardware decode Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 14/19] media: mtk-vcodec: Support 34bits dma address for vdec Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10,14/19] " Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 14/19] " Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192 Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-14 21:56 ` Ezequiel Garcia
2021-11-14 21:56 ` Ezequiel Garcia
2021-11-14 21:56 ` Ezequiel Garcia
2021-11-14 21:56 ` Ezequiel Garcia
2021-11-16 12:05 ` yunfei.dong
2021-11-16 12:05 ` yunfei.dong
2021-11-16 12:05 ` yunfei.dong
2021-11-16 12:05 ` yunfei.dong
2021-11-11 4:14 ` [PATCH v10, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 17/19] media: mtk-vcodec: Use codec type to separate different hardware Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` [PATCH v10, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:14 ` Yunfei Dong
2021-11-11 4:15 ` [PATCH v10, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm Yunfei Dong
2021-11-11 4:15 ` Yunfei Dong
2021-11-11 4:15 ` Yunfei Dong
2021-11-11 4:15 ` Yunfei Dong
2021-11-14 22:04 ` [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate Ezequiel Garcia
2021-11-14 22:04 ` Ezequiel Garcia
2021-11-14 22:04 ` Ezequiel Garcia
2021-11-14 22:04 ` Ezequiel Garcia
2021-11-16 11:42 ` yunfei.dong
2021-11-16 11:42 ` yunfei.dong
2021-11-16 11:42 ` yunfei.dong
2021-11-16 11:42 ` yunfei.dong
2021-11-16 12:06 ` Ezequiel Garcia
2021-11-16 12:06 ` Ezequiel Garcia
2021-11-16 12:06 ` Ezequiel Garcia
2021-11-16 12:06 ` Ezequiel Garcia
2021-11-16 12:31 ` yunfei.dong
2021-11-16 12:31 ` yunfei.dong
2021-11-16 12:31 ` yunfei.dong
2021-11-16 12:31 ` yunfei.dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZN4se+Ihm2H20GG@google.com \
--to=tzungbi@google.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=benjamin.gaignard@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@chromium.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.