From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: devicetree@vger.kernel.org,
Linux-ALSA <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
cujomalainey@google.com, linux-kernel@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
linux-arm-kernel@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v4 3/3] mailbox: mediatek: add support for adsp mailbox controller
Date: Fri, 26 Nov 2021 12:43:23 +0800 [thread overview]
Message-ID: <YaBl66b7VFJK84F4@google.com> (raw)
In-Reply-To: <20211125122925.1303-4-allen-kh.cheng@mediatek.com>
On Thu, Nov 25, 2021 at 08:29:25PM +0800, allen-kh.cheng wrote:
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static bool mtk_adsp_mbox_last_tx_done(struct mbox_chan *chan)
> +{
> + struct adsp_mbox_ch_info *ch_info = chan->con_priv;
> + void __iomem *reg = ch_info->va_reg;
> +
> + return (readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0) ? true : false;
To be concise, readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0.
> +static int mtk_adsp_mbox_probe(struct platform_device *pdev)
> +{
[...]
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(dev, "no adsp mbox register resource\n");
> + return -ENXIO;
> + }
> +
> + priv->va_mboxreg = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(priv->va_mboxreg))
> + return PTR_ERR(priv->va_mboxreg);
If using devm_platform_ioremap_resource(), it doesn't need to call platform_get_resource(). res is unused.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
cujomalainey@google.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v4 3/3] mailbox: mediatek: add support for adsp mailbox controller
Date: Fri, 26 Nov 2021 12:43:23 +0800 [thread overview]
Message-ID: <YaBl66b7VFJK84F4@google.com> (raw)
In-Reply-To: <20211125122925.1303-4-allen-kh.cheng@mediatek.com>
On Thu, Nov 25, 2021 at 08:29:25PM +0800, allen-kh.cheng wrote:
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static bool mtk_adsp_mbox_last_tx_done(struct mbox_chan *chan)
> +{
> + struct adsp_mbox_ch_info *ch_info = chan->con_priv;
> + void __iomem *reg = ch_info->va_reg;
> +
> + return (readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0) ? true : false;
To be concise, readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0.
> +static int mtk_adsp_mbox_probe(struct platform_device *pdev)
> +{
[...]
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(dev, "no adsp mbox register resource\n");
> + return -ENXIO;
> + }
> +
> + priv->va_mboxreg = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(priv->va_mboxreg))
> + return PTR_ERR(priv->va_mboxreg);
If using devm_platform_ioremap_resource(), it doesn't need to call platform_get_resource(). res is unused.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
cujomalainey@google.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v4 3/3] mailbox: mediatek: add support for adsp mailbox controller
Date: Fri, 26 Nov 2021 12:43:23 +0800 [thread overview]
Message-ID: <YaBl66b7VFJK84F4@google.com> (raw)
In-Reply-To: <20211125122925.1303-4-allen-kh.cheng@mediatek.com>
On Thu, Nov 25, 2021 at 08:29:25PM +0800, allen-kh.cheng wrote:
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static bool mtk_adsp_mbox_last_tx_done(struct mbox_chan *chan)
> +{
> + struct adsp_mbox_ch_info *ch_info = chan->con_priv;
> + void __iomem *reg = ch_info->va_reg;
> +
> + return (readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0) ? true : false;
To be concise, readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0.
> +static int mtk_adsp_mbox_probe(struct platform_device *pdev)
> +{
[...]
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(dev, "no adsp mbox register resource\n");
> + return -ENXIO;
> + }
> +
> + priv->va_mboxreg = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(priv->va_mboxreg))
> + return PTR_ERR(priv->va_mboxreg);
If using devm_platform_ioremap_resource(), it doesn't need to call platform_get_resource(). res is unused.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
cujomalainey@google.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v4 3/3] mailbox: mediatek: add support for adsp mailbox controller
Date: Fri, 26 Nov 2021 12:43:23 +0800 [thread overview]
Message-ID: <YaBl66b7VFJK84F4@google.com> (raw)
In-Reply-To: <20211125122925.1303-4-allen-kh.cheng@mediatek.com>
On Thu, Nov 25, 2021 at 08:29:25PM +0800, allen-kh.cheng wrote:
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static bool mtk_adsp_mbox_last_tx_done(struct mbox_chan *chan)
> +{
> + struct adsp_mbox_ch_info *ch_info = chan->con_priv;
> + void __iomem *reg = ch_info->va_reg;
> +
> + return (readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0) ? true : false;
To be concise, readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0.
> +static int mtk_adsp_mbox_probe(struct platform_device *pdev)
> +{
[...]
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(dev, "no adsp mbox register resource\n");
> + return -ENXIO;
> + }
> +
> + priv->va_mboxreg = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(priv->va_mboxreg))
> + return PTR_ERR(priv->va_mboxreg);
If using devm_platform_ioremap_resource(), it doesn't need to call platform_get_resource(). res is unused.
next prev parent reply other threads:[~2021-11-26 4:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 12:29 [PATCH v4 0/3] This patches provide ADSP IPC support for MT8195 allen-kh.cheng
2021-11-25 12:29 ` allen-kh.cheng
2021-11-25 12:29 ` allen-kh.cheng
2021-11-25 12:29 ` [PATCH v4 1/3] dt-bindings: mediatek: add adsp-mbox document allen-kh.cheng
2021-11-25 12:29 ` allen-kh.cheng
2021-11-25 12:29 ` allen-kh.cheng
2021-11-25 12:29 ` [PATCH v4 2/3] firmware: mediatek: add adsp ipc protocol interface allen-kh.cheng
2021-11-25 12:29 ` allen-kh.cheng
2021-11-25 12:29 ` allen-kh.cheng
2021-11-26 4:43 ` Tzung-Bi Shih
2021-11-26 4:43 ` Tzung-Bi Shih
2021-11-26 4:43 ` Tzung-Bi Shih
2021-11-26 4:43 ` Tzung-Bi Shih
2021-11-25 12:29 ` [PATCH v4 3/3] mailbox: mediatek: add support for adsp mailbox controller allen-kh.cheng
2021-11-25 12:29 ` allen-kh.cheng
2021-11-25 12:29 ` allen-kh.cheng
2021-11-26 4:43 ` Tzung-Bi Shih [this message]
2021-11-26 4:43 ` Tzung-Bi Shih
2021-11-26 4:43 ` Tzung-Bi Shih
2021-11-26 4:43 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaBl66b7VFJK84F4@google.com \
--to=tzungbi@google.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.