From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: devicetree@vger.kernel.org,
Linux-ALSA <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
cujomalainey@google.com, linux-kernel@vger.kernel.org,
Jassi Brar <jassisinghbrar@gmail.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
linux-arm-kernel@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller
Date: Mon, 29 Nov 2021 15:12:12 +0800 [thread overview]
Message-ID: <YaR9TN7Aad5DYCg1@google.com> (raw)
In-Reply-To: <20211129063954.1616-4-allen-kh.cheng@mediatek.com>
On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote:
> From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
>
> This patch is to for MediaTek ADSP IPC mailbox controller driver
> It is used to send short messages between processors with adsp
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> Reviewed-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com>
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below.
With the minor comments:
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static const struct mbox_chan_ops adsp_mbox_chan_ops = {
> + .send_data = mtk_adsp_mbox_send_data,
> + .startup = mtk_adsp_mbox_startup,
> + .shutdown = mtk_adsp_mbox_shutdown,
> + .last_tx_done = mtk_adsp_mbox_last_tx_done,
> +};
Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me.
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
cujomalainey@google.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller
Date: Mon, 29 Nov 2021 15:12:12 +0800 [thread overview]
Message-ID: <YaR9TN7Aad5DYCg1@google.com> (raw)
In-Reply-To: <20211129063954.1616-4-allen-kh.cheng@mediatek.com>
On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote:
> From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
>
> This patch is to for MediaTek ADSP IPC mailbox controller driver
> It is used to send short messages between processors with adsp
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> Reviewed-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com>
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below.
With the minor comments:
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static const struct mbox_chan_ops adsp_mbox_chan_ops = {
> + .send_data = mtk_adsp_mbox_send_data,
> + .startup = mtk_adsp_mbox_startup,
> + .shutdown = mtk_adsp_mbox_shutdown,
> + .last_tx_done = mtk_adsp_mbox_last_tx_done,
> +};
Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
cujomalainey@google.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller
Date: Mon, 29 Nov 2021 15:12:12 +0800 [thread overview]
Message-ID: <YaR9TN7Aad5DYCg1@google.com> (raw)
In-Reply-To: <20211129063954.1616-4-allen-kh.cheng@mediatek.com>
On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote:
> From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
>
> This patch is to for MediaTek ADSP IPC mailbox controller driver
> It is used to send short messages between processors with adsp
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> Reviewed-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com>
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below.
With the minor comments:
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static const struct mbox_chan_ops adsp_mbox_chan_ops = {
> + .send_data = mtk_adsp_mbox_send_data,
> + .startup = mtk_adsp_mbox_startup,
> + .shutdown = mtk_adsp_mbox_shutdown,
> + .last_tx_done = mtk_adsp_mbox_last_tx_done,
> +};
Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
cujomalainey@google.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller
Date: Mon, 29 Nov 2021 15:12:12 +0800 [thread overview]
Message-ID: <YaR9TN7Aad5DYCg1@google.com> (raw)
In-Reply-To: <20211129063954.1616-4-allen-kh.cheng@mediatek.com>
On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote:
> From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
>
> This patch is to for MediaTek ADSP IPC mailbox controller driver
> It is used to send short messages between processors with adsp
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> Reviewed-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com>
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below.
With the minor comments:
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static const struct mbox_chan_ops adsp_mbox_chan_ops = {
> + .send_data = mtk_adsp_mbox_send_data,
> + .startup = mtk_adsp_mbox_startup,
> + .shutdown = mtk_adsp_mbox_shutdown,
> + .last_tx_done = mtk_adsp_mbox_last_tx_done,
> +};
Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me.
next prev parent reply other threads:[~2021-11-29 7:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 6:39 [PATCH v7 0/3] This patches provide ADSP IPC support for MT8195 allen-kh.cheng
2021-11-29 6:39 ` allen-kh.cheng
2021-11-29 6:39 ` allen-kh.cheng
2021-11-29 6:39 ` [PATCH v7 1/3] dt-bindings: mediatek: add adsp-mbox document allen-kh.cheng
2021-11-29 6:39 ` allen-kh.cheng
2021-11-29 6:39 ` allen-kh.cheng
2021-11-29 7:10 ` Tzung-Bi Shih
2021-11-29 7:10 ` Tzung-Bi Shih
2021-11-29 7:10 ` Tzung-Bi Shih
2021-11-29 7:10 ` Tzung-Bi Shih
2021-11-29 6:39 ` [PATCH v7 2/3] firmware: mediatek: add adsp ipc protocol interface allen-kh.cheng
2021-11-29 6:39 ` allen-kh.cheng
2021-11-29 6:39 ` allen-kh.cheng
2021-11-29 7:11 ` Tzung-Bi Shih
2021-11-29 7:11 ` Tzung-Bi Shih
2021-11-29 7:11 ` Tzung-Bi Shih
2021-11-29 7:11 ` Tzung-Bi Shih
2021-11-29 6:39 ` [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller allen-kh.cheng
2021-11-29 6:39 ` allen-kh.cheng
2021-11-29 6:39 ` allen-kh.cheng
2021-11-29 7:12 ` Tzung-Bi Shih [this message]
2021-11-29 7:12 ` Tzung-Bi Shih
2021-11-29 7:12 ` Tzung-Bi Shih
2021-11-29 7:12 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaR9TN7Aad5DYCg1@google.com \
--to=tzungbi@google.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.