* [PATCH 1/2] dt-bindings: media: Add compatible for D1
@ 2021-11-19 3:15 ` Samuel Holland
0 siblings, 0 replies; 12+ messages in thread
From: Samuel Holland @ 2021-11-19 3:15 UTC (permalink / raw)
To: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media
Cc: Rob Herring, devicetree, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec, linux-sunxi, Samuel Holland, linux-arm-kernel,
linux-kernel
D1 contains a video engine similar to the one in other sunxi SoCs.
Add a compatible for it.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
.../bindings/media/allwinner,sun4i-a10-video-engine.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
index c34303b87a5b..c3de96d10396 100644
--- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
+++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
@@ -20,6 +20,7 @@ properties:
- allwinner,sun8i-h3-video-engine
- allwinner,sun8i-v3s-video-engine
- allwinner,sun8i-r40-video-engine
+ - allwinner,sun20i-d1-video-engine
- allwinner,sun50i-a64-video-engine
- allwinner,sun50i-h5-video-engine
- allwinner,sun50i-h6-video-engine
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] media: cedrus: Add support for the D1 variant
2021-11-19 3:15 ` Samuel Holland
@ 2021-11-19 3:15 ` Samuel Holland
-1 siblings, 0 replies; 12+ messages in thread
From: Samuel Holland @ 2021-11-19 3:15 UTC (permalink / raw)
To: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media
Cc: Rob Herring, devicetree, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec, linux-sunxi, Samuel Holland, linux-arm-kernel,
linux-kernel, Greg Kroah-Hartman, linux-staging
D1 has a unique variant of the video engine, which appears to drop the
VP8 support found on most earlier variants.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/staging/media/sunxi/cedrus/cedrus.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c
index c76fc97d97a0..4a4b714b0f26 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -580,6 +580,14 @@ static const struct cedrus_variant sun8i_r40_cedrus_variant = {
.mod_rate = 297000000,
};
+static const struct cedrus_variant sun20i_d1_cedrus_variant = {
+ .capabilities = CEDRUS_CAPABILITY_UNTILED |
+ CEDRUS_CAPABILITY_MPEG2_DEC |
+ CEDRUS_CAPABILITY_H264_DEC |
+ CEDRUS_CAPABILITY_H265_DEC,
+ .mod_rate = 432000000,
+};
+
static const struct cedrus_variant sun50i_a64_cedrus_variant = {
.capabilities = CEDRUS_CAPABILITY_UNTILED |
CEDRUS_CAPABILITY_MPEG2_DEC |
@@ -637,6 +645,10 @@ static const struct of_device_id cedrus_dt_match[] = {
.compatible = "allwinner,sun8i-r40-video-engine",
.data = &sun8i_r40_cedrus_variant,
},
+ {
+ .compatible = "allwinner,sun20i-d1-video-engine",
+ .data = &sun20i_d1_cedrus_variant,
+ },
{
.compatible = "allwinner,sun50i-a64-video-engine",
.data = &sun50i_a64_cedrus_variant,
--
2.32.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] media: cedrus: Add support for the D1 variant
@ 2021-11-19 3:15 ` Samuel Holland
0 siblings, 0 replies; 12+ messages in thread
From: Samuel Holland @ 2021-11-19 3:15 UTC (permalink / raw)
To: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media
Cc: Rob Herring, devicetree, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec, linux-sunxi, Samuel Holland, linux-arm-kernel,
linux-kernel, Greg Kroah-Hartman, linux-staging
D1 has a unique variant of the video engine, which appears to drop the
VP8 support found on most earlier variants.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/staging/media/sunxi/cedrus/cedrus.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c
index c76fc97d97a0..4a4b714b0f26 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -580,6 +580,14 @@ static const struct cedrus_variant sun8i_r40_cedrus_variant = {
.mod_rate = 297000000,
};
+static const struct cedrus_variant sun20i_d1_cedrus_variant = {
+ .capabilities = CEDRUS_CAPABILITY_UNTILED |
+ CEDRUS_CAPABILITY_MPEG2_DEC |
+ CEDRUS_CAPABILITY_H264_DEC |
+ CEDRUS_CAPABILITY_H265_DEC,
+ .mod_rate = 432000000,
+};
+
static const struct cedrus_variant sun50i_a64_cedrus_variant = {
.capabilities = CEDRUS_CAPABILITY_UNTILED |
CEDRUS_CAPABILITY_MPEG2_DEC |
@@ -637,6 +645,10 @@ static const struct of_device_id cedrus_dt_match[] = {
.compatible = "allwinner,sun8i-r40-video-engine",
.data = &sun8i_r40_cedrus_variant,
},
+ {
+ .compatible = "allwinner,sun20i-d1-video-engine",
+ .data = &sun20i_d1_cedrus_variant,
+ },
{
.compatible = "allwinner,sun50i-a64-video-engine",
.data = &sun50i_a64_cedrus_variant,
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] media: cedrus: Add support for the D1 variant
2021-11-19 3:15 ` Samuel Holland
@ 2021-11-19 8:23 ` Maxime Ripard
-1 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2021-11-19 8:23 UTC (permalink / raw)
To: Samuel Holland
Cc: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media,
Rob Herring, devicetree, Chen-Yu Tsai, Jernej Skrabec,
linux-sunxi, linux-arm-kernel, linux-kernel, Greg Kroah-Hartman,
linux-staging
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
On Thu, Nov 18, 2021 at 09:15:18PM -0600, Samuel Holland wrote:
> D1 has a unique variant of the video engine, which appears to drop the
> VP8 support found on most earlier variants.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] media: cedrus: Add support for the D1 variant
@ 2021-11-19 8:23 ` Maxime Ripard
0 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2021-11-19 8:23 UTC (permalink / raw)
To: Samuel Holland
Cc: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media,
Rob Herring, devicetree, Chen-Yu Tsai, Jernej Skrabec,
linux-sunxi, linux-arm-kernel, linux-kernel, Greg Kroah-Hartman,
linux-staging
[-- Attachment #1.1: Type: text/plain, Size: 302 bytes --]
On Thu, Nov 18, 2021 at 09:15:18PM -0600, Samuel Holland wrote:
> D1 has a unique variant of the video engine, which appears to drop the
> VP8 support found on most earlier variants.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] media: cedrus: Add support for the D1 variant
2021-11-19 3:15 ` Samuel Holland
@ 2021-11-19 15:53 ` Jernej Škrabec
-1 siblings, 0 replies; 12+ messages in thread
From: Jernej Škrabec @ 2021-11-19 15:53 UTC (permalink / raw)
To: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media,
Samuel Holland
Cc: Rob Herring, devicetree, Maxime Ripard, Chen-Yu Tsai, linux-sunxi,
Samuel Holland, linux-arm-kernel, linux-kernel,
Greg Kroah-Hartman, linux-staging
Hi Samuel!
Dne petek, 19. november 2021 ob 04:15:18 CET je Samuel Holland napisal(a):
> D1 has a unique variant of the video engine, which appears to drop the
> VP8 support found on most earlier variants.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> drivers/staging/media/sunxi/cedrus/cedrus.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/
media/sunxi/cedrus/cedrus.c
> index c76fc97d97a0..4a4b714b0f26 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> @@ -580,6 +580,14 @@ static const struct cedrus_variant
sun8i_r40_cedrus_variant = {
> .mod_rate = 297000000,
> };
>
> +static const struct cedrus_variant sun20i_d1_cedrus_variant = {
> + .capabilities = CEDRUS_CAPABILITY_UNTILED |
> + CEDRUS_CAPABILITY_MPEG2_DEC |
> + CEDRUS_CAPABILITY_H264_DEC |
> + CEDRUS_CAPABILITY_H265_DEC,
Did you check if VP8 really doesn't work? It would be strange because it
shares decoding blocks with H264 and VP8 is present in (almost) all SoCs.
Best regards,
Jernej
> + .mod_rate = 432000000,
> +};
> +
> static const struct cedrus_variant sun50i_a64_cedrus_variant = {
> .capabilities = CEDRUS_CAPABILITY_UNTILED |
> CEDRUS_CAPABILITY_MPEG2_DEC |
> @@ -637,6 +645,10 @@ static const struct of_device_id cedrus_dt_match[] = {
> .compatible = "allwinner,sun8i-r40-video-engine",
> .data = &sun8i_r40_cedrus_variant,
> },
> + {
> + .compatible = "allwinner,sun20i-d1-video-engine",
> + .data = &sun20i_d1_cedrus_variant,
> + },
> {
> .compatible = "allwinner,sun50i-a64-video-engine",
> .data = &sun50i_a64_cedrus_variant,
> --
> 2.32.0
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] media: cedrus: Add support for the D1 variant
@ 2021-11-19 15:53 ` Jernej Škrabec
0 siblings, 0 replies; 12+ messages in thread
From: Jernej Škrabec @ 2021-11-19 15:53 UTC (permalink / raw)
To: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media,
Samuel Holland
Cc: Rob Herring, devicetree, Maxime Ripard, Chen-Yu Tsai, linux-sunxi,
Samuel Holland, linux-arm-kernel, linux-kernel,
Greg Kroah-Hartman, linux-staging
Hi Samuel!
Dne petek, 19. november 2021 ob 04:15:18 CET je Samuel Holland napisal(a):
> D1 has a unique variant of the video engine, which appears to drop the
> VP8 support found on most earlier variants.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> drivers/staging/media/sunxi/cedrus/cedrus.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/
media/sunxi/cedrus/cedrus.c
> index c76fc97d97a0..4a4b714b0f26 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> @@ -580,6 +580,14 @@ static const struct cedrus_variant
sun8i_r40_cedrus_variant = {
> .mod_rate = 297000000,
> };
>
> +static const struct cedrus_variant sun20i_d1_cedrus_variant = {
> + .capabilities = CEDRUS_CAPABILITY_UNTILED |
> + CEDRUS_CAPABILITY_MPEG2_DEC |
> + CEDRUS_CAPABILITY_H264_DEC |
> + CEDRUS_CAPABILITY_H265_DEC,
Did you check if VP8 really doesn't work? It would be strange because it
shares decoding blocks with H264 and VP8 is present in (almost) all SoCs.
Best regards,
Jernej
> + .mod_rate = 432000000,
> +};
> +
> static const struct cedrus_variant sun50i_a64_cedrus_variant = {
> .capabilities = CEDRUS_CAPABILITY_UNTILED |
> CEDRUS_CAPABILITY_MPEG2_DEC |
> @@ -637,6 +645,10 @@ static const struct of_device_id cedrus_dt_match[] = {
> .compatible = "allwinner,sun8i-r40-video-engine",
> .data = &sun8i_r40_cedrus_variant,
> },
> + {
> + .compatible = "allwinner,sun20i-d1-video-engine",
> + .data = &sun20i_d1_cedrus_variant,
> + },
> {
> .compatible = "allwinner,sun50i-a64-video-engine",
> .data = &sun50i_a64_cedrus_variant,
> --
> 2.32.0
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: Add compatible for D1
2021-11-19 3:15 ` Samuel Holland
@ 2021-11-19 8:22 ` Maxime Ripard
-1 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2021-11-19 8:22 UTC (permalink / raw)
To: Samuel Holland
Cc: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media,
Rob Herring, devicetree, Chen-Yu Tsai, Jernej Skrabec,
linux-sunxi, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
On Thu, Nov 18, 2021 at 09:15:17PM -0600, Samuel Holland wrote:
> D1 contains a video engine similar to the one in other sunxi SoCs.
> Add a compatible for it.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: Add compatible for D1
@ 2021-11-19 8:22 ` Maxime Ripard
0 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2021-11-19 8:22 UTC (permalink / raw)
To: Samuel Holland
Cc: Paul Kocialkowski, Mauro Carvalho Chehab, linux-media,
Rob Herring, devicetree, Chen-Yu Tsai, Jernej Skrabec,
linux-sunxi, linux-arm-kernel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 279 bytes --]
On Thu, Nov 18, 2021 at 09:15:17PM -0600, Samuel Holland wrote:
> D1 contains a video engine similar to the one in other sunxi SoCs.
> Add a compatible for it.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: Add compatible for D1
2021-11-19 3:15 ` Samuel Holland
@ 2021-11-29 23:12 ` Rob Herring
-1 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-11-29 23:12 UTC (permalink / raw)
To: Samuel Holland
Cc: Paul Kocialkowski, Maxime Ripard, Rob Herring, devicetree,
Mauro Carvalho Chehab, linux-media, Jernej Skrabec, linux-kernel,
linux-sunxi, Chen-Yu Tsai, linux-arm-kernel
On Thu, 18 Nov 2021 21:15:17 -0600, Samuel Holland wrote:
> D1 contains a video engine similar to the one in other sunxi SoCs.
> Add a compatible for it.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> .../bindings/media/allwinner,sun4i-a10-video-engine.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: Add compatible for D1
@ 2021-11-29 23:12 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-11-29 23:12 UTC (permalink / raw)
To: Samuel Holland
Cc: Paul Kocialkowski, Maxime Ripard, Rob Herring, devicetree,
Mauro Carvalho Chehab, linux-media, Jernej Skrabec, linux-kernel,
linux-sunxi, Chen-Yu Tsai, linux-arm-kernel
On Thu, 18 Nov 2021 21:15:17 -0600, Samuel Holland wrote:
> D1 contains a video engine similar to the one in other sunxi SoCs.
> Add a compatible for it.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> .../bindings/media/allwinner,sun4i-a10-video-engine.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread