All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-spi@vger.kernel.org,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mark Brown <broonie@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Michael Walle <michael@walle.cc>,
	devicetree@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
	linux-mtd@lists.infradead.org, Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH v2 5/5] spi: dt-bindings: Add an example with two stacked flashes
Date: Wed, 1 Dec 2021 17:57:15 -0600	[thread overview]
Message-ID: <YagL29VKiKZcu7KQ@robh.at.kernel.org> (raw)
In-Reply-To: <20211129102319.1efe1841@xps13>

On Mon, Nov 29, 2021 at 10:23:19AM +0100, Miquel Raynal wrote:
> Hi Rob,
> 
> robh@kernel.org wrote on Sun, 28 Nov 2021 10:55:06 -0600:
> 
> > On Sat, Nov 27, 2021 at 04:13:22PM -0700, Rob Herring wrote:
> > > On Fri, 26 Nov 2021 17:34:50 +0100, Miquel Raynal wrote:  
> > > > Provide an example of how to describe two flashes in eg. stacked mode.
> > > > 
> > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/spi/spi-controller.yaml | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > >   
> > > 
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > Documentation/devicetree/bindings/spi/spi-controller.example.dts:40.23-45.15: Warning (spi_bus_reg): /example-0/spi@80010000/flash@2,3: SPI bus unit address format error, expected "2"  
> > 
> > Unit-addresses are based on the first reg entry.
> 
> Yes, I believe this error is expected since dtc has not been yet
> updated. Below the patch for adapting dtc to this new situation and
> keep the robots happy.
> 
> How should we proceed?

No, I'm saying you have this wrong. A unit-address is composed of 
different fields, not different entries of the same field. For 
example, an external parallel bus has a chip select plus address, so the 
unit-address is '<cs>,<addr>'. If you have 2 SPI chip selects, that's 2 
entries of the same thing. The SPI bus is not 2 address cells, but 1 
cell with 2 entries.

Rob

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-spi@vger.kernel.org,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mark Brown <broonie@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Michael Walle <michael@walle.cc>,
	devicetree@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
	linux-mtd@lists.infradead.org, Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH v2 5/5] spi: dt-bindings: Add an example with two stacked flashes
Date: Wed, 1 Dec 2021 17:57:15 -0600	[thread overview]
Message-ID: <YagL29VKiKZcu7KQ@robh.at.kernel.org> (raw)
In-Reply-To: <20211129102319.1efe1841@xps13>

On Mon, Nov 29, 2021 at 10:23:19AM +0100, Miquel Raynal wrote:
> Hi Rob,
> 
> robh@kernel.org wrote on Sun, 28 Nov 2021 10:55:06 -0600:
> 
> > On Sat, Nov 27, 2021 at 04:13:22PM -0700, Rob Herring wrote:
> > > On Fri, 26 Nov 2021 17:34:50 +0100, Miquel Raynal wrote:  
> > > > Provide an example of how to describe two flashes in eg. stacked mode.
> > > > 
> > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/spi/spi-controller.yaml | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > >   
> > > 
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > Documentation/devicetree/bindings/spi/spi-controller.example.dts:40.23-45.15: Warning (spi_bus_reg): /example-0/spi@80010000/flash@2,3: SPI bus unit address format error, expected "2"  
> > 
> > Unit-addresses are based on the first reg entry.
> 
> Yes, I believe this error is expected since dtc has not been yet
> updated. Below the patch for adapting dtc to this new situation and
> keep the robots happy.
> 
> How should we proceed?

No, I'm saying you have this wrong. A unit-address is composed of 
different fields, not different entries of the same field. For 
example, an external parallel bus has a chip select plus address, so the 
unit-address is '<cs>,<addr>'. If you have 2 SPI chip selects, that's 2 
entries of the same thing. The SPI bus is not 2 address cells, but 1 
cell with 2 entries.

Rob

  reply	other threads:[~2021-12-01 23:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 16:34 [PATCH v2 0/5] Stacked/parallel memories bindings Miquel Raynal
2021-11-26 16:34 ` Miquel Raynal
2021-11-26 16:34 ` [PATCH v2 1/5] spi: dt-bindings: Allow describing flashes with two CS Miquel Raynal
2021-11-26 16:34   ` Miquel Raynal
2021-11-26 16:34 ` [PATCH v2 2/5] dt-bindings: mtd: spi-nor: Allow external properties Miquel Raynal
2021-11-26 16:34   ` Miquel Raynal
2021-12-02  0:05   ` Rob Herring
2021-12-02  0:05     ` Rob Herring
2021-12-02  7:25     ` Miquel Raynal
2021-12-02  7:25       ` Miquel Raynal
2021-12-02 15:51       ` Rob Herring
2021-12-02 15:51         ` Rob Herring
2021-11-26 16:34 ` [PATCH v2 3/5] dt-bindings: mtd: spi-nor: Allow two CS per device Miquel Raynal
2021-11-26 16:34   ` Miquel Raynal
2021-12-02  0:06   ` Rob Herring
2021-12-02  0:06     ` Rob Herring
2021-11-26 16:34 ` [PATCH v2 4/5] spi: dt-bindings: Describe stacked/parallel memories modes Miquel Raynal
2021-11-26 16:34   ` Miquel Raynal
2021-12-02  0:04   ` Rob Herring
2021-12-02  0:04     ` Rob Herring
2021-11-26 16:34 ` [PATCH v2 5/5] spi: dt-bindings: Add an example with two stacked flashes Miquel Raynal
2021-11-26 16:34   ` Miquel Raynal
2021-11-27 23:13   ` Rob Herring
2021-11-27 23:13     ` Rob Herring
2021-11-28 16:55     ` Rob Herring
2021-11-28 16:55       ` Rob Herring
2021-11-29  9:23       ` Miquel Raynal
2021-11-29  9:23         ` Miquel Raynal
2021-12-01 23:57         ` Rob Herring [this message]
2021-12-01 23:57           ` Rob Herring
2021-12-02  7:26           ` Miquel Raynal
2021-12-02  7:26             ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YagL29VKiKZcu7KQ@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=monstr@monstr.eu \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.